Skip to content

[Fix](orc-reader) Fix orc decimal128 scale issue. - #25977

Merged
xiaokang merged 1 commit into
apache:masterfrom
kaka11chen:fix_orc_decimal128_scale
Oct 26, 2023
Merged

[Fix](orc-reader) Fix orc decimal128 scale issue.#25977
xiaokang merged 1 commit into
apache:masterfrom
kaka11chen:fix_orc_decimal128_scale

Conversation

@kaka11chen

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Fix orc decimal128 scale issue.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@kaka11chen

Copy link
Copy Markdown
ContributorAuthor

run buildall

@morningmanmorningman added usercase Important user case type label dev/2.0.3 labels Oct 26, 2023

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 26, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.46 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162279278 Bytes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang
xiaokang merged commit c86fad7 into apache:masterOct 26, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@xiaokangxiaokang mentioned this pull request Dec 4, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedp0_wreviewedusercaseImportant user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kaka11chen@doris-robot@xiaokang@morningman