Uh oh!
There was an error while loading. Please reload this page.
2.0.2.1 oracle data format - #26112
Closed
zy-kkk wants to merge 1 commit into
Closed
Conversation
16 tasks
yiguolei pushed a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Jun 16, 2026
Issue Number: closeapache#26112 Related PR: None Problem Summary: Querying information_schema.columns with an external system table name such as table can call FrontendServiceImpl.getTableNames with the table name as a pattern. The MySQL pattern converter rejected '$' as a forbidden regex character, so the FE thrift service threw an internal getTableNames error before metadata resolution. This change treats '$' as a literal character in MySQL patterns by escaping it for the generated Java regex, allowing system table names to be matched safely. Fixes metadata lookup for table names containing '$', including external system tables such as table. - Test: Manual test - Ran git diff --check and git diff --cached --check. - Tried ./run-fe-ut.sh --run org.apache.doris.common.PatternMatcherTest, but the local environment only has JDK 11 and the script requires JDK 17. - Behavior changed: Yes. MySQL pattern matching now allows '$' as a literal table-name character. - Does this need documentation: No (cherry picked from commit 14c184f)
morningman pushed a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Jun 24, 2026
Issue Number: closeapache#26112 Related PR: None Problem Summary: Querying information_schema.columns with an external system table name such as table can call FrontendServiceImpl.getTableNames with the table name as a pattern. The MySQL pattern converter rejected '$' as a forbidden regex character, so the FE thrift service threw an internal getTableNames error before metadata resolution. This change treats '$' as a literal character in MySQL patterns by escaping it for the generated Java regex, allowing system table names to be matched safely. Fixes metadata lookup for table names containing '$', including external system tables such as table. - Test: Manual test - Ran git diff --check and git diff --cached --check. - Tried ./run-fe-ut.sh --run org.apache.doris.common.PatternMatcherTest, but the local environment only has JDK 11 and the script requires JDK 17. - Behavior changed: Yes. MySQL pattern matching now allows '$' as a literal table-name character. - Does this need documentation: No (cherry picked from commit 14c184f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...