[Feature](job)support cancel task and fix log invalid by CalvinKirs · Pull Request #27703 · apache/doris

CalvinKirs · 2023-11-28T10:03:11Z

Proposed changes

Running task can be show and fix cancel fail
When the insert task scheduling cycle is reached, if there are still tasks running, the scheduling of this task will be canceled at this time.
refactor job status changes SQL
Fix timer job window error
Support cancel task

todo

update other docs

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

CalvinKirs · 2023-11-28T10:03:23Z

run buildall

Running task can be show and fix cancel fail

CalvinKirs · 2023-11-28T10:14:51Z

run buildall

doris-robot · 2023-11-28T11:46:38Z

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit 6d00d889cb8b6998e360d31b2ae5ffab2b9017f7, data reload: false
run tpch-sf100 query with default conf and session variables
q1	4868	4672	4619	4619
q2	382	174	196	174
q3	2026	1922	1930	1922
q4	1404	1269	1259	1259
q5	3948	3992	4060	3992
q6	264	129	131	129
q7	1409	866	874	866
q8	2842	2815	2775	2775
q9	9996	9649	9589	9589
q10	3470	3490	3510	3490
q11	384	253	243	243
q12	448	298	294	294
q13	4572	3803	3810	3803
q14	320	281	300	281
q15	593	532	526	526
q16	487	476	466	466
q17	1142	980	907	907
q18	7962	7506	7532	7506
q19	1693	1690	1674	1674
q20	551	293	295	293
q21	4458	4020	4068	4020
q22	470	365	380	365
Total cold run time: 53689 ms
Total hot run time: 49193 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4613	4556	4562	4556
q2	342	224	251	224
q3	4092	4048	4034	4034
q4	2751	2726	2715	2715
q5	9822	9702	9713	9702
q6	245	122	122	122
q7	3010	2507	2518	2507
q8	4411	4405	4405	4405
q9	12942	12863	12901	12863
q10	4027	4129	4146	4129
q11	812	631	718	631
q12	961	809	802	802
q13	4310	3579	3514	3514
q14	384	345	349	345
q15	589	515	504	504
q16	581	556	577	556
q17	3910	3794	3856	3794
q18	9721	9127	9181	9127
q19	1831	1817	1783	1783
q20	2413	2034	2067	2034
q21	8830	8779	8884	8779
q22	881	795	804	795
Total cold run time: 81478 ms
Total hot run time: 77921 ms

doris-robot · 2023-11-28T11:51:54Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.84 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 27 seconds loaded 2358488459 Bytes, about 83 MB/s
stream load orc: 72 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.3 seconds inserted 10000000 Rows, about 353K ops/s
storage size: 17099288765 Bytes

…-task # Conflicts: # fe/fe-core/src/main/cup/sql_parser.cup

CalvinKirs · 2023-11-30T04:08:55Z

run buildall

CalvinKirs · 2023-11-30T04:44:37Z

run buildall

doris-robot · 2023-11-30T06:34:11Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.9 seconds
stream load tsv: 558 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162708948 Bytes

doris-robot · 2023-11-30T11:11:01Z

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit 2c8910e6f07bb0f1b645db415d857d12c2f4779e, data reload: false
run tpch-sf100 query with default conf and session variables
q1	4935	4690	4685	4685
q2	354	160	158	158
q3	1523	1329	1281	1281
q4	1144	1001	997	997
q5	3237	3243	3217	3217
q6	251	132	131	131
q7	1014	525	581	525
q8	2237	2241	2219	2219
q9	6971	6971	6942	6942
q10	3293	3372	3369	3369
q11	341	205	209	205
q12	354	214	220	214
q13	4631	3873	3847	3847
q14	250	211	219	211
q15	587	537	527	527
q16	429	381	378	378
q17	1039	715	623	623
q18	8074	8342	7445	7445
q19	1547	1569	1570	1569
q20	539	331	941	331
q21	3428	2974	2975	2974
q22	376	299	308	299
Total cold run time: 46554 ms
Total hot run time: 42147 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4655	4603	4615	4603
q2	322	209	205	205
q3	3779	3784	3756	3756
q4	2548	2531	2528	2528
q5	6207	6202	6202	6202
q6	254	124	126	124
q7	2617	1968	2012	1968
q8	3753	3701	3813	3701
q9	9454	9415	9381	9381
q10	4033	4149	4178	4149
q11	668	501	496	496
q12	819	624	639	624
q13	4397	3650	3601	3601
q14	281	259	264	259
q15	588	532	544	532
q16	530	518	523	518
q17	2156	2048	2071	2048
q18	9564	9004	8956	8956
q19	1791	1771	1774	1771
q20	2299	1968	1979	1968
q21	7215	7212	7056	7056
q22	675	580	569	569
Total cold run time: 68605 ms
Total hot run time: 65015 ms

zddr

LGTM

github-actions · 2023-12-04T02:41:10Z

PR approved by anyone and no changes requested.

morningman · 2023-12-04T03:58:22Z

Need to update the doc and add some test cases

CalvinKirs · 2023-12-04T07:31:07Z

Need to update the doc and add some test cases↳

The document is not yet public, I will provide it separately (when the show job is completed)

CalvinKirs · 2023-12-04T07:31:14Z

run buildall

doris-robot · 2023-12-04T09:36:31Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.38 seconds
stream load tsv: 562 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 27.8 seconds inserted 10000000 Rows, about 359K ops/s
storage size: 17163604996 Bytes

CalvinKirs · 2023-12-05T04:25:31Z

run buildall

CalvinKirs · 2023-12-05T05:55:41Z

run clickbench-new (clickbench)

CalvinKirs · 2023-12-05T06:54:52Z

run clickbench

…-task # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/job/extensions/insert/InsertTask.java

CalvinKirs · 2023-12-05T07:58:15Z

run buildall

CalvinKirs · 2023-12-05T10:26:50Z

run buildall

…-task # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/InsertIntoTableCommand.java # fe/fe-core/src/main/java/org/apache/doris/nereids/txn/Transaction.java

CalvinKirs · 2023-12-05T14:03:10Z

run buildall

morningman

LGTM

github-actions · 2023-12-05T14:51:50Z

PR approved by at least one committer and no changes requested.

doris-robot · 2023-12-05T15:08:35Z

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit f302b6c1ce9ff7fb49d8d55c1f04816e29bc0bff, data reload: false
run tpch-sf100 query with default conf and session variables
q1	4726	4508	4437	4437
q2	362	154	156	154
q3	1474	1218	1217	1217
q4	1122	889	893	889
q5	3161	3194	3192	3192
q6	247	132	131	131
q7	1000	500	484	484
q8	2218	2227	2192	2192
q9	6680	6666	6633	6633
q10	3226	3274	3261	3261
q11	332	210	209	209
q12	361	212	211	211
q13	4570	3817	3798	3798
q14	244	215	213	213
q15	577	519	524	519
q16	445	383	394	383
q17	1017	609	582	582
q18	7565	7048	6891	6891
q19	1521	1426	1396	1396
q20	524	371	302	302
q21	3083	2679	2652	2652
q22	363	290	298	290
Total cold run time: 44818 ms
Total hot run time: 40036 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4415	4383	4368	4368
q2	268	161	179	161
q3	3527	3523	3528	3523
q4	2377	2370	2376	2370
q5	5722	5727	5724	5724
q6	238	121	122	121
q7	2393	1898	1853	1853
q8	3511	3517	3521	3517
q9	9067	9024	9051	9024
q10	3875	4012	3970	3970
q11	497	381	392	381
q12	757	599	582	582
q13	4301	3568	3591	3568
q14	276	241	241	241
q15	579	519	518	518
q16	484	442	468	442
q17	1855	1855	1834	1834
q18	8675	8272	8271	8271
q19	1727	1758	1747	1747
q20	2242	1933	1947	1933
q21	6495	6153	6101	6101
q22	511	432	417	417
Total cold run time: 63792 ms
Total hot run time: 60666 ms

doris-robot · 2023-12-05T15:10:43Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.83 seconds
stream load tsv: 570 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17164329786 Bytes

CalvinKirs · 2023-12-06T01:57:28Z

run p0

- Running task can be show and fix cancel fail - When the insert task scheduling cycle is reached, if there are still tasks running, the scheduling of this task will be canceled at this time. - refactor job status changes SQL - Fix timer job window error - Support cancel task

…6232) ### What problem does this PR solve? When a task fails through the execution exception path, `AbstractTask.runTask()` calls the no-argument `onFail()`, which marked the task FAILED without recording `finishTimeMs`. MTMV failed refresh tasks therefore exposed an empty FinishTime and could not calculate DurationMs. relate PR: #27703 ### What changes were made? - Record `finishTimeMs` when `AbstractTask.onFail()` transitions a task to FAILED. - Add a regression unit test covering the `runTask()` exception path and preserving the error message. ### Testing - `AbstractJobStatusTest`: 13 tests passed.

…ache#66232) ### What problem does this PR solve? When a task fails through the execution exception path, `AbstractTask.runTask()` calls the no-argument `onFail()`, which marked the task FAILED without recording `finishTimeMs`. MTMV failed refresh tasks therefore exposed an empty FinishTime and could not calculate DurationMs. relate PR: apache#27703 ### What changes were made? - Record `finishTimeMs` when `AbstractTask.onFail()` transitions a task to FAILED. - Add a regression unit test covering the `runTask()` exception path and preserving the error message. ### Testing - `AbstractJobStatusTest`: 13 tests passed.

[Feature](job)support cancel task and fix log invalid
6d00d88
Running task can be show and fix cancel fail

CalvinKirs force-pushed the master-cancel-job-task branch from 7037027 to 6d00d88Compare November 28, 2023 10:08

CalvinKirs added 2 commits November 30, 2023 11:46

Support cancel and fix error timer window
cab25e0

Merge remote-tracking branch 'upstream/master' into master-cancel-job…
9163e8a
…-task # Conflicts: # fe/fe-core/src/main/cup/sql_parser.cup

CalvinKirs force-pushed the master-cancel-job-task branch from 5236b1f to 5b71dcaCompare December 1, 2023 02:08

zddr reviewed Dec 1, 2023
View reviewed changes

Support cancel and fix error timer window
84dcef7

CalvinKirs force-pushed the master-cancel-job-task branch from 8c71ae3 to 84dcef7Compare December 4, 2023 02:11

zddr approved these changes Dec 4, 2023
View reviewed changes

github-actionsBot added the reviewed label Dec 4, 2023

morningman reviewed Dec 4, 2023
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/job/scheduler/JobScheduler.java Outdated

CalvinKirs added 2 commits December 4, 2023 15:16

add log
a466a4f

add seco
99e69d6

add cancel task
301604f

CalvinKirs added 3 commits December 5, 2023 15:20

Merge remote-tracking branch 'upstream/master' into master-cancel-job…
8077cb5
…-task # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/job/extensions/insert/InsertTask.java

add task test
3db56fb

fix config error
6e6519a

CalvinKirs added 2 commits December 5, 2023 21:14

Merge remote-tracking branch 'upstream/master' into master-cancel-job…
88e1e18
…-task # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/InsertIntoTableCommand.java # fe/fe-core/src/main/java/org/apache/doris/nereids/txn/Transaction.java

support cancel insert
f302b6c

morningman approved these changes Dec 5, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 5, 2023

zy-kkk approved these changes Dec 6, 2023
View reviewed changes

zy-kkk merged commit cbf1f86 into apache:masterDec 6, 2023

yujun777 mentioned this pull request Jul 29, 2026
[fix](job scheduler) Record task finish time on execution failure #66232
Merged

Uh oh!

Conversation

CalvinKirs commented Nov 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

todo

Further comments

Uh oh!

CalvinKirs commented Nov 28, 2023

Uh oh!

CalvinKirs commented Nov 28, 2023

Uh oh!

doris-robot commented Nov 28, 2023

Uh oh!

doris-robot commented Nov 28, 2023

Uh oh!

CalvinKirs commented Nov 30, 2023

Uh oh!

CalvinKirs commented Nov 30, 2023

Uh oh!

doris-robot commented Nov 30, 2023

Uh oh!

doris-robot commented Nov 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zddr left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Dec 4, 2023

Uh oh!

Uh oh!

morningman commented Dec 4, 2023

Uh oh!

CalvinKirs commented Dec 4, 2023

Uh oh!

CalvinKirs commented Dec 4, 2023

Uh oh!

doris-robot commented Dec 4, 2023

Uh oh!

CalvinKirs commented Dec 5, 2023

Uh oh!

CalvinKirs commented Dec 5, 2023

Uh oh!

CalvinKirs commented Dec 5, 2023

Uh oh!

CalvinKirs commented Dec 5, 2023

Uh oh!

CalvinKirs commented Dec 5, 2023

Uh oh!

CalvinKirs commented Dec 5, 2023

Uh oh!

morningman left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Dec 5, 2023

Uh oh!

doris-robot commented Dec 5, 2023

Uh oh!

doris-robot commented Dec 5, 2023

Uh oh!

CalvinKirs commented Dec 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CalvinKirs commented Nov 28, 2023•
edited
Loading