[FIX](complextype)fix array/map/struct impl hashcode and equals by amorynan · Pull Request #27717 · apache/doris

amorynan · 2023-11-28T13:19:23Z

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

xiaokang · 2023-11-28T13:23:05Z

+ }
+
+ StructLiteral that = (StructLiteral) o;
+ for (int i = 0; i < children.size(); i++) {


check children.size() equal first to avoid index out of bound

amorynan · 2023-11-29T03:35:08Z

run buildall

amorynan · 2023-11-29T03:42:52Z

run clickbench

amorynan · 2023-11-29T03:47:37Z

run compile

amorynan · 2023-11-29T04:14:16Z

run buildall

amorynan · 2023-11-29T05:59:04Z

run buildall

xiaokang

LGTM

github-actions · 2023-11-29T06:57:06Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-11-29T06:57:08Z

PR approved by anyone and no changes requested.

doris-robot · 2023-11-29T07:57:19Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.42 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17099273449 Bytes

morrySnow · 2023-11-29T08:05:18Z

+ if (that.children.size() != children.size()) {
+ return false;
+ }


amorynan · 2023-11-29T08:26:04Z

run buildall

github-actions · 2023-11-29T08:47:24Z

PR approved by at least one committer and no changes requested.

doris-robot · 2023-11-29T10:15:32Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.42 seconds
stream load tsv: 570 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17101172485 Bytes

xiaokang

LGTM

amorynan · 2023-11-30T10:04:41Z

run beut

amorynan · 2023-11-30T10:04:49Z

run feut

amorynan · 2023-11-30T10:04:57Z

run clickbench

doris-robot · 2023-11-30T10:51:36Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.41 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17163907690 Bytes

doris-robot · 2023-11-30T12:53:00Z

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit 0e1e7b9a6ae9a891a9ff4973d8181196d3697d14, data reload: false
run tpch-sf100 query with default conf and session variables
q1	4902	4649	4660	4649
q2	359	154	157	154
q3	1500	1316	1318	1316
q4	1151	1017	968	968
q5	3266	3251	3223	3223
q6	253	133	133	133
q7	1005	524	563	524
q8	2213	2228	2230	2228
q9	6979	6989	6936	6936
q10	3280	3389	3375	3375
q11	343	225	244	225
q12	381	253	249	249
q13	4830	3860	3836	3836
q14	245	224	215	215
q15	576	534	522	522
q16	443	395	374	374
q17	1028	691	627	627
q18	8159	7818	7540	7540
q19	1549	1546	1543	1543
q20	602	304	315	304
q21	3416	2997	3003	2997
q22	376	303	305	303
Total cold run time: 46856 ms
Total hot run time: 42241 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4630	4574	4572	4572
q2	316	200	233	200
q3	3747	3734	3745	3734
q4	2527	2507	2503	2503
q5	6231	6187	6178	6178
q6	247	123	128	123
q7	2632	2003	1972	1972
q8	3766	3746	3681	3681
q9	9508	9414	9393	9393
q10	4069	4150	4158	4150
q11	651	512	484	484
q12	802	656	624	624
q13	4387	3653	3643	3643
q14	286	247	247	247
q15	586	523	537	523
q16	500	454	502	454
q17	2108	2076	2110	2076
q18	9510	9036	9940	9036
q19	1839	1780	1774	1774
q20	2309	1987	1952	1952
q21	7470	7073	6867	6867
q22	667	558	555	555
Total cold run time: 68788 ms
Total hot run time: 64741 ms

…he#27717)

fix array/map/struct impl hashcode and equals
b89ddd1

xiaokang reviewed Nov 28, 2023
View reviewed changes

wm1581066 added the dev/2.0.3 label Nov 29, 2023

apache deleted a comment from xiaokang Nov 29, 2023

morrySnow reviewed Nov 29, 2023
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java Outdated

wm1581066 added the p0_b label Nov 29, 2023

fixed
1e74341

Merge branch 'master' into fix-complex-type-basic-impl
fa1fac9

Merge branch 'master' into fix-complex-type-basic-impl
61c7973

amorynan mentioned this pull request Nov 29, 2023
[FIX](complextype)fix complex type hash equals #27743
Merged

xiaokang previously approved these changes Nov 29, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 29, 2023

github-actionsBot added the reviewed label Nov 29, 2023

morrySnow reviewed Nov 29, 2023
View reviewed changes

fix wrong if
f7ef4a7

amorynan dismissed xiaokang’s stale review via f7ef4a7November 29, 2023 08:25

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Nov 29, 2023

fix if struct
0e1e7b9

morrySnow approved these changes Nov 29, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 29, 2023

wm1581066 added dev/2.0.3-merged and removed dev/2.0.3 labels Nov 29, 2023

xiaokang approved these changes Nov 30, 2023
View reviewed changes

yiguolei merged commit 6c4ec3c into apache:masterNov 30, 2023

XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
[FIX](complextype)fix array/map/struct impl hashcode and equals (apac…
f583bed
…he#27717)

Uh oh!

Conversation

amorynan commented Nov 28, 2023

Proposed changes

Further comments

Uh oh!

Uh oh!

Uh oh!

xiaokangNov 28, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amorynan commented Nov 29, 2023

Uh oh!

amorynan commented Nov 29, 2023

Uh oh!

amorynan commented Nov 29, 2023

Uh oh!

amorynan commented Nov 29, 2023

Uh oh!

amorynan commented Nov 29, 2023

Uh oh!

xiaokang left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Nov 29, 2023

Uh oh!

github-actionsBot commented Nov 29, 2023

Uh oh!

doris-robot commented Nov 29, 2023

Uh oh!

Uh oh!

morrySnowNov 29, 2023

Choose a reason for hiding this comment

Uh oh!

amorynan commented Nov 29, 2023

Uh oh!

github-actionsBot commented Nov 29, 2023

Uh oh!

doris-robot commented Nov 29, 2023

Uh oh!

xiaokang left a comment

Choose a reason for hiding this comment

Uh oh!

amorynan commented Nov 30, 2023

Uh oh!

amorynan commented Nov 30, 2023

Uh oh!

amorynan commented Nov 30, 2023

Uh oh!

doris-robot commented Nov 30, 2023

Uh oh!

doris-robot commented Nov 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants