Skip to content

[agg](profile) fix incorrect profile - #28004

Merged
yiguolei merged 1 commit into
apache:masterfrom
jacktengg:agg-profile
Dec 5, 2023
Merged

[agg](profile) fix incorrect profile#28004
yiguolei merged 1 commit into
apache:masterfrom
jacktengg:agg-profile

Conversation

@jacktengg

@jacktenggjacktengg commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Aggregation node ExecTime is recounted, resulting it's larger than node Active time:

VAGGREGATION_NODE (id=114):(Active: 235.763ms, % non-child: 0.00%)
- AggInfos:: (_is_merge: false, _needs_finalize: true, Streaming Preaggregation: false, agg size: 1, limit: -1)
- BlocksProduced: 370
- BuildConvertToPartitionedTime: 0ns
- BuildTime: 212.40ms
- BytesProduced: 28.91 MB
- DeserializeAndMergeTime: 0ns
- ExecTime: 244.322ms

After fix:

VAGGREGATION_NODE (id=114):(Active: 243.280ms, % non-child: 0.00%)
- AggInfos: (_is_merge: false, _needs_finalize: true, Streaming Preaggregation: false, agg size: 1, limit: -1)
- BlocksProduced: 370
- BuildConvertToPartitionedTime: 0ns
- BytesProduced: 28.91 MB
- DeserializeAndMergeTime: 0ns
- ExecTime: 236.773ms

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@jacktengg
jacktengg marked this pull request as ready for review December 5, 2023 06:38
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@jacktengg

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 5, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@Gabriel39Gabriel39 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit fd1db4d into apache:masterDec 5, 2023
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Dec 8, 2023
eldenmoon added a commit that referenced this pull request Dec 8, 2023
* [fix](hudi-catalog) fix hudi catalog code (#27966)
backport: #27963
* [fix](Nereids): fix datetime fold-constant-be in Branch-2.0 (#27938)
fix fold-constant-be datetimev2 will lose the scale of datetime.
* [bug](function) fix compound expr coredump problem #27988 (#27989)
* [branch-2.0](cache) Fix partition cache support DATEV2 #27978 (#27990)
* [branch-2.0] delete auto partition docs (#28001)
* [fix](stats) Drop stats or update updated rows after truncate table (#27956)
1. Also clear follower's stats cache when doing drop stats.
2. Drop stats when truncate a table.
backport #27931
* [minor](stats) truncate min/max if too long #27955 (#27997)
* [agg](profile) fix incorrect profile (#28004) (#28035)
* [fix](remote-scanner-pool) missing _remote_thread_pool_max_size value #28057 (#28053)
bp #28057
* [enhance](partitionid) check partition id to avoid unexpected behavior (#28045)
* [opt](resource-tag) root and admin user can use any resource tag by default #28088 (#28080)
bp #28088
* [compile](compile option) add deflate to X86 only (#28089)
* change version to 2.0.3-rc05-var05
* [fix](Nereids): Preserve `""` in single quote strings and `''` in double quote strings. (#27959)
---------
Co-authored-by: Tiewei Fang <43782773+BePPPower@users.noreply.github.com>
Co-authored-by: jakevin <jakevingoo@gmail.com>
Co-authored-by: HappenLee <happenlee@hotmail.com>
Co-authored-by: Xinyi Zou <zouxinyi02@gmail.com>
Co-authored-by: zclllyybb <zhaochangle@selectdb.com>
Co-authored-by: Jibing-Li <64681310+Jibing-Li@users.noreply.github.com>
Co-authored-by: AKIRA <33112463+Kikyou1997@users.noreply.github.com>
Co-authored-by: TengJianPing <18241664+jacktengg@users.noreply.github.com>
Co-authored-by: Mingyu Chen <morningman@163.com>
Co-authored-by: Yongqiang YANG <98214048+dataroaring@users.noreply.github.com>
Co-authored-by: shuke <37901441+shuke987@users.noreply.github.com>
Co-authored-by: 谢健 <jianxie0@gmail.com>
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jacktengg@yiguolei@Gabriel39@xiaokang