Skip to content

Revert "[feature](merge-on-write) enable merge-on-write by default" - #28096

Merged
zhannngchen merged 1 commit into
masterfrom
revert-27188-make-merge-on-write-by-default
Dec 7, 2023
Merged

Revert "[feature](merge-on-write) enable merge-on-write by default"#28096
zhannngchen merged 1 commit into
masterfrom
revert-27188-make-merge-on-write-by-default

Conversation

@yiguolei

@yiguoleiyiguolei commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

Reverts #27188

@yiguolei

yiguolei commented Dec 7, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.

Don't know what should be done next? See How to process your PR

@doris-robot

doris-robot commented Dec 7, 2023

Copy link
Copy Markdown
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit a79a127d95d1e1ad543838d5f97caf397d260649, data reload: false
run tpch-sf100 query with default conf and session variables
q1	4721	4476	4498	4476
q2	364	151	156	151
q3	1474	1288	1224	1224
q4	1124	925	959	925
q5	3187	3169	3203	3169
q6	252	129	128	128
q7	1006	513	498	498
q8	2218	2174	2206	2174
q9	6735	6652	6685	6652
q10	3191	3251	3262	3251
q11	323	203	196	196
q12	353	213	214	213
q13	4570	3815	3835	3815
q14	240	214	218	214
q15	558	527	519	519
q16	449	387	388	387
q17	1018	593	629	593
q18	7744	7811	7075	7075
q19	1535	1387	1398	1387
q20	2182	318	539	318
q21	3176	2701	2709	2701
q22	381	291	299	291
Total cold run time: 46801 ms
Total hot run time: 40357 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4449	4417	4424	4417
q2	266	168	171	168
q3	3557	3541	3546	3541
q4	2385	2370	2372	2370
q5	5734	5755	5730	5730
q6	239	119	125	119
q7	2379	1860	1829	1829
q8	3527	3550	3539	3539
q9	9138	9002	9053	9002
q10	3923	3979	3990	3979
q11	503	374	379	374
q12	768	600	602	600
q13	4300	3544	3576	3544
q14	285	266	251	251
q15	565	516	515	515
q16	504	452	460	452
q17	1877	1833	1856	1833
q18	9503	8245	8314	8245
q19	1719	1742	1786	1742
q20	2263	1948	1961	1948
q21	6463	6194	6136	6136
q22	498	437	443	437
Total cold run time: 64845 ms
Total hot run time: 60771 ms

@doris-robot

doris-robot commented Dec 7, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.76 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17194161235 Bytes

@github-actions

github-actionsBot commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

xinyiZzz
xinyiZzz approved these changes Dec 7, 2023
View reviewed changes

@xinyiZzzxinyiZzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 7, 2023
@zhannngchen
zhannngchen merged commit 8c79b86 into masterDec 7, 2023
@bobhan1bobhan1 mentioned this pull request Dec 7, 2023
Merged
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@yiguolei胥剑旭
Revert "[feature](merge-on-write) enable merge-on-write by default (a…
95100b5
…pache#27188)" (apache#28096)
This reverts commit 00c8bab.
zhannngchen pushed a commit that referenced this pull request Dec 14, 2023
@bobhan1
[feature](merge-on-write) enable merge-on-write by default again (#28105
4300fdc
)
fix#27188, #28096
@morningman
morningman deleted the revert-27188-make-merge-on-write-by-default branch December 16, 2023 15:40
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
@bobhan1@HappenLee
[feature](merge-on-write) enable merge-on-write by default again (apa…
653aef8
…che#28105)
fixapache#27188, apache#28096
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@bobhan1@HappenLee
[feature](merge-on-write) enable merge-on-write by default again (apa…
259e7d2
…che#28105)
fixapache#27188, apache#28096
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xinyiZzzxinyiZzzxinyiZzz approved these changes
@zhannngchenzhannngchenzhannngchen approved these changes
+1 more reviewer
@ByteYueByteYueByteYue approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yiguolei@doris-robot@xinyiZzz@ByteYue@zhannngchen