Skip to content

[fix](test) fix case of test_unique_table_new_sequence - #28442

Merged
zhannngchen merged 2 commits into
apache:masterfrom
liaoxin01:fix_case
Dec 15, 2023
Merged

[fix](test) fix case of test_unique_table_new_sequence#28442
zhannngchen merged 2 commits into
apache:masterfrom
liaoxin01:fix_case

Conversation

@liaoxin01

@liaoxin01liaoxin01 commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

pr #28105 and #28031 merging conflict caused this case to fail.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@liaoxin01

Copy link
Copy Markdown
ContributorAuthor

run buildall

zhannngchen
zhannngchen previously approved these changes Dec 15, 2023

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 15, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Dec 15, 2023
@liaoxin01

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 15, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen
zhannngchen merged commit 088bb80 into apache:masterDec 15, 2023
hello-stephen pushed a commit to hello-stephen/doris that referenced this pull request Dec 28, 2023
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
@liaoxin01
liaoxin01 deleted the fix_case branch February 6, 2024 12:27
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.4reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@liaoxin01@zhannngchen@bobhan1@zhangstar333@xiaokang