Skip to content

(fix)[branch-2.0][export] fix replay export NPE issue - #28732

Merged
xiaokang merged 1 commit into
apache:branch-2.0from
morningman:branch-2.0-export-null
Dec 20, 2023
Merged

(fix)[branch-2.0][export] fix replay export NPE issue#28732
xiaokang merged 1 commit into
apache:branch-2.0from
morningman:branch-2.0-export-null

Conversation

@morningman

@morningmanmorningman commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

The ConnectionContext does not exist in replay thread

bp #28752

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actionsgithub-actionsBot added the area/planner Issues or PRs related to the query planner label Dec 20, 2023
@morningmanmorningman added the usercase Important user case type label label Dec 20, 2023
@morningman

Copy link
Copy Markdown
ContributorAuthor

run buildall

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 20, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.52 seconds
stream load tsv: 566 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.9 seconds inserted 10000000 Rows, about 334K ops/s
storage size: 17162594655 Bytes

@xiaokang
xiaokang merged commit 3ff82b5 into apache:branch-2.0Dec 20, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/plannerIssues or PRs related to the query plannerp0_breviewedusercaseImportant user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@morningman@doris-robot@xiaokang