Skip to content

[branch-2.0-fix](partial update) Don't use delete bitmap to mark delete for rows with delete sign when sequence column doesn't exist - #28800

Merged
zhannngchen merged 1 commit into
apache:branch-2.0from
bobhan1:branch-2.0-revert-delete-sign-optimzation
Dec 21, 2023
Merged

[branch-2.0-fix](partial update) Don't use delete bitmap to mark delete for rows with delete sign when sequence column doesn't exist#28800
zhannngchen merged 1 commit into
apache:branch-2.0from
bobhan1:branch-2.0-revert-delete-sign-optimzation

Conversation

@bobhan1

@bobhan1bobhan1 commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

reverts the optimization for delete sign on MOW table
pick from master: #26721

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
bobhan1force-pushed the branch-2.0-revert-delete-sign-optimzation branch from 591417d to 0ee3cffCompareDecember 21, 2023 08:25
@bobhan1

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.78% (7989/21144)
Line Coverage: 29.49% (64905/220074)
Region Coverage: 28.96% (33387/115296)
Branch Coverage: 24.83% (17128/68988)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0ee3cffa4e4db5c853f107c0dcf08ed83f4320db_0ee3cffa4e4db5c853f107c0dcf08ed83f4320db/report/index.html

@bobhan1

Copy link
Copy Markdown
ContributorAuthor

run clickbench

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.35 seconds
stream load tsv: 570 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 30.5 seconds inserted 10000000 Rows, about 327K ops/s
storage size: 17167883150 Bytes

@liaoxin01liaoxin01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen
zhannngchen merged commit 30934ff into apache:branch-2.0Dec 21, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.kind/testreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bobhan1@doris-robot@liaoxin01@zhannngchen