Uh oh!
There was an error while loading. Please reload this page.
[fix](hash join) fix stack overflow caused by evaluate case expr on huge build block - #28823
[fix](hash join) fix stack overflow caused by evaluate case expr on huge build block#28823jacktengg wants to merge 2 commits into
Conversation
jacktengg
commented
Dec 21, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
jacktengg
commented
Dec 21, 2023
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Dec 21, 2023
TeamCity be ut coverage result: |
doris-robot
commented
Dec 21, 2023
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
doris-robot
commented
Dec 21, 2023
(From new machine)TeamCity pipeline, clickbench performance test result: |
We're closing this PR because it hasn't been updated in a while. |
Proposed changes
Issue Number: close #xxx
Hash join operator will merge build blocks to a big block with a lot rows, and using variable length array in expr execution may cause stack overflow.
Also add
-Werror=vlacompiler option to report compile error by default andto ignore VLA usages where it's sure not to cause stack overflow.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...