Skip to content

[improvement](jdbc catalog) Optimize connection pool caching logic - #28857

Merged
xiaokang merged 1 commit into
apache:branch-2.0from
zy-kkk:jdbc_source_cache
Dec 26, 2023
Merged

[improvement](jdbc catalog) Optimize connection pool caching logic#28857
xiaokang merged 1 commit into
apache:branch-2.0from
zy-kkk:jdbc_source_cache

Conversation

@zy-kkk

@zy-kkkzy-kkk commented Dec 22, 2023

Copy link
Copy Markdown
Member

Proposed changes

Issue Number: close #xxx

In the old caching logic, we only used jdbcurl, user, and password as cache keys. This may cause the old link to be still used when replacing the jar package, so we should concatenate all the parameters required for the connection pool as the key.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zy-kkk

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.43 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.9 seconds inserted 10000000 Rows, about 334K ops/s
storage size: 17162352403 Bytes

@zy-kkk

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.28 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.7 seconds inserted 10000000 Rows, about 336K ops/s
storage size: 17167938430 Bytes

@xiaokang

Copy link
Copy Markdown
Contributor

#28859

@xiaokang
xiaokang merged commit b381e17 into apache:branch-2.0Dec 26, 2023
@zy-kkk
zy-kkk deleted the jdbc_source_cache branch March 22, 2024 03:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@zy-kkk@doris-robot@xiaokang