Skip to content

[chore](prompt) Optimize tablet and replica prompt by pointing out what the numbers mean#28925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Dec 24, 2023
Merged

[chore](prompt) Optimize tablet and replica prompt by pointing out what the numbers mean #28925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -837,7 +837,8 @@ private void addScanRangeLocations(Partition partition,
if (backend == null || !backend.isAlive()) {
LOG.debug("backend {} not exists or is not alive for replica {}", replica.getBackendId(),
replica.getId());
errs.add(replica.getId() + "'s backend " + replica.getBackendId() + " does not exist or not alive");
errs.add("replica " + replica.getId() + "'s backend " + replica.getBackendId()
+ " does not exist or not alive");
continue;
}
if (!backend.isMixNode()) {
Expand DownExpand Up@@ -875,7 +876,7 @@ private void addScanRangeLocations(Partition partition,
}
}
if (tabletIsNull) {
throw new UserException(tabletId + " have no queryable replicas. err: "
throw new UserException("tablet " + tabletId + " has no queryable replicas. err: "
+ Joiner.on(", ").join(errs));
}
TScanRange scanRange = new TScanRange();
Expand Down
4 changes: 2 additions & 2 deletions fe/fe-core/src/test/java/org/apache/doris/planner/ResourceTagQueryTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -225,7 +225,7 @@ public void test() throws Exception {
Assert.assertTrue(connectContext.isResourceTagsSet());
queryStr = "explain select * from test.tbl1";
String error = UtFrameUtils.getSQLPlanOrErrorMsg(connectContext, queryStr);
Assert.assertTrue(error.contains("have no queryable replicas"));
Assert.assertTrue(error.contains("no queryable replicas"));

// set [0, 1, 2] backends' tag to zone1, so that at least 1 replica can be queried.
// set tag for all backends. 0-2 to zone1, 4 and 5 to zone2
Expand DownExpand Up@@ -320,7 +320,7 @@ public void test() throws Exception {
queryStr = "explain select * from test_prop.tbl2";
explainString = UtFrameUtils.getSQLPlanOrErrorMsg(connectContext, queryStr);
System.out.println(explainString);
Assert.assertTrue(explainString.contains("have no queryable replicas"));
Assert.assertTrue(explainString.contains("no queryable replicas"));

// The priority of table is higher than db,should same with table
String createTableStr3 = "create table test_prop.tbl3\n"
Expand Down