Uh oh!
There was an error while loading. Please reload this page.
Add docker dev environment - #301
Merged
Merged
Conversation
imay
previously requested changes
Nov 12, 2018
imay
left a comment
Contributor
There was a problem hiding this comment.
you should change your commit log's subject to imperative mood
| @@ -0,0 +1,31 @@ | |||
| ## Doris Develop Environment based on docker | |||
Contributor
There was a problem hiding this comment.
you should add ASF license header, like this
| docker build -t palo:v1.0 . | ||
| -- palo is docker image repository name and base is tag name , you can change them to what you like |
Contributor
There was a problem hiding this comment.
you should better change palo to doris
| # add code repository | ||
| ADD thirdparty /var/local/thirdparty | ||
Contributor
There was a problem hiding this comment.
You should add palo source code in docker image too, otherwise you won't build palo.
morningman
requested changes
Nov 13, 2018
| # build third party | ||
| RUN /bin/bash thirdparty/build-thirdparty.sh \ | ||
| && ln -s ${DEFAULT_DIR}/thirdparty/installed/bin/thrift /usr/bin/thrift \ | ||
| && ln -s ${DEFAULT_DIR}/thirdparty/installed/ant/bin/ant /usr/bin/ant \ |
Contributor
There was a problem hiding this comment.
We are not using ant any more, using maven instead.
ContributorAuthor
There was a problem hiding this comment.
I have create docker directory and delete ant and change as other suggest
uestctxqforce-pushed
the
feature-docker-image
branch
from
November 15, 2018 13:30
d88d125 to
ada47afComparemorningman
dismissed
imay’s stale reviewNovember 16, 2018 08:33
Commit log can be changed when merge, no need to create a new patach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.