Uh oh!
There was an error while loading. Please reload this page.
[Enhancement] [plsql] support drop store procedure (#30966) - #31001
Conversation
doris-robot
commented
Feb 8, 2024
Thank you for your contribution to Apache Doris. |
Vallishp
commented
Feb 8, 2024
run buildall |
doris-robot
commented
Feb 8, 2024
TPC-H: Total hot run time: 41216 ms |
doris-robot
commented
Feb 8, 2024
TPC-DS: Total hot run time: 180486 ms |
doris-robot
commented
Feb 8, 2024
ClickBench: Total hot run time: 31.1 s |
doris-robot
commented
Feb 8, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
32dc678 to
c2b0633ComparemorrySnow
commented
Feb 18, 2024
could u use text instead of pic in description? text is search engine and git commit msg friendly |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Vallishp
commented
Feb 18, 2024
thanks for your comments. I will update it soon |
updated. thank you |
24f9b1b to
5f9af8dCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
xinyiZzz
commented
Feb 20, 2024
@Vallishp Doris plsql is modified based on hive hplsql, can continue to refer to hplsql grammar. If it conflicts with oracle, it will be compatible with oracle first. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…r.g4 Co-authored-by: morrySnow <101034200+morrySnow@users.noreply.github.com>
…alPlanBuilder.java Co-authored-by: morrySnow <101034200+morrySnow@users.noreply.github.com>
6cd60af to
aa8bbf8Compareaa8bbf8 to
66a9188CompareUh oh!
There was an error while loading. Please reload this page.
xinyiZzz
commented
Feb 21, 2024
run buildall |
doris-robot
commented
Feb 21, 2024
TPC-H: Total hot run time: 41247 ms |
doris-robot
commented
Feb 21, 2024
TPC-DS: Total hot run time: 177266 ms |
doris-robot
commented
Feb 21, 2024
ClickBench: Total hot run time: 30.75 s |
doris-robot
commented
Feb 21, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Uh oh!
There was an error while loading. Please reload this page.
xinyiZzz
commented
Feb 21, 2024
run buildall |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
doris-robot
commented
Feb 21, 2024
TPC-H: Total hot run time: 41936 ms |
doris-robot
commented
Feb 21, 2024
TPC-DS: Total hot run time: 176830 ms |
doris-robot
commented
Feb 21, 2024
ClickBench: Total hot run time: 30.83 s |
doris-robot
commented
Feb 21, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Proposed changes
Issue Number: close#30966
Support Drop stored procedure.
Unit test report.
mysql> delimiter //
mysql> CREATE OR REPLACE PROCEDURE procedure_select( IN id_n INT)
-> BEGIN
-> select * from plsql_tbl where id = id_n;
-> END
-> //
Query OK, 0 rows affected (0.05 sec)
mysql> call procedure_select(111)
-> ;//
+------+----------+
| id | name |
+------+----------+
| 111 | plsql111 |
+------+----------+
1 row in set (0.29 sec)
Query OK, 0 rows affected (0.29 sec)
mysql> drop procedure procedure_select;//
Query OK, 0 rows affected (0.03 sec)
mysql> call procedure_select(111) ;//
ERROR 1064 (HY000): plsql exec error, Ln:1 identifier 'procedure_select' must be declared.
mysql>
Meta info before and after the drop:
after create the dump of meta from FE.
"nameToStoredProcedures": [
[
{
"name": "PROCEDURE_SELECT",
"catalogName": "",
"dbName": ""
},
{
"name": "PROCEDURE_SELECT",
"catalogName": "",
"dbName": "",
"ownerName": "root",
"source": "CREATE OR REPLACE PROCEDURE procedure_select( IN id_n INT)\nBEGIN\n select * from plsql_tbl where id \u003d id_n;\nEND"
}
]
],
"nameToPackages": {}
}
y"header
after drop
:{
"nameToStoredProcedures": {},
"nameToPackages": {}
}
y"header
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...