Uh oh!
There was an error while loading. Please reload this page.
[enhancement](neredis)add PushDownFilterThroughGenerate rule - #31057
Merged
Conversation
doris-robot
commented
Feb 18, 2024
Thank you for your contribution to Apache Doris. |
starocean999
commented
Feb 18, 2024
ContributorAuthor
run buildall |
Comment on lines
+48
to
+49
| Set<Expression> pushDownPredicates = Sets.newHashSet(); | ||
| Set<Expression> remainPredicates = Sets.newHashSet(); |
Contributor
There was a problem hiding this comment.
Optional proposal: use Sets.newLinkedHashSet() to keep the order of the original expressions
924060929
approved these changes
Feb 18, 2024
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Feb 18, 2024
xiaokang pushed a commit
that referenced
this pull request
Feb 18, 2024
mymeiyi pushed a commit
to mymeiyi/doris
that referenced
this pull request
Feb 19, 2024
yiguolei pushed a commit
that referenced
this pull request
Feb 19, 2024
mongo360 pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...