Uh oh!
There was an error while loading. Please reload this page.
[nereids](topn-filter) support multi-topn filter (FE part) - #31485
Conversation
doris-robot
commented
Feb 27, 2024
Thank you for your contribution to Apache Doris. |
englefly
commented
Feb 28, 2024
run buildall |
1 similar comment
englefly
commented
Feb 28, 2024
run buildall |
doris-robot
commented
Feb 28, 2024
TPC-H: Total hot run time: 37960 ms |
doris-robot
commented
Feb 28, 2024
TPC-DS: Total hot run time: 168890 ms |
doris-robot
commented
Feb 28, 2024
ClickBench: Total hot run time: 32.91 s |
doris-robot
commented
Feb 28, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
englefly
commented
Feb 28, 2024
run buildall |
doris-robot
commented
Feb 28, 2024
TPC-H: Total hot run time: 38016 ms |
doris-robot
commented
Feb 28, 2024
TPC-DS: Total hot run time: 170045 ms |
doris-robot
commented
Feb 28, 2024
ClickBench: Total hot run time: 32.47 s |
doris-robot
commented
Feb 28, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
englefly
commented
Feb 28, 2024
run feut |
morrySnow
left a comment
There was a problem hiding this comment.
add enough test cases please
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
englefly
commented
Feb 29, 2024
run buildall |
b9d47cb to
b64e281Compareenglefly
commented
Mar 5, 2024
run buildall |
doris-robot
commented
Mar 5, 2024
TPC-H: Total hot run time: 38314 ms |
doris-robot
commented
Mar 5, 2024
TPC-DS: Total hot run time: 176855 ms |
doris-robot
commented
Mar 5, 2024
ClickBench: Total hot run time: 31.91 s |
englefly
commented
Mar 10, 2024
run buildall |
doris-robot
commented
Mar 10, 2024
TPC-H: Total hot run time: 37885 ms |
doris-robot
commented
Mar 10, 2024
TPC-DS: Total hot run time: 187179 ms |
doris-robot
commented
Mar 10, 2024
ClickBench: Total hot run time: 31.17 s |
doris-robot
commented
Mar 10, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
englefly
commented
Mar 10, 2024
run buildall |
doris-robot
commented
Mar 10, 2024
TPC-H: Total hot run time: 38076 ms |
doris-robot
commented
Mar 10, 2024
TPC-DS: Total hot run time: 186315 ms |
doris-robot
commented
Mar 10, 2024
ClickBench: Total hot run time: 31.34 s |
doris-robot
commented
Mar 10, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…ode (#46551) ### What problem does this PR solve? Plan node is not good to be hash map key, because two plan nodes in different tree level may be regarded as "equal". for example, in following tree, topn1.equals(topn2) may be true. Topn filter generator should distinguish them, and hence topn node is not suitable to be used as hash map key. topn1 -->some node -->topn2 -->other node Related PR: #31485
…ode (#46551) ### What problem does this PR solve? Plan node is not good to be hash map key, because two plan nodes in different tree level may be regarded as "equal". for example, in following tree, topn1.equals(topn2) may be true. Topn filter generator should distinguish them, and hence topn node is not suitable to be used as hash map key. topn1 -->some node -->topn2 -->other node Related PR: #31485
…ode (apache#46551) ### What problem does this PR solve? Plan node is not good to be hash map key, because two plan nodes in different tree level may be regarded as "equal". for example, in following tree, topn1.equals(topn2) may be true. Topn filter generator should distinguish them, and hence topn node is not suitable to be used as hash map key. topn1 -->some node -->topn2 -->other node Related PR: apache#31485 (cherry picked from commit 811f936)
…ode (#46551) (branch-3.0) (#46585) pick#46551 ### What problem does this PR solve? Plan node is not good to be hash map key, because two plan nodes in different tree level may be regarded as "equal". for example, in following tree, topn1.equals(topn2) may be true. Topn filter generator should distinguish them, and hence topn node is not suitable to be used as hash map key. topn1 -->some node -->topn2 -->other node Related PR: #31485 (cherry picked from commit 811f936)
…y instead of Topn node apache#46551 (apache#3800) pick apache#46551 ### What problem does this PR solve? Plan node is not good to be hash map key, because two plan nodes in different tree level may be regarded as "equal". for example, in following tree, topn1.equals(topn2) may be true. Topn filter generator should distinguish them, and hence topn node is not suitable to be used as hash map key. topn1 -->some node -->topn2 -->other node Related PR: apache#31485
Proposed changes
in previous version, topN should be the parent of scan. this restriction is removed.
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...