[feature](function) round function defaults to rounding normally by Mryange · Pull Request #31583 · apache/doris

Mryange · 2024-02-29T07:02:37Z

Proposed changes

Behavior change

before

mysql []>select round(5/2);
+------------------------------------------------+
| round((cast(5 as DOUBLE) / cast(2 as DOUBLE))) |
+------------------------------------------------+
| 2 |
+------------------------------------------------+
mysql []>select round_bankers(5/2);
+--------------------------------------------------------+
| round_bankers((cast(5 as DOUBLE) / cast(2 as DOUBLE))) |
+--------------------------------------------------------+
| 2 |
+--------------------------------------------------------+

now

mysql []>select round(5/2);
+------------------------------------------------+
| round((cast(5 as DOUBLE) / cast(2 as DOUBLE))) |
+------------------------------------------------+
| 3 |
+------------------------------------------------+
mysql []>select round_bankers(5/2);
+--------------------------------------------------------+
| round_bankers((cast(5 as DOUBLE) / cast(2 as DOUBLE))) |
+--------------------------------------------------------+
| 2 |
+--------------------------------------------------------+

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

doris-robot · 2024-02-29T07:02:42Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Mryange · 2024-02-29T07:03:37Z

run buildall

github-actions · 2024-02-29T07:12:31Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-02-29T07:31:29Z

TPC-H: Total hot run time: 37772 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f4a20c0a38b85f5d8dba5618752ccdb75d375daa, data reload: false
------ Round 1 ----------------------------------
q1	17630	4058	4043	4043
q2	2039	139	132	132
q3	10589	933	943	933
q4	4658	936	934	934
q5	7623	2873	2984	2873
q6	179	122	126	122
q7	1240	754	741	741
q8	9259	1965	2024	1965
q9	7210	6286	6244	6244
q10	8173	2488	2484	2484
q11	427	201	204	201
q12	760	318	316	316
q13	17961	3193	3225	3193
q14	287	254	253	253
q15	553	503	500	500
q16	462	407	410	407
q17	942	878	842	842
q18	6590	5969	6060	5969
q19	1572	1515	1511	1511
q20	568	273	265	265
q21	6393	3556	3560	3556
q22	807	292	288	288
Total cold run time: 105922 ms
Total hot run time: 37772 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4010	3994	4016	3994
q2	307	221	217	217
q3	3001	2959	2912	2912
q4	1811	1814	1835	1814
q5	5099	5104	5145	5104
q6	200	115	117	115
q7	2154	1701	1730	1701
q8	3117	3207	3185	3185
q9	8240	8234	8259	8234
q10	6198	3641	3627	3627
q11	520	423	434	423
q12	692	550	531	531
q13	3909	3065	3071	3065
q14	273	263	273	263
q15	547	494	492	492
q16	499	471	440	440
q17	1692	1666	1669	1666
q18	7802	7596	7255	7255
q19	1642	1629	1633	1629
q20	2071	1891	1904	1891
q21	4758	4625	4560	4560
q22	516	440	420	420
Total cold run time: 59058 ms
Total hot run time: 53538 ms

doris-robot · 2024-02-29T07:35:58Z

TeamCity be ut coverage result:
Function Coverage: 35.69% (8555/23969)
Line Coverage: 27.49% (69400/252468)
Region Coverage: 26.64% (35989/135092)
Branch Coverage: 23.45% (18392/78438)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f4a20c0a38b85f5d8dba5618752ccdb75d375daa_f4a20c0a38b85f5d8dba5618752ccdb75d375daa/report/index.html

doris-robot · 2024-02-29T07:42:10Z

TPC-DS: Total hot run time: 168982 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f4a20c0a38b85f5d8dba5618752ccdb75d375daa, data reload: false
query1	944	340	331	331
query2	6518	1786	1793	1786
query3	6691	201	199	199
query4	23316	20530	20624	20530
query5	4264	373	373	373
query6	277	163	163	163
query7	4611	294	295	294
query8	274	192	200	192
query9	8521	2236	2230	2230
query10	413	225	214	214
query11	14504	14174	14102	14102
query12	135	84	78	78
query13	1648	421	424	421
query14	8975	6762	6695	6695
query15	212	172	180	172
query16	7084	261	252	252
query17	1035	514	510	510
query18	1900	272	274	272
query19	198	147	148	147
query20	86	81	82	81
query21	191	121	131	121
query22	4683	4600	4295	4295
query23	30793	29998	29901	29901
query24	11859	3076	3025	3025
query25	638	353	345	345
query26	1741	159	163	159
query27	2947	311	327	311
query28	6926	1825	1816	1816
query29	1131	563	556	556
query30	285	131	146	131
query31	875	681	693	681
query32	97	63	55	55
query33	703	221	213	213
query34	1047	482	490	482
query35	847	748	750	748
query36	960	823	862	823
query37	124	61	65	61
query38	3104	2970	3015	2970
query39	1302	1262	1255	1255
query40	283	104	104	104
query41	39	36	35	35
query42	104	95	100	95
query43	481	414	421	414
query44	1065	696	720	696
query45	189	175	173	173
query46	1038	788	778	778
query47	1534	1486	1317	1317
query48	415	345	342	342
query49	1125	300	293	293
query50	773	378	374	374
query51	4351	4258	4299	4258
query52	105	89	85	85
query53	342	264	267	264
query54	296	225	224	224
query55	83	82	83	82
query56	225	208	205	205
query57	989	856	870	856
query58	209	187	193	187
query59	2206	1909	2103	1909
query60	231	216	228	216
query61	85	82	82	82
query62	611	337	362	337
query63	278	260	251	251
query64	6529	3053	3145	3053
query65	3245	3212	3239	3212
query66	1442	326	314	314
query67	14610	14050	14046	14046
query68	4998	573	569	569
query69	546	378	371	371
query70	1280	1259	1191	1191
query71	358	253	249	249
query72	6210	2818	2657	2657
query73	718	312	328	312
query74	6319	6051	5970	5970
query75	3052	2421	2417	2417
query76	2797	1037	1166	1037
query77	347	231	225	225
query78	9073	8539	8577	8539
query79	1031	556	535	535
query80	677	363	356	356
query81	449	194	192	192
query82	1292	91	85	85
query83	234	122	118	118
query84	275	83	76	76
query85	1141	361	339	339
query86	313	306	269	269
query87	3263	3131	3074	3074
query88	2728	2272	2262	2262
query89	379	331	330	330
query90	2019	169	171	169
query91	151	122	122	122
query92	56	48	48	48
query93	1060	543	516	516
query94	1102	191	180	180
query95	440	348	345	345
query96	576	257	262	257
query97	4313	4137	4155	4137
query98	227	227	196	196
query99	1015	647	663	647
Total cold run time: 263181 ms
Total hot run time: 168982 ms

doris-robot · 2024-02-29T07:47:38Z

ClickBench: Total hot run time: 32.32 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f4a20c0a38b85f5d8dba5618752ccdb75d375daa, data reload: false
query1	0.04	0.02	0.03
query2	0.06	0.02	0.02
query3	0.23	0.06	0.06
query4	1.67	0.10	0.10
query5	0.52	0.51	0.51
query6	1.32	0.64	0.68
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.55	0.51	0.50
query10	0.55	0.57	0.57
query11	0.13	0.10	0.10
query12	0.13	0.10	0.10
query13	0.62	0.62	0.62
query14	0.81	0.80	0.81
query15	0.84	0.81	0.82
query16	0.37	0.39	0.36
query17	0.98	0.96	0.99
query18	0.26	0.23	0.25
query19	1.86	1.72	1.72
query20	0.01	0.01	0.01
query21	15.42	0.64	0.63
query22	3.12	3.64	2.48
query23	17.41	1.12	0.93
query24	2.14	0.76	0.58
query25	0.28	0.05	0.04
query26	0.18	0.14	0.14
query27	0.03	0.03	0.03
query28	11.78	0.84	0.86
query29	12.57	3.21	3.18
query30	0.54	0.55	0.50
query31	2.78	0.35	0.35
query32	3.36	0.48	0.49
query33	3.18	3.19	3.22
query34	15.35	4.72	4.74
query35	4.71	4.75	4.74
query36	1.12	1.06	1.06
query37	0.07	0.05	0.05
query38	0.04	0.03	0.03
query39	0.02	0.02	0.01
query40	0.18	0.14	0.13
query41	0.08	0.01	0.02
query42	0.03	0.01	0.02
query43	0.03	0.02	0.02
Total cold run time: 105.43 s
Total hot run time: 32.32 s

doris-robot · 2024-02-29T07:50:48Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit f4a20c0a38b85f5d8dba5618752ccdb75d375daa with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 18.9 seconds inserted 10000000 Rows, about 529K ops/s

Mryange · 2024-02-29T11:24:03Z

run buildall

github-actions · 2024-02-29T11:33:35Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-02-29T12:12:59Z

TPC-H: Total hot run time: 37930 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4106875fad05093ab5f8293f3519c6b20b79d864, data reload: false
------ Round 1 ----------------------------------
q1	17728	4741	4079	4079
q2	2055	142	134	134
q3	10687	956	943	943
q4	4677	943	968	943
q5	7632	2896	3025	2896
q6	179	123	120	120
q7	1247	757	759	757
q8	9382	1929	2063	1929
q9	7328	6338	6335	6335
q10	8172	2497	2483	2483
q11	425	242	209	209
q12	731	310	313	310
q13	17963	3204	3203	3203
q14	271	255	253	253
q15	534	494	498	494
q16	485	401	408	401
q17	961	907	866	866
q18	6488	6081	5967	5967
q19	1576	1518	1522	1518
q20	569	279	273	273
q21	5491	3528	3590	3528
q22	785	289	296	289
Total cold run time: 105366 ms
Total hot run time: 37930 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4049	4027	4005	4005
q2	309	212	214	212
q3	3007	2954	2930	2930
q4	1840	1821	1818	1818
q5	5102	5112	5149	5112
q6	198	114	116	114
q7	2121	1703	1746	1703
q8	3146	3225	3268	3225
q9	8296	8324	8280	8280
q10	6232	3670	3652	3652
q11	508	428	428	428
q12	676	530	546	530
q13	3683	3058	3065	3058
q14	298	261	269	261
q15	544	492	485	485
q16	496	475	450	450
q17	1693	1683	1696	1683
q18	7765	7586	7620	7586
q19	1678	1638	1646	1638
q20	2095	1912	1881	1881
q21	4828	4667	4618	4618
q22	533	436	421	421
Total cold run time: 59097 ms
Total hot run time: 54090 ms

doris-robot · 2024-02-29T12:23:40Z

TPC-DS: Total hot run time: 168825 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4106875fad05093ab5f8293f3519c6b20b79d864, data reload: false
query1	926	335	332	332
query2	6536	1757	1779	1757
query3	6703	207	206	206
query4	23534	20568	20541	20541
query5	4287	370	361	361
query6	264	167	177	167
query7	4610	302	301	301
query8	259	193	198	193
query9	8456	2287	2268	2268
query10	414	215	219	215
query11	14590	14190	14196	14190
query12	130	79	84	79
query13	1646	438	439	438
query14	8885	6152	6109	6109
query15	213	170	175	170
query16	7090	264	258	258
query17	1032	525	501	501
query18	1900	270	273	270
query19	187	153	146	146
query20	87	81	82	81
query21	196	116	119	116
query22	4753	4545	4528	4528
query23	30514	29820	29891	29820
query24	11950	3048	3080	3048
query25	655	345	352	345
query26	1840	154	159	154
query27	3056	312	318	312
query28	7035	1851	1837	1837
query29	1238	573	558	558
query30	287	132	137	132
query31	865	661	688	661
query32	93	59	54	54
query33	702	228	217	217
query34	1033	499	495	495
query35	844	726	743	726
query36	967	859	852	852
query37	261	64	61	61
query38	3078	2957	3023	2957
query39	1319	1261	1253	1253
query40	278	103	103	103
query41	37	35	36	35
query42	106	94	99	94
query43	452	431	433	431
query44	1095	705	723	705
query45	188	180	169	169
query46	1059	820	809	809
query47	1485	1421	1376	1376
query48	425	348	345	345
query49	1177	299	295	295
query50	772	374	383	374
query51	4418	4289	4271	4271
query52	104	94	86	86
query53	337	267	269	267
query54	290	219	228	219
query55	83	88	81	81
query56	216	197	197	197
query57	968	870	865	865
query58	214	192	191	191
query59	2197	2208	2051	2051
query60	236	207	213	207
query61	87	87	89	87
query62	593	364	327	327
query63	279	256	253	253
query64	6514	2973	3113	2973
query65	3227	3217	3192	3192
query66	1431	323	314	314
query67	14574	14240	14038	14038
query68	5026	589	592	589
query69	524	377	372	372
query70	1299	1187	1223	1187
query71	392	250	264	250
query72	6259	2820	2644	2644
query73	726	334	332	332
query74	6260	5991	5949	5949
query75	3075	2447	2427	2427
query76	2798	1022	1149	1022
query77	347	253	242	242
query78	8879	8490	8382	8382
query79	1328	535	535	535
query80	1005	354	374	354
query81	481	199	197	197
query82	1021	87	88	87
query83	220	123	122	122
query84	283	80	77	77
query85	1328	369	368	368
query86	391	293	270	270
query87	3262	3103	3054	3054
query88	2801	2339	2342	2339
query89	389	338	346	338
query90	1863	170	175	170
query91	155	127	131	127
query92	58	53	49	49
query93	1243	545	525	525
query94	1222	186	186	186
query95	442	344	355	344
query96	573	260	262	260
query97	4254	4097	4175	4097
query98	213	204	196	196
query99	1128	670	706	670
Total cold run time: 264522 ms
Total hot run time: 168825 ms

doris-robot · 2024-02-29T12:29:09Z

ClickBench: Total hot run time: 31.78 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4106875fad05093ab5f8293f3519c6b20b79d864, data reload: false
query1	0.04	0.03	0.03
query2	0.06	0.02	0.02
query3	0.23	0.05	0.06
query4	1.68	0.10	0.10
query5	0.52	0.51	0.52
query6	1.27	0.69	0.68
query7	0.02	0.01	0.01
query8	0.04	0.02	0.02
query9	0.55	0.51	0.52
query10	0.56	0.59	0.55
query11	0.13	0.10	0.10
query12	0.12	0.10	0.10
query13	0.62	0.60	0.60
query14	0.77	0.82	0.79
query15	0.82	0.83	0.81
query16	0.36	0.36	0.40
query17	0.96	0.98	1.01
query18	0.25	0.28	0.26
query19	1.77	1.69	1.72
query20	0.02	0.01	0.01
query21	15.40	0.65	0.67
query22	3.00	3.54	2.13
query23	17.52	1.02	1.03
query24	2.12	0.21	0.61
query25	0.30	0.08	0.04
query26	0.17	0.14	0.15
query27	0.03	0.04	0.03
query28	12.32	0.84	0.84
query29	12.49	3.19	3.42
query30	0.57	0.54	0.50
query31	2.79	0.35	0.36
query32	3.35	0.47	0.49
query33	3.22	3.21	3.19
query34	15.36	4.76	4.75
query35	4.77	4.76	4.76
query36	1.14	1.06	1.06
query37	0.06	0.04	0.04
query38	0.04	0.03	0.03
query39	0.02	0.02	0.01
query40	0.16	0.13	0.14
query41	0.07	0.02	0.02
query42	0.02	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 105.74 s
Total hot run time: 31.78 s

doris-robot · 2024-02-29T12:32:17Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 4106875fad05093ab5f8293f3519c6b20b79d864 with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 18.1 seconds inserted 10000000 Rows, about 552K ops/s

doris-robot · 2024-02-29T12:32:47Z

TeamCity be ut coverage result:
Function Coverage: 35.69% (8555/23971)
Line Coverage: 27.48% (69392/252509)
Region Coverage: 26.64% (35987/135109)
Branch Coverage: 23.44% (18390/78446)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4106875fad05093ab5f8293f3519c6b20b79d864_4106875fad05093ab5f8293f3519c6b20b79d864/report/index.html

Mryange · 2024-02-29T14:15:46Z

run buildall

github-actions · 2024-02-29T14:25:35Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-02-29T14:47:31Z

TeamCity be ut coverage result:
Function Coverage: 35.67% (8553/23979)
Line Coverage: 27.46% (69384/252669)
Region Coverage: 26.62% (36001/135239)
Branch Coverage: 23.43% (18390/78498)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a1e8e63f7137d18dd728b8935e38206a472a5674_a1e8e63f7137d18dd728b8935e38206a472a5674/report/index.html

doris-robot · 2024-02-29T14:59:08Z

TPC-H: Total hot run time: 37611 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a1e8e63f7137d18dd728b8935e38206a472a5674, data reload: false
------ Round 1 ----------------------------------
q1	17752	3937	3978	3937
q2	2049	147	139	139
q3	10566	935	925	925
q4	4666	932	937	932
q5	7641	2863	2988	2863
q6	181	126	124	124
q7	1299	827	822	822
q8	9492	2008	2065	2008
q9	7258	6446	6487	6446
q10	8228	2530	2536	2530
q11	427	214	212	212
q12	756	316	312	312
q13	17992	2973	2907	2907
q14	291	249	277	249
q15	474	437	442	437
q16	461	389	394	389
q17	935	878	861	861
q18	6575	5820	5845	5820
q19	1549	1506	1512	1506
q20	539	273	281	273
q21	7517	3634	3699	3634
q22	805	301	285	285
Total cold run time: 107453 ms
Total hot run time: 37611 ms
----- Round 2, with runtime_filter_mode=off -----
q1	3975	3999	3976	3976
q2	313	219	223	219
q3	2961	2942	2878	2878
q4	1841	1807	1840	1807
q5	5212	5228	5218	5218
q6	200	116	115	115
q7	2226	1806	1806	1806
q8	3174	3249	3257	3249
q9	8453	8502	8504	8502
q10	6110	3729	3696	3696
q11	523	437	457	437
q12	678	528	552	528
q13	8936	2766	2747	2747
q14	279	253	247	247
q15	467	437	427	427
q16	452	421	414	414
q17	1677	1656	1644	1644
q18	7856	7420	7298	7298
q19	1611	1588	1614	1588
q20	1999	1725	1711	1711
q21	4959	4783	4667	4667
q22	560	478	456	456
Total cold run time: 64462 ms
Total hot run time: 53630 ms

HappenLee · 2024-03-02T07:17:18Z


 static VectorType prepare(size_t scale) { return load1(scale); }
 };
+// for float number use round up or bankers


should use the simd version to do the work

HappenLee · 2024-03-02T07:37:05Z

+ template <RoundingMode mode>
+ static VectorType apply(VectorType val) {
+ if constexpr (tie_breaking_mode == TieBreakingMode::Bankers) {
+ return nearbyintf(val);


ScalarType* val;
val1 val2
VectorType res;
ScalaType* res_t;

Mryange · 2024-03-02T08:35:51Z

run buildall

github-actions · 2024-03-02T08:39:00Z

clang-tidy review says "All clean, LGTM! 👍"

zclllyybb · 2024-03-02T08:46:12Z

 static VectorType apply(VectorType val) {
- return _mm_round_pd(val, int(mode));
+ if constexpr (mode != RoundingMode::Round) {
+ return _mm_round_pd(val, int(mode));


we could use a marco to check the SSE4.1 enable state. and use the most proper simd instructions with _mm or _mm256. u can see the similar usage in our code.

doris-robot · 2024-03-02T11:19:20Z

TeamCity be ut coverage result:
Function Coverage: 35.42% (8553/24145)
Line Coverage: 27.19% (69414/255247)
Region Coverage: 26.41% (36016/136350)
Branch Coverage: 23.25% (18393/79102)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5febb24d8d79f99aae009f71da7ab1505092a135_5febb24d8d79f99aae009f71da7ab1505092a135/report/index.html

Mryange · 2024-03-03T10:59:56Z

run buildall

github-actions · 2024-03-03T11:08:34Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-03-03T11:31:55Z

TeamCity be ut coverage result:
Function Coverage: 35.43% (8554/24146)
Line Coverage: 27.20% (69421/255253)
Region Coverage: 26.41% (36006/136350)
Branch Coverage: 23.25% (18392/79102)
Coverage Report: http://coverage.selectdb-in.cc/coverage/057721a07ba946f6002c2bb0f1ac71aeb42ea094_057721a07ba946f6002c2bb0f1ac71aeb42ea094/report/index.html

Mryange · 2024-03-03T23:57:27Z

run buildall

doris-robot · 2024-03-04T00:30:11Z

TeamCity be ut coverage result:
Function Coverage: 35.43% (8554/24146)
Line Coverage: 27.19% (69413/255253)
Region Coverage: 26.41% (36007/136350)
Branch Coverage: 23.25% (18392/79102)
Coverage Report: http://coverage.selectdb-in.cc/coverage/057721a07ba946f6002c2bb0f1ac71aeb42ea094_057721a07ba946f6002c2bb0f1ac71aeb42ea094/report/index.html

Mryange · 2024-03-04T06:38:57Z

run buildall

github-actions · 2024-03-04T06:47:54Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-03-04T07:19:27Z

TeamCity be ut coverage result:
Function Coverage: 35.44% (8555/24140)
Line Coverage: 27.20% (69425/255237)
Region Coverage: 26.42% (36023/136339)
Branch Coverage: 23.26% (18397/79108)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b85736dc84ee16165f40498c7b1647e0e7cd94f9_b85736dc84ee16165f40498c7b1647e0e7cd94f9/report/index.html

Mryange · 2024-03-04T07:57:41Z

run buildall

github-actions · 2024-03-04T08:03:48Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-03-04T08:26:35Z

TeamCity be ut coverage result:
Function Coverage: 35.44% (8555/24141)
Line Coverage: 27.20% (69428/255256)
Region Coverage: 26.42% (36023/136348)
Branch Coverage: 23.26% (18406/79120)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c2f218fa6daf8c3c59f03294c90cd03470237e16_c2f218fa6daf8c3c59f03294c90cd03470237e16/report/index.html

HappenLee

LGTM

github-actions · 2024-03-05T02:16:40Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-03-05T02:16:43Z

PR approved by anyone and no changes requested.

zclllyybb

LGTM

… (#32050)

…he#31583 (apache#32050)

cambyzju added the kind/behavior-changed label Feb 29, 2024

xiaokang added the dev/2.0.x label Feb 29, 2024

Mryange force-pushed the float-round-up branch 2 times, most recently from 8d6bb44 to 69f6ea3Compare February 29, 2024 11:23

HappenLee reviewed Mar 2, 2024
View reviewed changes

Mryange force-pushed the float-round-up branch from a1e8e63 to 49bba2dCompare March 2, 2024 08:30

zclllyybb reviewed Mar 2, 2024
View reviewed changes

Comment threadbe/src/vec/functions/round.h Outdated

Mryange force-pushed the float-round-up branch from 057721a to b85736dCompare March 4, 2024 06:38

upd
c2f218f

Mryange force-pushed the float-round-up branch from b85736d to c2f218fCompare March 4, 2024 07:54

HappenLee approved these changes Mar 5, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 5, 2024

github-actionsBot added the reviewed label Mar 5, 2024

zclllyybb approved these changes Mar 5, 2024
View reviewed changes

Gabriel39 approved these changes Mar 5, 2024
View reviewed changes

HappenLee merged commit b288736 into apache:masterMar 5, 2024

cambyzju mentioned this pull request Mar 12, 2024
[feature](function) round function defaults to rounding normally #32050
Merged

xiaokang pushed a commit that referenced this pull request Mar 13, 2024
[feature](function) round function defaults to rounding normally#31583…
9605afa
… (#32050)

xiaokang added dev/2.0.7-merged and removed dev/2.0.x labels Mar 13, 2024

xiaokang mentioned this pull request Mar 22, 2024
Release Note 2.0.7 #32677
Closed

Mryange mentioned this pull request Mar 28, 2024
[Bug] doris Function round imprecision #32942
Closed
3 tasks

mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
[feature](function) round function defaults to rounding normallyapac…
51d592a
…he#31583 (apache#32050)

Uh oh!

Conversation

Mryange commented Feb 29, 2024

Proposed changes

Further comments

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

Mryange commented Feb 29, 2024

Uh oh!

github-actionsBot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

Mryange commented Feb 29, 2024

Uh oh!

github-actionsBot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

Mryange commented Feb 29, 2024

Uh oh!

github-actionsBot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

doris-robot commented Feb 29, 2024

Uh oh!

HappenLeeMar 2, 2024

Choose a reason for hiding this comment

Uh oh!

HappenLeeMar 2, 2024

Choose a reason for hiding this comment

Uh oh!

Mryange commented Mar 2, 2024

Uh oh!

github-actionsBot commented Mar 2, 2024

Uh oh!

zclllyybbMar 2, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

doris-robot commented Mar 2, 2024

Uh oh!

Mryange commented Mar 3, 2024

Uh oh!

github-actionsBot commented Mar 3, 2024

Uh oh!

doris-robot commented Mar 3, 2024

Uh oh!

Mryange commented Mar 3, 2024

Uh oh!

doris-robot commented Mar 4, 2024

Uh oh!

Mryange commented Mar 4, 2024

Uh oh!

github-actionsBot commented Mar 4, 2024

Uh oh!

doris-robot commented Mar 4, 2024

Uh oh!

Mryange commented Mar 4, 2024

Uh oh!

github-actionsBot commented Mar 4, 2024

Uh oh!