Uh oh!
There was an error while loading. Please reload this page.
[fix](plan) only scan node with limit and no predicate can reduce to 1 instance (#31342) - #31606
Merged
Merged
Conversation
morningman
commented
Feb 29, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Feb 29, 2024
Thank you for your contribution to Apache Doris. |
doris-robot
commented
Feb 29, 2024
TPC-H: Total hot run time: 50005 ms |
doris-robot
commented
Feb 29, 2024
TPC-DS: Total hot run time: 202310 ms |
doris-robot
commented
Feb 29, 2024
ClickBench: Total hot run time: 30.71 s |
doris-robot
commented
Feb 29, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
…1 instance (apache#31342) This PR apache#25952 introduce a opt that if a scan node has limit and predicates, use only 1 instance to save cup and memory. But this is wrong because we can not guarantee that the predicates can truly help to prune the data. So I modify the logic to remove this opt. Now, only scan node with limit and NO predicate can reduce to only 1 instance.
morningman
commented
Mar 1, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Mar 1, 2024
TPC-H: Total hot run time: 49722 ms |
doris-robot
commented
Mar 1, 2024
TPC-DS: Total hot run time: 202539 ms |
doris-robot
commented
Mar 1, 2024
ClickBench: Total hot run time: 30.5 s |
doris-robot
commented
Mar 1, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
mongo360 pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…1 instance (apache#31342) (apache#31606) This PR apache#25952 introduce a opt that if a scan node has limit and predicates, use only 1 instance to save cup and memory. But this is wrong because we can not guarantee that the predicates can truly help to prune the data. So I modify the logic to remove this opt. Now, only scan node with limit and NO predicate can reduce to only 1 instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bp #31342