Skip to content

[enhance](mtmv)Mtmv rollup - #31812

Merged
morrySnow merged 46 commits into
apache:masterfrom
zddr:mtmv_rollup
May 14, 2024
Merged

[enhance](mtmv)Mtmv rollup#31812
morrySnow merged 46 commits into
apache:masterfrom
zddr:mtmv_rollup

Conversation

@zddr

@zddrzddr commented Mar 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

if create MTMV date_trunc(xxx,'month')
when related table is range partition,and have 3 partitions:

20200101-20200102
20200102-20200103
20200201-20200202

then MTMV will have 2 partitions:

20200101-20200201
20200201-20200301

when related table is list partition,and have 3 partitions:

(20200101,20200102)
(20200103)
(20200201)

then MTMV will have 2 partitions:

(20200101,20200102，20200103)
(20200201)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented Mar 5, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@zddr
zddr marked this pull request as draft March 5, 2024 11:18
@zddr
zddr marked this pull request as ready for review May 8, 2024 05:46
@zddr

zddr commented May 8, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@zddr

zddr commented May 8, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@seawinde

seawinde commented May 8, 2024

Copy link
Copy Markdown
Member

check null partition is correct in the partition roll up scene

@github-actions

github-actionsBot commented May 8, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zddr

zddr commented May 9, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@zddr

zddr commented May 9, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

morrySnow
morrySnow reviewed May 10, 2024
View reviewed changes

@morrySnowmorrySnow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are too many util function for async mv. We should add unit test for them

Comment thread...rc/main/java/org/apache/doris/nereids/trees/plans/commands/info/MTMVPartitionDefinition.java
Comment thread...rc/main/java/org/apache/doris/nereids/trees/plans/commands/info/MTMVPartitionDefinition.java Outdated
Comment thread...rc/main/java/org/apache/doris/nereids/trees/plans/commands/info/MTMVPartitionDefinition.java Outdated
Comment threadfe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
Comment threadfe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVRelatedPartitionDescRollUpGenerator.java
Comment threadfe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPartitionExprDateTrunc.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPartitionExprDateTrunc.java
Comment threadfe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPartitionInfo.java
Comment threadfe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPartitionUtil.java Outdated
Comment thread...rc/main/java/org/apache/doris/nereids/trees/plans/commands/info/MTMVPartitionDefinition.java
@zddr

zddr commented May 13, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

morrySnow
morrySnow approved these changes May 14, 2024
View reviewed changes
Comment threadfe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
Comment on lines +229 to +230
: partitionKey = identifier
| partitionExpr = functionCallExpression

@morrySnowmorrySnowMay 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: u could write like

Suggested change
: partitionKey = identifier
| partitionExpr = functionCallExpression
: identifier #partitionKey
| functionCallExpression partitionExpr

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 14, 2024
@github-actions

github-actionsBot commented May 14, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

1 similar comment
@github-actions

github-actionsBot commented May 14, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@morrySnow
morrySnow merged commit 235506b into apache:masterMay 14, 2024
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
@zddr@ByteYue
[feature](mtmv) create mtmv support partitions rollup (apache#31812)
802cfb2
if create MTMV `date_trunc(`xxx`,'month')`
when related table is `range` partition,and have 3 partitions:
```
20200101-20200102
20200102-20200103
20200201-20200202
```
then MTMV will have 2 partitions:
```
20200101-20200201
20200201-20200301
```
when related table is `list` partition,and have 3 partitions:
```
(20200101,20200102)
(20200103)
(20200201)
```
then MTMV will have 2 partitions:
```
(20200101,20200102，20200103)
(20200201)
```
yiguolei pushed a commit that referenced this pull request May 18, 2024
@zddr@Doris-Extras
[feature](mtmv) create mtmv support partitions rollup (#31812)
30a036e
if create MTMV `date_trunc(`xxx`,'month')`
when related table is `range` partition,and have 3 partitions:
```
20200101-20200102
20200102-20200103
20200201-20200202
```
then MTMV will have 2 partitions:
```
20200101-20200201
20200201-20200301
```
when related table is `list` partition,and have 3 partitions:
```
(20200101,20200102)
(20200103)
(20200201)
```
then MTMV will have 2 partitions:
```
(20200101,20200102，20200103)
(20200201)
```
@morningmanmorningman mentioned this pull request Jun 22, 2024
Closed
@yiguoleiyiguolei mentioned this pull request Jul 19, 2024
Closed
1 task
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zddr@HappenLee
[feature](mtmv) create mtmv support partitions rollup (apache#31812)
038b814
if create MTMV `date_trunc(`xxx`,'month')`
when related table is `range` partition,and have 3 partitions:
```
20200101-20200102
20200102-20200103
20200201-20200202
```
then MTMV will have 2 partitions:
```
20200101-20200201
20200201-20200301
```
when related table is `list` partition,and have 3 partitions:
```
(20200101,20200102)
(20200103)
(20200201)
```
then MTMV will have 2 partitions:
```
(20200101,20200102，20200103)
(20200201)
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnowmorrySnowmorrySnow approved these changes
@seawindeseawindeseawinde approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.4-mergeddev/3.0.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zddr@doris-robot@seawinde@morrySnow@dataroaring