Uh oh!
There was an error while loading. Please reload this page.
[feature](Nereids): support make miss slot as null alias when converting anti join - #31854
Merged
Conversation
doris-robot
commented
Mar 6, 2024
Thank you for your contribution to Apache Doris. |
keanji-x
commented
Mar 6, 2024
ContributorAuthor
run buildall |
morrySnow
previously approved these changes
Mar 6, 2024
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
keanji-x
commented
Mar 7, 2024
ContributorAuthor
run buildall |
xzj7019
reviewed
Mar 7, 2024
| return null; | ||
| } | ||
| if (!newJoin.getOutputSet().containsAll(filter.getInputSlots())) { |
Contributor
There was a problem hiding this comment.
do we need to add cases to cover null as (b.id1 + b.id2)?
xzj7019
reviewed
Mar 7, 2024
| contains "OUTER JOIN" | ||
| } | ||
| explain { |
Contributor
There was a problem hiding this comment.
does this will do or-expansion and side b can be converted to anti?
ContributorAuthor
There was a problem hiding this comment.
orExpansion is behind convertToAnti, so it is not supported right now.
morrySnow
previously approved these changes
Mar 7, 2024
Contributor
PR approved by at least one committer and no changes requested. |
keanji-x
commented
Mar 7, 2024
ContributorAuthor
run buildall |
morrySnow
commented
Mar 7, 2024
Contributor
run p0 |
morrySnow
approved these changes
Mar 7, 2024
Contributor
PR approved by at least one committer and no changes requested. |
xzj7019
approved these changes
Mar 7, 2024
yiguolei pushed a commit
that referenced
this pull request
Mar 9, 2024
…ng anti join (#31854) transform project(A.*, B.slot) - filter(B.slot is null) - LeftOuterJoin(A, B) to project(A.*, null as B.slot) - LeftAntiJoin(A, B)
keanji-x added a commit
to keanji-x/doris
that referenced
this pull request
Mar 18, 2024
…ng anti join (apache#31854) transform project(A.*, B.slot) - filter(B.slot is null) - LeftOuterJoin(A, B) to project(A.*, null as B.slot) - LeftAntiJoin(A, B)
keanji-x added a commit
to keanji-x/doris
that referenced
this pull request
Mar 18, 2024
…ng anti join (apache#31854) transform project(A.*, B.slot) - filter(B.slot is null) - LeftOuterJoin(A, B) to project(A.*, null as B.slot) - LeftAntiJoin(A, B)
keanji-x added a commit
to keanji-x/doris
that referenced
this pull request
Mar 18, 2024
…ng anti join (apache#31854) transform project(A.*, B.slot) - filter(B.slot is null) - LeftOuterJoin(A, B) to project(A.*, null as B.slot) - LeftAntiJoin(A, B)
morrySnow pushed a commit
that referenced
this pull request
Mar 19, 2024
…nti join (#31854) (#32417) pick from master #31854 and #32214 [feature](Nereids) support make miss slot as null alias when converting anti join (#31854) transform project(A.*, B.slot) - filter(B.slot is null) - LeftOuterJoin(A, B) to project(A.*, null as B.slot) - LeftAntiJoin(A, B) [fix](Nereids): don't pushdown project when project contains both side of join (#32214)
Closed
mongo360 pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…nti join (apache#31854) (apache#32417) pick from master apache#31854 and apache#32214 [feature](Nereids) support make miss slot as null alias when converting anti join (apache#31854) transform project(A.*, B.slot) - filter(B.slot is null) - LeftOuterJoin(A, B) to project(A.*, null as B.slot) - LeftAntiJoin(A, B) [fix](Nereids): don't pushdown project when project contains both side of join (apache#32214)
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…ng anti join (apache#31854) transform project(A.*, B.slot) - filter(B.slot is null) - LeftOuterJoin(A, B) to project(A.*, null as B.slot) - LeftAntiJoin(A, B)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...