Uh oh!
There was an error while loading. Please reload this page.
[Feature][external catalog/lakesoul] support lakesoul catalog - #32164
Merged
morningman merged 37 commits intoMay 27, 2024
Conversation
doris-robot
commented
Mar 13, 2024
Thank you for your contribution to Apache Doris. |
Contributor
|
Contributor
|
Contributor
|
Contributor
|
Contributor
|
Contributor
|
Ceng23333force-pushed
the
external_catalog/lakesoul_catalog
branch
from
March 18, 2024 07:18
cee3d1c to
87609f1Compare| return Status::OK(); | ||
| } | ||
| Status LakeSoulJniReader::get_columns(std::unordered_map<std::string, TypeDescriptor>* name_to_type, |
Contributor
There was a problem hiding this comment.
warning: method 'get_columns' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status LakeSoulJniReader::get_columns(std::unordered_map<std::string, TypeDescriptor>* name_to_type, | |
| staticStatus LakeSoulJniReader::get_columns(std::unordered_map<std::string, TypeDescriptor>* name_to_type, |
| return Status::OK(); | ||
| } | ||
| Status LakeSoulJniReader::init_reader( |
Contributor
There was a problem hiding this comment.
warning: method 'init_reader' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status LakeSoulJniReader::init_reader( | |
| staticStatus LakeSoulJniReader::init_reader( |
| #pragma once | ||
| #include <stddef.h> |
Contributor
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers]
Suggested change
| #include<stddef.h> | |
| #include<cstddef> |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
Ceng23333force-pushed
the
external_catalog/lakesoul_catalog
branch
from
March 18, 2024 07:46
15fcd00 to
e6adb8fCompareContributor
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
| return Status::OK(); | ||
| } | ||
| Status LakeSoulJniReader::get_columns( |
Contributor
There was a problem hiding this comment.
warning: method 'get_columns' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status LakeSoulJniReader::get_columns( | |
| staticStatus LakeSoulJniReader::get_columns( |
morningmanforce-pushed
the
external_catalog/lakesoul_catalog
branch
from
May 7, 2024 12:57
0d63ca7 to
9920620CompareContributor
clang-tidy review says "All clean, LGTM! 👍" |
morningman
commented
May 7, 2024
Contributor
run buildall |
doris-robot
commented
May 7, 2024
TeamCity be ut coverage result: |
morningmanforce-pushed
the
external_catalog/lakesoul_catalog
branch
from
May 12, 2024 15:28
9920620 to
025ccf0Comparemorningman
commented
May 12, 2024
Contributor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
May 12, 2024
TeamCity be ut coverage result: |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
morningman
commented
May 15, 2024
Contributor
run buildall |
Signed-off-by: zenghua <441651826@qq.com>
Signed-off-by: zenghua <441651826@qq.com>
Signed-off-by: zenghua <441651826@qq.com>
Signed-off-by: zenghua <441651826@qq.com>
Signed-off-by: zenghua <441651826@qq.com>
Signed-off-by: zenghua <441651826@qq.com>
Signed-off-by: dmetasoul01 <opensource@dmetasoul.com>
Signed-off-by: dmetasoul01 <opensource@dmetasoul.com>
xuchen-plusforce-pushed
the
external_catalog/lakesoul_catalog
branch
from
May 27, 2024 07:54
53917d2 to
375989fCompareContributor
clang-tidy review says "All clean, LGTM! 👍" |
morningman
commented
May 27, 2024
Contributor
run buildall |
doris-robot
commented
May 27, 2024
TPC-H: Total hot run time: 40056 ms |
doris-robot
commented
May 27, 2024
TPC-DS: Total hot run time: 169290 ms |
doris-robot
commented
May 27, 2024
ClickBench: Total hot run time: 31.39 s |
doris-robot
commented
May 27, 2024
TeamCity be ut coverage result: |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
dataroaring pushed a commit
that referenced
this pull request
May 28, 2024
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
morningman added a commit
to morningman/doris
that referenced
this pull request
Sep 3, 2026
`.gitignore` has had a bare `.github` entry under its "# other" section since 9b5a464 ("[Feature][external catalog/lakesoul] support lakesoul catalog", apache#32164), a change that otherwise has nothing to do with CI and touched only those two .gitignore lines -- it looks accidental. The existing files under .github survived only because they were already tracked when the entry was added; .gitignore does not affect tracked files. The entry therefore has no useful effect today, and two harmful ones: * Any NEW file under .github -- a workflow, an action, CODEOWNERS, an issue template -- is silently ignored. `git status` does not list it and `git add` refuses it without -f, so it is easy to open a PR that is missing it. * Even for a tracked file, `git add .github/workflows/foo.yml` prints "The following paths are ignored by one of your .gitignore files" and exits non-zero, which breaks `git add ... && git commit ...` in scripts. Removing the entry exposes no untracked files: `git status --untracked-files=all .github/` is empty afterwards. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017omcvWDsxEc9AyU83aBZ2g
12 tasks
hello-stephen pushed a commit
that referenced
this pull request
Sep 3, 2026
…67491) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #66957 (introduced the title-checker regression), #67487 (a PR currently blocked by it) Problem Summary: Two independent bugs in the repository's `.github` tooling, both of which make it easy to get a PR wrong for reasons unrelated to its content. --- #### 1. The PR title checker rejects any hyphen in the type or scope ``` [fix](arrow-flight) ... [feature](inverted-index) ... [improvement](github-actions) ... ``` **88 of the last 1500 commits on master use such a title**, including #66957 itself — the change that introduced the current check. Its own title, `[improvement](github-actions) Reduce redundant GitHub Actions runs and checkouts`, would not pass the checker it added. **Root cause.** #66957 replaced the `deepakputhraya/action-pr-title` action with an inline `grep -qE` and kept the action's regex verbatim, with the comment "Same regex as the previously used ... submodule". But that action is **JavaScript**, where `\-` inside a character class is a valid escape for a literal hyphen. **POSIX ERE has no such escape** — a backslash inside a bracket expression is just a backslash. So ``` [a-zA-Z0-9 \-_] ``` does not mean "letters, digits, space, hyphen, underscore". It makes `\` a member and then reads `-_` as a range endpoint, which leaves the hyphen itself out of the set. Porting the pattern from JS to `grep` silently changed its meaning. The fix puts the literal hyphen last in the bracket expression, which is how POSIX spells it: ```diff -if ! grep -qE '\[([a-zA-Z0-9 \-_])+\]\(([a-zA-Z0-9 \-_])+\)(.*)' <<< "${TITLE}"; then +if ! grep -qE '\[([a-zA-Z0-9 _-])+\]\(([a-zA-Z0-9 _-])+\)(.*)' <<< "${TITLE}"; then ``` A comment now records why the JS form cannot be restored verbatim, so the pattern is not "fixed back" later. #### 2. `.gitignore` ignores `.github` `.gitignore` has had a bare `.github` entry under its `# other` section since 9b5a464 (`[Feature][external catalog/lakesoul] support lakesoul catalog`, #32164) — a change that otherwise has nothing to do with CI and touched only those two `.gitignore` lines, so it looks accidental. The existing files under `.github` survived only because they were already tracked when the entry was added; `.gitignore` does not affect tracked files. The entry therefore has no useful effect today, and two harmful ones: * Any **new** file under `.github` — a workflow, an action, `CODEOWNERS`, an issue template — is silently ignored. `git status` does not list it and `git add` refuses it without `-f`, so it is easy to open a PR that is missing it. * Even for a **tracked** file, `git add .github/workflows/foo.yml` prints `The following paths are ignored by one of your .gitignore files` and exits non-zero, which breaks `git add ... && git commit ...` in scripts. This happened while preparing this very PR. ``` $ git check-ignore -v --no-index .github/workflows/new-thing.yml .gitignore:155:.github .github/workflows/new-thing.yml ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close#32163
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...