Uh oh!
There was an error while loading. Please reload this page.
[fix](function)revert function REPEAT nullable mode - #32226
Conversation
doris-robot
commented
Mar 14, 2024
Thank you for your contribution to Apache Doris. |
koarz
commented
Mar 14, 2024
run buildall |
morrySnow
commented
Mar 14, 2024
please add some description to explain why need revert |
clang-tidy review says "All clean, LGTM! 👍" |
koarz
commented
Mar 14, 2024
Description has been added |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
doris-robot
commented
Mar 14, 2024
TPC-H: Total hot run time: 38039 ms |
doris-robot
commented
Mar 14, 2024
TeamCity be ut coverage result: |
yiguolei
left a comment
There was a problem hiding this comment.
Add a regression-test for > max repeat num, to make sure the behavior is stable.
in PR #32219, will report error if greater than max repeat num. |
zclllyybb
commented
Mar 14, 2024
added in https://github.com/apache/doris/pull/32219/files. we merge both two prs |
zclllyybb
commented
Mar 15, 2024
run buildall |
doris-robot
commented
Mar 15, 2024
TeamCity be ut coverage result: |
doris-robot
commented
Mar 15, 2024
TPC-H: Total hot run time: 38352 ms |
Proposed changes
Issue Number: close #xxx
Previously, due to a mistake on my part, I changed the behaviour of the repeat function, but I didn't realise the problem
You can see that in the case of repeat * size > DEFAULT_MAX_STRING_SIZE we need to output null, but due to an oversight on my part I had defaulted to repeat being less than or equal to repeat_max_num, so I removed this judgement resulting in a change in behaviour
So we need the revert function
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...