Skip to content

[enhance](S3) Print the oss request id for each error s3 request - #32499

Merged
dataroaring merged 1 commit into
apache:masterfrom
ByteYue:print_request_id_for_oss_request
Mar 20, 2024
Merged

[enhance](S3) Print the oss request id for each error s3 request#32499
dataroaring merged 1 commit into
apache:masterfrom
ByteYue:print_request_id_for_oss_request

Conversation

@ByteYue

@ByteYueByteYue commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Sometimes users may need to use the request ID to consult the cloud service provider about a specific S3 operation's request logs, so it is necessary to provide the request ID.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented Mar 19, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@ByteYue

ByteYue commented Mar 19, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Mar 19, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 19, 2024
@github-actions

github-actionsBot commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Mar 19, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.32% (8728/24714)
Line Coverage: 27.13% (71405/263212)
Region Coverage: 26.38% (37054/140455)
Branch Coverage: 23.28% (18945/81386)
Coverage Report: http://coverage.selectdb-in.cc/coverage/61151d6db9a7d36b3c911ad5a66b2ce5f65782f0_61151d6db9a7d36b3c911ad5a66b2ce5f65782f0/report/index.html

@ByteYue
ByteYueforce-pushed the print_request_id_for_oss_request branch from 61151d6 to 45d4ddeCompareMarch 20, 2024 02:31
@ByteYue

ByteYue commented Mar 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Mar 20, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.30% (8725/24715)
Line Coverage: 27.10% (71359/263300)
Region Coverage: 26.35% (37028/140538)
Branch Coverage: 23.25% (18933/81418)
Coverage Report: http://coverage.selectdb-in.cc/coverage/45d4dde27d469be45b4d9f602c5341868e04c60b_45d4dde27d469be45b4d9f602c5341868e04c60b/report/index.html

@ByteYue
ByteYueforce-pushed the print_request_id_for_oss_request branch from 45d4dde to ca0c524CompareMarch 20, 2024 13:37
@ByteYue

ByteYue commented Mar 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Mar 20, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.27% (8727/24745)
Line Coverage: 27.08% (71422/263751)
Region Coverage: 26.32% (37067/140814)
Branch Coverage: 23.24% (18959/81586)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ca0c524b368ca9398ddee542fc94137a31225f9d_ca0c524b368ca9398ddee542fc94137a31225f9d/report/index.html

@dataroaring
dataroaring merged commit 3eb2eba into apache:masterMar 20, 2024
yiguolei pushed a commit that referenced this pull request Mar 21, 2024
@ByteYue@Doris-Extras
[enhance](S3) Print the oss request id for each error s3 request (#32499
b3ec598
)
yiguolei pushed a commit that referenced this pull request Mar 21, 2024
@ByteYue@Doris-Extras
[enhance](S3) Print the oss request id for each error s3 request (#32499
02430e6
)
@ByteYueByteYue mentioned this pull request Mar 21, 2024
Merged
dataroaring pushed a commit that referenced this pull request Mar 21, 2024
@ByteYue
Pick "[enhance](S3) Print the oss request id for each error s3 request…
d77b8ce
…#32499" (#32607)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@ByteYueweixingyu12
Pick "[enhance](S3) Print the oss request id for each error s3 request…
975575a
…apache#32499" (apache#32607)
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@ByteYue@HappenLee
[enhance](S3) Print the oss request id for each error s3 request (apa…
a05c73c
…che#32499)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yukang-LianYukang-LianYukang-Lian approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.7-mergedp0_breviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ByteYue@doris-robot@Yukang-Lian@dataroaring@xiaokang