Skip to content

[opt](information_schema) Add DEFAULT_ENCRYPTION column to schemata table - #32501

Merged
zy-kkk merged 1 commit into
apache:masterfrom
zy-kkk:mysql_1
Mar 21, 2024
Merged

[opt](information_schema) Add DEFAULT_ENCRYPTION column to schemata table#32501
zy-kkk merged 1 commit into
apache:masterfrom
zy-kkk:mysql_1

Conversation

@zy-kkk

@zy-kkkzy-kkk commented Mar 19, 2024

Copy link
Copy Markdown
Member

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented Mar 19, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions

github-actionsBot commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zy-kkk

zy-kkk commented Mar 19, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

doris-robot commented Mar 19, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.31% (8727/24713)
Line Coverage: 27.12% (71395/263208)
Region Coverage: 26.38% (37048/140457)
Branch Coverage: 23.28% (18944/81386)
Coverage Report: http://coverage.selectdb-in.cc/coverage/440c1a4d7311ef7f7dab0b926cf3473776b4cfce_440c1a4d7311ef7f7dab0b926cf3473776b4cfce/report/index.html

@zy-kkk

zy-kkk commented Mar 20, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

doris-robot commented Mar 20, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.30% (8730/24730)
Line Coverage: 27.09% (71404/263536)
Region Coverage: 26.33% (37055/140709)
Branch Coverage: 23.24% (18944/81514)
Coverage Report: http://coverage.selectdb-in.cc/coverage/440c1a4d7311ef7f7dab0b926cf3473776b4cfce_440c1a4d7311ef7f7dab0b926cf3473776b4cfce/report/index.html

morningman
morningman approved these changes Mar 20, 2024
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman

morningman commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

Please add test cases in next PR

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2024
@github-actions

github-actionsBot commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zy-kkk

zy-kkk commented Mar 21, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

doris-robot commented Mar 21, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.26% (8728/24750)
Line Coverage: 27.08% (71442/263854)
Region Coverage: 26.32% (37078/140871)
Branch Coverage: 23.23% (18962/81616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/440c1a4d7311ef7f7dab0b926cf3473776b4cfce_440c1a4d7311ef7f7dab0b926cf3473776b4cfce/report/index.html

@zy-kkk
zy-kkk merged commit cc21052 into apache:masterMar 21, 2024
@zy-kkk
zy-kkk deleted the mysql_1 branch March 21, 2024 06:47
zy-kkk added a commit to zy-kkk/doris that referenced this pull request Mar 21, 2024
@zy-kkk
[opt](information_schema) Add DEFAULT_ENCRYPTION column to schemata t…
eabde8d
…able (apache#32501)
@zy-kkkzy-kkk mentioned this pull request Mar 21, 2024
Merged
xiaokang pushed a commit that referenced this pull request Mar 21, 2024
@zy-kkk
[opt](information_schema) Add DEFAULT_ENCRYPTION column to schemata t…
de7e73b
…able (#32501) (#32624)
yiguolei pushed a commit that referenced this pull request Mar 22, 2024
@zy-kkk@Doris-Extras
[opt](information_schema) Add DEFAULT_ENCRYPTION column to schemata t…
fd0bc72
…able (#32501)
seawinde pushed a commit to seawinde/doris that referenced this pull request Mar 22, 2024
@zy-kkk@seawinde
[opt](information_schema) Add DEFAULT_ENCRYPTION column to schemata t…
e271522
…able (apache#32501)
@xiaokangxiaokang mentioned this pull request Mar 22, 2024
Closed
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zy-kkkweixingyu12
[opt](information_schema) Add DEFAULT_ENCRYPTION column to schemata t…
700c0e1
…able (apache#32501) (apache#32624)
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zy-kkk@HappenLee
[opt](information_schema) Add DEFAULT_ENCRYPTION column to schemata t…
34520c6
…able (apache#32501)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hf200012hf200012hf200012 approved these changes
@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.7-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zy-kkk@doris-robot@morningman@hf200012@xiaokang