Skip to content

[fix](inverted index) skip read index column data only for DUP and MOW table - #32594

Merged
zhannngchen merged 2 commits into
apache:masterfrom
xiaokang:fix_mor_index_read_data
Mar 21, 2024
Merged

[fix](inverted index) skip read index column data only for DUP and MOW table#32594
zhannngchen merged 2 commits into
apache:masterfrom
xiaokang:fix_mor_index_read_data

Conversation

@xiaokang

@xiaokangxiaokang commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Skip read index column data for MOR may cause wrong result, so only do it for DUP and MOW table.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented Mar 21, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xiaokang

xiaokang commented Mar 21, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@xiaokangxiaokang added usercase Important user case type label p0_w dev/2.0.x labels Mar 21, 2024
@xiaokang

xiaokang commented Mar 21, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

airborne12
airborne12 approved these changes Mar 21, 2024
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Mar 21, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.27% (8729/24751)
Line Coverage: 27.09% (71480/263897)
Region Coverage: 26.32% (37077/140879)
Branch Coverage: 23.23% (18962/81624)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2bb9807ecdeb6f6b7d599267434c2194fd6503f5_2bb9807ecdeb6f6b7d599267434c2194fd6503f5/report/index.html

@xiaokangxiaokang mentioned this pull request Mar 21, 2024
Merged
zhannngchen
zhannngchen approved these changes Mar 21, 2024
View reviewed changes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 21, 2024
@github-actions

github-actionsBot commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@zhannngchen
zhannngchen merged commit 5551996 into apache:masterMar 21, 2024
zhannngchen pushed a commit that referenced this pull request Mar 21, 2024
@xiaokang
[fix](inverted index) skip read index column data only for DUP and MO…
f2ad149
…W table #32594 (#32600)
yiguolei pushed a commit that referenced this pull request Mar 22, 2024
@xiaokang@Doris-Extras
[fix](inverted index) skip read index column data only for DUP and MO…
55b7f7f
…W table (#32594)
seawinde pushed a commit to seawinde/doris that referenced this pull request Mar 22, 2024
@xiaokang@seawinde
[fix](inverted index) skip read index column data only for DUP and MO…
dfa2faa
…W table (apache#32594)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@xiaokangweixingyu12
[fix](inverted index) skip read index column data only for DUP and MO…
bcacdce
…W table apache#32594 (apache#32600)
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@xiaokang@HappenLee
[fix](inverted index) skip read index column data only for DUP and MO…
599bea7
…W table (apache#32594)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12airborne12airborne12 approved these changes
@zhannngchenzhannngchenzhannngchen approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.7-mergedp0_wreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiaokang@doris-robot@airborne12@zhannngchen