Uh oh!
There was an error while loading. Please reload this page.
[Improvement](agg) Improve count distinct distribute keys - #33167
Conversation
doris-robot
commented
Apr 2, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
| #pragma once | ||
| #include <stddef.h> |
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers]
| #include<stddef.h> | |
| #include<cstddef> |
| #include <stddef.h> | ||
| #include <algorithm> | ||
| #include <boost/iterator/iterator_facade.hpp> |
There was a problem hiding this comment.
warning: 'boost/iterator/iterator_facade.hpp' file not found [clang-diagnostic-error]
#include<boost/iterator/iterator_facade.hpp>
^| namespace doris { | ||
| namespace vectorized { |
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
| namespacedoris { | |
| namespacevectorized { | |
| namespacedoris::vectorized { |
be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h:48:
- } // namespace vectorized- } // namespace doris+ } // namespace doris| auto data = reinterpret_cast<const UInt64*>( | ||
| assert_cast<const ColumnFixedLengthObject&>(column).get_data().data()); | ||
| for (size_t i = 0; i != num_rows; ++i) { | ||
| auto rhs_place = places + sizeof(Data) * i; |
There was a problem hiding this comment.
warning: 'auto rhs_place' can be declared as 'auto *rhs_place' [readability-qualified-auto]
| auto rhs_place=places+sizeof(Data) *i; | |
| auto *rhs_place=places+sizeof(Data) *i; |
Gabriel39
commented
Apr 23, 2024
run buildall |
Gabriel39
commented
Apr 23, 2024
run buildall |
doris-robot
commented
Apr 23, 2024
TeamCity be ut coverage result: |
doris-robot
commented
Apr 23, 2024
ClickBench: Total hot run time: 31.27 s |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
Gabriel39
commented
Apr 26, 2024
run buildall |
| #pragma once | ||
| #include <stddef.h> |
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers]
| #include<stddef.h> | |
| #include<cstddef> |
| #include <stddef.h> | ||
| #include <algorithm> | ||
| #include <boost/iterator/iterator_facade.hpp> |
There was a problem hiding this comment.
warning: 'boost/iterator/iterator_facade.hpp' file not found [clang-diagnostic-error]
#include<boost/iterator/iterator_facade.hpp>
^| namespace doris { | ||
| namespace vectorized { |
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
| namespacedoris { | |
| namespacevectorized { | |
| namespacedoris::vectorized { |
be/src/vec/aggregate_functions/aggregate_function_uniq_distribute_key.h:48:
- } // namespace vectorized- } // namespace doris+ } // namespace doris| auto data = reinterpret_cast<const UInt64*>( | ||
| assert_cast<const ColumnFixedLengthObject&>(column).get_data().data()); | ||
| for (size_t i = 0; i != num_rows; ++i) { | ||
| auto rhs_place = places + sizeof(Data) * i; |
There was a problem hiding this comment.
warning: 'auto rhs_place' can be declared as 'auto *rhs_place' [readability-qualified-auto]
| auto rhs_place=places+sizeof(Data) *i; | |
| auto *rhs_place=places+sizeof(Data) *i; |
PR approved by at least one committer and no changes requested. |
doris-robot
commented
Apr 26, 2024
TeamCity be ut coverage result: |
doris-robot
commented
Apr 26, 2024
TPC-H: Total hot run time: 40813 ms |
doris-robot
commented
Apr 26, 2024
TPC-DS: Total hot run time: 186747 ms |
Proposed changes
Implement another count distinct function.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...