Uh oh!
There was an error while loading. Please reload this page.
[Bug](array) fix array column core dump in get_shrinked_column as not check type - #33295
Merged
Conversation
doris-robot
commented
Apr 7, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zhangstar333
commented
Apr 7, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
Uh oh!
There was an error while loading. Please reload this page.
yiguolei
reviewed
Apr 7, 2024
Uh oh!
There was an error while loading. Please reload this page.
zhangstar333
commented
Apr 7, 2024
ContributorAuthor
run buildall |
| MutableColumnPtr get_shrinked_column() override; | ||
| bool could_shrinked_column() override; | ||
| bool is_variable_length() const override { return nested_column->is_variable_length(); } | ||
Contributor
There was a problem hiding this comment.
warning: method 'get_family_name' can be made static [readability-convert-member-functions-to-static]
Suggested change
| staticconstchar*get_family_name() override { return"Nullable"; } |
| MutableColumnPtr clone_resized(size_t to_size) const override; | ||
| MutableColumnPtr get_shrinked_column() override; | ||
| bool could_shrinked_column() override { return true; } |
Contributor
There was a problem hiding this comment.
warning: method 'could_shrinked_column' can be made static [readability-convert-member-functions-to-static]
Suggested change
| boolcould_shrinked_column() override { return true; } | |
| staticboolcould_shrinked_column() override { return true; } |
| return ColumnStruct::create(new_columns); | ||
| } | ||
| bool ColumnStruct::could_shrinked_column() { |
Contributor
There was a problem hiding this comment.
warning: method 'could_shrinked_column' can be made static [readability-convert-member-functions-to-static]
be/src/vec/columns/column_struct.h:158:
- bool could_shrinked_column() override;+ static bool could_shrinked_column() override;Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
doris-robot
commented
Apr 7, 2024
TPC-H: Total hot run time: 38915 ms |
doris-robot
commented
Apr 7, 2024
TeamCity be ut coverage result: |
doris-robot
commented
Apr 7, 2024
TPC-DS: Total hot run time: 180883 ms |
doris-robot
commented
Apr 7, 2024
ClickBench: Total hot run time: 30.3 s |
doris-robot
commented
Apr 7, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
yiguolei pushed a commit
that referenced
this pull request
Apr 7, 2024
… check type (#33295) * [Bug](array) fix array column core dump in get_shrinked_column as not check type * add function could_shrinked_column
Closed
seawinde pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 10, 2024
… check type (apache#33295) * [Bug](array) fix array column core dump in get_shrinked_column as not check type * add function could_shrinked_column
zhangstar333 added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Apr 11, 2024
… check type (apache#33295) * [Bug](array) fix array column core dump in get_shrinked_column as not check type * add function could_shrinked_column
mongo360 pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
… check type (apache#33295) (apache#33552) * [Bug](array) fix array column core dump in get_shrinked_column as not check type * add function could_shrinked_column
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
… check type (apache#33295) * [Bug](array) fix array column core dump in get_shrinked_column as not check type * add function could_shrinked_column
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_shrinked_column() function should only call by string type.
so should check column type.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...