[Improment](executor)Add workload group id in workload policy's property by wangbo · Pull Request #33483 · apache/doris

wangbo · 2024-04-10T08:33:52Z

Proposed changes

I think the similar workload should be within the same workload group, so a workload group may has many workload policy, but a workload policy should be only binded in one workload group.
I add a workload_group_id property for workload schedule, then a policy with a valid workload group id can only match the workload in its own group.
The default value of workload_group_id is -1 ,it means all queries in the cluster may be limited by the policy.

Drop workload group check

If a workload group has a related policy, it can not be dropped.

mysql [hits]>show workload schedule policy;
+-------+----------------------+-------------------+--------------+----------+---------+---------+---------------+
| Id | Name | Condition | Action | Priority | Enabled | Version | WorkloadGroup |
+-------+----------------------+-------------------+--------------+----------+---------+---------+---------------+
| 47039 | test_cancel_3s_query | query_time > 3000 | cancel_query | 0 | true | 4 | test_group |
+-------+----------------------+-------------------+--------------+----------+---------+---------+---------------+
1 row in set (0.00 sec)
mysql [hits]>drop workload group test_group;
ERROR 1105 (HY000): errCode = 2, detailMessage = workload group test_group can't be dropped, because it has related policy

you need drop policy first or clear policy's workload group property.

mysql [hits]>alter workload schedule policy test_cancel_3s_query properties('workload_group'='');
Query OK, 0 rows affected (0.01 sec)
mysql [hits]>drop workload group test_group;
Query OK, 0 rows affected (0.00 sec)

mysql [hits]>show workload schedule policy;
+-------+----------------------+-------------------+--------------+----------+---------+---------+---------------+
| Id | Name | Condition | Action | Priority | Enabled | Version | WorkloadGroup |
+-------+----------------------+-------------------+--------------+----------+---------+---------+---------------+
| 47039 | test_cancel_3s_query | query_time > 3000 | cancel_query | 0 | true | 5 | |
+-------+----------------------+-------------------+--------------+----------+---------+---------+---------------+
1 row in set (0.00 sec)

doris-robot · 2024-04-10T08:34:00Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions · 2024-04-10T08:40:27Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-11T06:42:07Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-11T07:00:40Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-11T11:14:09Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-11T11:24:15Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-11T11:34:01Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-12T04:08:20Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-12T04:17:57Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-12T04:28:29Z

clang-tidy review says "All clean, LGTM! 👍"

wangbo · 2024-04-12T06:17:31Z

run buildall

doris-robot · 2024-04-12T07:48:26Z

TeamCity be ut coverage result:
Function Coverage: 35.60% (8904/25012)
Line Coverage: 27.32% (73115/267650)
Region Coverage: 26.44% (37809/142986)
Branch Coverage: 23.20% (19268/83064)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b40bb8acda054f69dea8d160972021aae999018a_b40bb8acda054f69dea8d160972021aae999018a/report/index.html

yiguolei · 2024-04-13T04:19:14Z

+ return false;
+ }
+
 public class PolicyProcNode {


这个proc 功能，我们如果有了系统表，感觉可以不要了，直接删了吧。我们不维护了。

等加上policy的schema table时就删

yiguolei · 2024-04-13T04:20:28Z

 private volatile int priority;

+ @SerializedName(value = "wgId")
+ private long workloadGroupId;


what is the default value when upgrade from old version.

yiguolei · 2024-04-13T04:57:27Z

 new Column("Priority", ScalarType.createType(PrimitiveType.INT)),
 new Column("Enabled", ScalarType.createType(PrimitiveType.BOOLEAN)),
- new Column("Version", ScalarType.createType(PrimitiveType.INT)));
+ new Column("Version", ScalarType.createType(PrimitiveType.INT)),


需要修改对应的regression test。
新建policy的时候指定group name， group 不存在异常的处理。
修改已经存在的policy，指定group name。
drop 已经存在的group，关联policy和不关联policy。

github-actions · 2024-04-15T03:38:49Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-15T04:04:20Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-15T04:14:22Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-15T04:19:31Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-15T04:21:48Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-15T04:24:13Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-04-15T04:24:59Z

clang-tidy review says "All clean, LGTM! 👍"

wangbo · 2024-04-16T04:54:16Z

run p0

wangbo · 2024-04-16T06:11:33Z

run buildall

doris-robot · 2024-04-16T07:07:28Z

TPC-H: Total hot run time: 38844 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1e037e0112f44a40fd2f5ce513f62bea92ccd7af, data reload: false
------ Round 1 ----------------------------------
q1	17608	4509	4300	4300
q2	2027	192	188	188
q3	10427	1246	1203	1203
q4	10182	816	825	816
q5	7494	2739	2695	2695
q6	216	133	134	133
q7	1007	592	589	589
q8	9212	2087	2088	2087
q9	7455	6666	6575	6575
q10	8550	3507	3559	3507
q11	444	227	231	227
q12	433	224	212	212
q13	17964	2920	2931	2920
q14	275	236	226	226
q15	518	484	483	483
q16	550	379	380	379
q17	973	636	708	636
q18	7305	6799	6680	6680
q19	6346	1529	1551	1529
q20	1053	319	297	297
q21	3503	2886	2862	2862
q22	361	300	301	300
Total cold run time: 113903 ms
Total hot run time: 38844 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4387	4252	4272	4252
q2	514	270	266	266
q3	2988	2713	2761	2713
q4	1881	1614	1588	1588
q5	5295	5328	5316	5316
q6	208	126	127	126
q7	2218	1905	1872	1872
q8	3209	3439	3403	3403
q9	8615	8631	8758	8631
q10	4115	3877	3996	3877
q11	620	508	485	485
q12	818	648	631	631
q13	15847	3352	3182	3182
q14	326	308	310	308
q15	546	491	476	476
q16	494	448	442	442
q17	1885	1553	1508	1508
q18	8107	7955	7909	7909
q19	1689	1595	1633	1595
q20	2101	1882	1820	1820
q21	10316	5041	5017	5017
q22	562	470	475	470
Total cold run time: 76741 ms
Total hot run time: 55887 ms

doris-robot · 2024-04-16T07:19:03Z

TPC-DS: Total hot run time: 184404 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1e037e0112f44a40fd2f5ce513f62bea92ccd7af, data reload: false
query1	900	377	364	364
query2	6200	2684	2423	2423
query3	6658	202	203	202
query4	24170	21252	21381	21252
query5	4132	425	408	408
query6	265	201	169	169
query7	4606	298	287	287
query8	229	171	178	171
query9	8615	2315	2298	2298
query10	423	243	257	243
query11	14732	14199	14236	14199
query12	131	96	87	87
query13	1631	372	369	369
query14	8973	7178	7579	7178
query15	226	180	179	179
query16	7841	261	268	261
query17	1917	570	559	559
query18	1950	274	265	265
query19	194	154	149	149
query20	91	87	82	82
query21	198	127	129	127
query22	5097	4898	4837	4837
query23	33861	33409	33141	33141
query24	10988	3056	3092	3056
query25	651	385	389	385
query26	1293	156	154	154
query27	2520	371	379	371
query28	6554	2110	2116	2110
query29	877	636	613	613
query30	274	181	177	177
query31	1009	765	754	754
query32	99	56	50	50
query33	771	262	250	250
query34	1271	497	496	496
query35	833	720	734	720
query36	1063	953	932	932
query37	113	84	73	73
query38	3458	3350	3331	3331
query39	1618	1577	1593	1577
query40	176	132	125	125
query41	49	42	46	42
query42	107	95	94	94
query43	574	563	576	563
query44	1307	762	760	760
query45	298	265	269	265
query46	1117	794	779	779
query47	2041	1942	1984	1942
query48	387	319	314	314
query49	909	395	407	395
query50	818	409	432	409
query51	6881	6775	6833	6775
query52	110	86	91	86
query53	354	272	284	272
query54	295	228	223	223
query55	74	71	68	68
query56	241	221	229	221
query57	1205	1118	1162	1118
query58	218	195	196	195
query59	3425	3283	3081	3081
query60	256	230	230	230
query61	92	89	89	89
query62	603	441	444	441
query63	308	273	279	273
query64	5026	3969	3786	3786
query65	3068	3023	3062	3023
query66	751	344	325	325
query67	15244	15068	14869	14869
query68	5213	543	543	543
query69	486	295	303	295
query70	1237	1177	1224	1177
query71	428	268	265	265
query72	6240	2634	2505	2505
query73	711	324	320	320
query74	6691	6459	6351	6351
query75	3415	2657	2668	2657
query76	3275	1047	1086	1047
query77	382	260	258	258
query78	10924	10249	10194	10194
query79	7487	531	527	527
query80	1785	445	443	443
query81	512	245	239	239
query82	1021	96	97	96
query83	275	170	167	167
query84	264	83	88	83
query85	1912	262	265	262
query86	482	284	288	284
query87	3533	3275	3303	3275
query88	5094	2451	2443	2443
query89	481	373	368	368
query90	1941	185	184	184
query91	126	94	94	94
query92	56	48	46	46
query93	5698	503	506	503
query94	1075	176	179	176
query95	390	302	300	300
query96	633	264	265	264
query97	3141	2921	2960	2921
query98	230	222	212	212
query99	1204	869	843	843
Total cold run time: 288708 ms
Total hot run time: 184404 ms

doris-robot · 2024-04-16T07:24:35Z

ClickBench: Total hot run time: 29.87 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1e037e0112f44a40fd2f5ce513f62bea92ccd7af, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.06	0.07
query5	0.49	0.48	0.50
query6	1.45	0.76	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.54	0.47	0.50
query10	0.55	0.55	0.55
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.60	0.58	0.58
query14	0.77	0.79	0.77
query15	0.82	0.81	0.80
query16	0.36	0.37	0.34
query17	0.95	0.94	0.99
query18	0.21	0.24	0.24
query19	1.78	1.66	1.70
query20	0.02	0.01	0.01
query21	15.40	0.66	0.66
query22	4.10	8.32	1.68
query23	18.26	1.36	1.20
query24	1.94	0.24	0.19
query25	0.15	0.09	0.08
query26	0.25	0.17	0.17
query27	0.08	0.09	0.07
query28	13.36	1.00	0.97
query29	12.63	3.33	3.27
query30	0.26	0.07	0.06
query31	2.83	0.38	0.38
query32	3.28	0.46	0.46
query33	2.87	2.77	2.82
query34	17.20	4.44	4.39
query35	4.47	4.49	4.45
query36	0.65	0.45	0.48
query37	0.18	0.15	0.16
query38	0.16	0.14	0.14
query39	0.04	0.04	0.04
query40	0.17	0.13	0.14
query41	0.09	0.04	0.04
query42	0.06	0.05	0.05
query43	0.03	0.04	0.04
Total cold run time: 109.4 s
Total hot run time: 29.87 s

doris-robot · 2024-04-16T07:27:43Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 1e037e0112f44a40fd2f5ce513f62bea92ccd7af with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 14.2 seconds inserted 10000000 Rows, about 704K ops/s

doris-robot · 2024-04-16T07:42:35Z

TeamCity be ut coverage result:
Function Coverage: 35.54% (8902/25046)
Line Coverage: 27.27% (73112/268092)
Region Coverage: 26.39% (37803/143258)
Branch Coverage: 23.17% (19263/83142)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1e037e0112f44a40fd2f5ce513f62bea92ccd7af_1e037e0112f44a40fd2f5ce513f62bea92ccd7af/report/index.html

yiguolei · 2024-04-17T02:58:38Z

 private volatile int priority;

+ @SerializedName(value = "wgId")
+ private long workloadGroupId = -1;


store as a list， because user may bind to multi workload groups in the future.

github-actions · 2024-04-17T06:02:32Z

clang-tidy review says "All clean, LGTM! 👍"

wangbo · 2024-04-17T09:31:34Z

run buildall

github-actions · 2024-04-17T09:36:55Z

clang-tidy review says "All clean, LGTM! 👍"

yiguolei

LGTM

github-actions · 2024-04-17T09:41:50Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-04-17T09:41:52Z

PR approved by anyone and no changes requested.

doris-robot · 2024-04-17T10:08:42Z

TPC-H: Total hot run time: 39047 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 37e1ba6e9020f37cc94dc7e7ed2bb6edc3f641ac, data reload: false
------ Round 1 ----------------------------------
q1	18091	4564	4303	4303
q2	2014	192	189	189
q3	11309	1193	1185	1185
q4	10339	785	811	785
q5	7581	2769	2697	2697
q6	233	139	154	139
q7	979	579	554	554
q8	9406	2119	2091	2091
q9	7519	6741	6715	6715
q10	8644	3604	3533	3533
q11	479	241	235	235
q12	486	234	225	225
q13	17772	2982	2984	2982
q14	283	229	237	229
q15	523	486	489	486
q16	527	392	385	385
q17	980	628	659	628
q18	7386	6910	6762	6762
q19	5052	1554	1498	1498
q20	658	328	307	307
q21	3599	2812	2895	2812
q22	371	308	307	307
Total cold run time: 114231 ms
Total hot run time: 39047 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4387	4196	4198	4196
q2	379	270	271	270
q3	2985	2718	2716	2716
q4	1862	1636	1567	1567
q5	5377	5364	5304	5304
q6	215	125	126	125
q7	1785	1426	1427	1426
q8	3225	3398	3383	3383
q9	8617	8574	8594	8574
q10	3913	3717	3661	3661
q11	577	478	478	478
q12	773	586	620	586
q13	16529	2937	2946	2937
q14	310	276	297	276
q15	515	471	482	471
q16	475	423	433	423
q17	1783	1476	1474	1474
q18	7666	7554	7469	7469
q19	1663	1585	1606	1585
q20	1944	1752	1747	1747
q21	5102	4880	4854	4854
q22	552	462	464	462
Total cold run time: 70634 ms
Total hot run time: 53984 ms

doris-robot · 2024-04-17T10:20:18Z

TPC-DS: Total hot run time: 184892 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 37e1ba6e9020f37cc94dc7e7ed2bb6edc3f641ac, data reload: false
query1	899	385	366	366
query2	6992	2485	2364	2364
query3	6665	211	215	211
query4	23086	21472	21362	21362
query5	4176	406	414	406
query6	259	176	168	168
query7	4582	296	283	283
query8	231	188	178	178
query9	8427	2371	2351	2351
query10	579	245	242	242
query11	14812	14172	14126	14126
query12	144	92	87	87
query13	1656	368	371	368
query14	9192	7918	7955	7918
query15	299	190	192	190
query16	8193	269	266	266
query17	1929	601	569	569
query18	2151	272	265	265
query19	332	146	151	146
query20	94	85	86	85
query21	198	127	133	127
query22	5011	4817	4817	4817
query23	33892	33094	33173	33094
query24	10746	2961	2917	2917
query25	615	367	389	367
query26	1373	157	153	153
query27	2902	310	311	310
query28	7526	2023	2007	2007
query29	878	619	587	587
query30	316	170	166	166
query31	1005	714	713	713
query32	88	51	51	51
query33	760	243	238	238
query34	1043	474	479	474
query35	835	692	701	692
query36	1058	930	908	908
query37	143	67	70	67
query38	3325	3230	3175	3175
query39	1718	1528	1530	1528
query40	201	129	129	129
query41	45	41	47	41
query42	103	95	99	95
query43	584	551	559	551
query44	1204	726	725	725
query45	279	264	271	264
query46	1075	733	714	714
query47	1927	1860	1875	1860
query48	364	297	292	292
query49	1031	380	364	364
query50	745	388	386	386
query51	6942	6837	6663	6663
query52	99	90	89	89
query53	348	285	280	280
query54	326	233	226	226
query55	76	69	72	69
query56	243	221	215	215
query57	1212	1138	1107	1107
query58	225	193	194	193
query59	3343	3171	3167	3167
query60	285	231	236	231
query61	88	86	106	86
query62	645	444	430	430
query63	309	278	279	278
query64	5256	3918	3946	3918
query65	3131	3049	3055	3049
query66	1413	379	339	339
query67	15571	15232	14866	14866
query68	5262	530	531	530
query69	502	306	298	298
query70	1247	1215	1198	1198
query71	1387	1265	1265	1265
query72	6774	2607	2440	2440
query73	700	326	324	324
query74	6876	6362	6327	6327
query75	3416	2617	2603	2603
query76	3388	976	941	941
query77	384	264	260	260
query78	10915	10371	10088	10088
query79	3656	528	507	507
query80	1748	440	432	432
query81	541	251	248	248
query82	712	99	97	97
query83	271	165	166	165
query84	262	90	85	85
query85	1998	262	261	261
query86	523	285	297	285
query87	3487	3272	3256	3256
query88	4842	2411	2424	2411
query89	479	377	372	372
query90	2038	188	187	187
query91	190	95	99	95
query92	57	48	47	47
query93	4671	521	499	499
query94	1241	177	181	177
query95	404	305	301	301
query96	608	267	263	263
query97	3152	2954	2923	2923
query98	241	216	210	210
query99	1232	828	829	828
Total cold run time: 288404 ms
Total hot run time: 184892 ms

doris-robot · 2024-04-17T10:25:50Z

ClickBench: Total hot run time: 30.32 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 37e1ba6e9020f37cc94dc7e7ed2bb6edc3f641ac, data reload: false
query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.08
query5	0.49	0.48	0.48
query6	1.47	0.71	0.72
query7	0.02	0.02	0.02
query8	0.04	0.04	0.05
query9	0.55	0.50	0.48
query10	0.55	0.55	0.54
query11	0.16	0.12	0.12
query12	0.14	0.12	0.12
query13	0.60	0.58	0.58
query14	0.77	0.77	0.79
query15	0.83	0.80	0.80
query16	0.37	0.37	0.37
query17	1.03	0.96	1.03
query18	0.22	0.22	0.26
query19	1.83	1.70	1.70
query20	0.01	0.01	0.01
query21	15.44	0.65	0.65
query22	4.22	7.66	1.96
query23	18.27	1.38	1.23
query24	1.35	0.38	0.22
query25	0.14	0.08	0.08
query26	0.28	0.18	0.17
query27	0.08	0.09	0.07
query28	13.42	1.00	0.98
query29	12.61	3.24	3.23
query30	0.25	0.06	0.06
query31	2.84	0.38	0.38
query32	3.26	0.47	0.47
query33	2.85	2.84	2.91
query34	17.12	4.44	4.42
query35	4.50	4.46	4.43
query36	0.66	0.45	0.46
query37	0.19	0.16	0.15
query38	0.15	0.15	0.14
query39	0.04	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.05	0.04
query42	0.06	0.05	0.04
query43	0.04	0.04	0.03
Total cold run time: 109.13 s
Total hot run time: 30.32 s

doris-robot · 2024-04-17T10:28:54Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 37e1ba6e9020f37cc94dc7e7ed2bb6edc3f641ac with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 13.5 seconds inserted 10000000 Rows, about 740K ops/s

doris-robot · 2024-04-17T10:47:11Z

TeamCity be ut coverage result:
Function Coverage: 35.45% (8908/25127)
Line Coverage: 27.14% (73166/269550)
Region Coverage: 26.28% (37824/143932)
Branch Coverage: 23.08% (19276/83520)
Coverage Report: http://coverage.selectdb-in.cc/coverage/37e1ba6e9020f37cc94dc7e7ed2bb6edc3f641ac_37e1ba6e9020f37cc94dc7e7ed2bb6edc3f641ac/report/index.html

xinyiZzz

LGTM

wangbo added the workload-schedule label Apr 10, 2024

github-actionsBot added the meta-change label Apr 10, 2024

wangbo force-pushed the 0409_policy_test branch from 0bdf163 to b5b3773Compare April 11, 2024 06:36

wangbo force-pushed the 0409_policy_test branch from 5c0befd to e9a4c41Compare April 11, 2024 11:18

wangbo force-pushed the 0409_policy_test branch from 43c3f47 to ff7466dCompare April 12, 2024 04:03

wangbo force-pushed the 0409_policy_test branch from ff7466d to 33dc4c1Compare April 12, 2024 04:12

wangbo force-pushed the 0409_policy_test branch from 33dc4c1 to b40bb8aCompare April 12, 2024 04:22

yiguolei reviewed Apr 13, 2024
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadSchedPolicy.java Outdated

yiguolei reviewed Apr 13, 2024
View reviewed changes

yiguolei reviewed Apr 17, 2024
View reviewed changes

wangbo force-pushed the 0409_policy_test branch from 1e037e0 to d55755cCompare April 17, 2024 05:57

Add workload group id in workload policy's property
37e1ba6

wangbo force-pushed the 0409_policy_test branch from d55755c to 37e1ba6Compare April 17, 2024 09:31

wangbo added the workload-group label Apr 17, 2024

yiguolei approved these changes Apr 17, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 17, 2024

github-actionsBot added the reviewed label Apr 17, 2024

xinyiZzz approved these changes Apr 17, 2024
View reviewed changes

wangbo merged commit a106e45 into apache:masterApr 17, 2024

yiguolei pushed a commit that referenced this pull request Apr 17, 2024
Add workload group id in workload policy's property (#33483)
055624e

yiguolei pushed a commit that referenced this pull request Apr 17, 2024
Add workload group id in workload policy's property (#33483)
20b37e7

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
Add workload group id in workload policy's property (apache#33483)
ef081db

Uh oh!

Conversation

wangbo commented Apr 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Drop workload group check

Uh oh!

doris-robot commented Apr 10, 2024

Uh oh!

github-actionsBot commented Apr 10, 2024

Uh oh!

github-actionsBot commented Apr 11, 2024

Uh oh!

github-actionsBot commented Apr 11, 2024

Uh oh!

github-actionsBot commented Apr 11, 2024

Uh oh!

github-actionsBot commented Apr 11, 2024

Uh oh!

github-actionsBot commented Apr 11, 2024

Uh oh!

github-actionsBot commented Apr 12, 2024

Uh oh!

github-actionsBot commented Apr 12, 2024

Uh oh!

github-actionsBot commented Apr 12, 2024

Uh oh!

wangbo commented Apr 12, 2024

Uh oh!

doris-robot commented Apr 12, 2024

Uh oh!

yiguoleiApr 13, 2024

Choose a reason for hiding this comment

Uh oh!

wangboApr 15, 2024

Choose a reason for hiding this comment

Uh oh!

yiguoleiApr 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yiguoleiApr 13, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 15, 2024

Uh oh!

github-actionsBot commented Apr 15, 2024

Uh oh!

github-actionsBot commented Apr 15, 2024

Uh oh!

github-actionsBot commented Apr 15, 2024

Uh oh!

github-actionsBot commented Apr 15, 2024

Uh oh!

github-actionsBot commented Apr 15, 2024

Uh oh!

github-actionsBot commented Apr 15, 2024

Uh oh!

wangbo commented Apr 16, 2024

Uh oh!

wangbo commented Apr 16, 2024

Uh oh!

doris-robot commented Apr 16, 2024

Uh oh!

doris-robot commented Apr 16, 2024

Uh oh!

doris-robot commented Apr 16, 2024

Uh oh!

doris-robot commented Apr 16, 2024

Uh oh!

doris-robot commented Apr 16, 2024

Uh oh!

yiguoleiApr 17, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 17, 2024

Uh oh!

wangbo commented Apr 17, 2024

Uh oh!

github-actionsBot commented Apr 17, 2024

wangbo commented Apr 10, 2024•
edited
Loading