Skip to content

[fix](schema change) CastStringConverter is compiled failed in g++#33546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
Apr 12, 2024
Merged

[fix](schema change) CastStringConverter is compiled failed in g++ #33546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4fb735
[fix](schema change) CastStringConverter is compiled failed in g++
AshinGau Apr 11, 2024
eb8b7f8
Merge branch 'master' into uni_schange_fix1
AshinGau Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions be/src/vec/exec/format/column_type_convert.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -384,7 +384,7 @@ class CastStringConverter : public ColumnTypeConverter {
to_col->resize(start_idx + rows);
auto& data = static_cast<DstColumnType*>(to_col.get())->get_data();
for (int i = 0; i < rows; ++i) {
DstCppType value;
DstCppType& value = data[start_idx + i];
auto string_value = string_col.get_data_at(i);
bool can_cast = false;
if constexpr (is_decimal_type_const<DstPrimitiveType>()) {
Expand All@@ -398,9 +398,7 @@ class CastStringConverter : public ColumnTypeConverter {
can_cast = SafeCastString<DstPrimitiveType>::safe_cast_string(
string_value.data, string_value.size, &value);
}
if (can_cast) {
data[start_idx + i] = value;
} else {
if (!can_cast) {
if (null_map == nullptr) {
return Status::InternalError("Failed to cast string '{}' to not null column",
string_value.to_string());
Expand Down