Skip to content

[shuffle](minor) Log error status if exchange is shutdown early - #33748

Merged
Gabriel39 merged 1 commit into
apache:masterfrom
Gabriel39:fix_0417
Apr 17, 2024
Merged

[shuffle](minor) Log error status if exchange is shutdown early#33748
Gabriel39 merged 1 commit into
apache:masterfrom
Gabriel39:fix_0417

Conversation

@Gabriel39

@Gabriel39Gabriel39 commented Apr 17, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

If downstream exchange operator is shutdown before initializing exchange sink, we should only log error status instead of returning error status.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented Apr 17, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39

Gabriel39 commented Apr 17, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Apr 17, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.50% (8908/25096)
Line Coverage: 27.22% (73146/268758)
Region Coverage: 26.34% (37817/143570)
Branch Coverage: 23.13% (19271/83328)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d7205a30f3df8efae93b4e55fd1f0255bbbe33e1_d7205a30f3df8efae93b4e55fd1f0255bbbe33e1/report/index.html

@github-actions

github-actionsBot commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 17, 2024
@github-actions

github-actionsBot commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

HappenLee
HappenLee approved these changes Apr 17, 2024
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39
Gabriel39 merged commit bb1bbb2 into apache:masterApr 17, 2024
yiguolei pushed a commit that referenced this pull request Apr 17, 2024
@Gabriel39@Doris-Extras
[shuffle](minor) Log error status if exchange is shutdown early (#33748)
d6a6b37
yiguolei pushed a commit that referenced this pull request Apr 17, 2024
@Gabriel39@Doris-Extras
[shuffle](minor) Log error status if exchange is shutdown early (#33748)
b518b9d
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@Gabriel39@HappenLee
[shuffle](minor) Log error status if exchange is shutdown early (apac…
ddb3b50
…he#33748)
@Gabriel39
Gabriel39 deleted the fix_0417 branch July 30, 2026 06:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDtBiteTheDDDDtBiteTheDDDDt approved these changes
@HappenLeeHappenLeeHappenLee approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Gabriel39@doris-robot@BiteTheDDDDt@HappenLee@morningman@gavinchou@dataroaring