Skip to content

[fix](compile) fix two compile errors on MacOS - #33834

Merged
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:fix_compile_error_on_macos
Apr 18, 2024
Merged

[fix](compile) fix two compile errors on MacOS#33834
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:fix_compile_error_on_macos

Conversation

@morrySnow

@morrySnowmorrySnow commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

  1. MacOS use libhdfs3, so we need call different function.
    this compile error intro by PR [fix](fs) Fix hdfs file writer #33680

  2. size_t is not UInt64 on MacOS.
    this compile error intro by PR [feature](agg) support aggregate function group_array_intersect #33265

@morrySnow
[fix](compile) fix two compile errors on MacOS
8abdd07
1. MacOS use libhdfs3, so we need call different function.
this compile error intro by PR apache#33680
2. size_t is not UInt64 on MacOS
this compile error intro by PR apache#33265
@doris-robot

doris-robot commented Apr 18, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow

morrySnow commented Apr 18, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 18, 2024
@github-actions

github-actionsBot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

github-actionsBot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

HappenLee
HappenLee approved these changes Apr 18, 2024
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot

doris-robot commented Apr 18, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.43% (8913/25157)
Line Coverage: 27.13% (73246/269967)
Region Coverage: 26.26% (37845/144098)
Branch Coverage: 23.07% (19286/83604)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8abdd07eee9456c1763e81c1b1cbdf5f5eccdbd7_8abdd07eee9456c1763e81c1b1cbdf5f5eccdbd7/report/index.html

@morrySnow

morrySnow commented Apr 18, 2024

Copy link
Copy Markdown
ContributorAuthor

run p0

1 similar comment
@morrySnow

morrySnow commented Apr 18, 2024

Copy link
Copy Markdown
ContributorAuthor

run p0

@morrySnow
morrySnow merged commit d7b0616 into apache:masterApr 18, 2024
@morrySnow
morrySnow deleted the fix_compile_error_on_macos branch April 18, 2024 12:42
dataroaring pushed a commit to dataroaring/incubator-doris that referenced this pull request Apr 20, 2024
@morrySnow@dataroaring
[fix](compile) fix two compile errors on MacOS (apache#33834)
5c8c7bb
1. MacOS use libhdfs3, so we need call different function.
this compile error intro by PR apache#33680
2. size_t is not UInt64 on MacOS
this compile error intro by PR apache#33265
@cambyzjucambyzju mentioned this pull request Apr 23, 2024
Merged
cambyzju added a commit that referenced this pull request Apr 25, 2024
@cambyzju
[fix](compile) fix two compile errors on MacOS (#33834) (#34005)
743fb62
yiguolei pushed a commit that referenced this pull request Apr 25, 2024
@Doris-Extras
Revert "[fix](compile) fix two compile errors on MacOS (#33834) (#34005…
47ded2c
…)"
This reverts commit 743fb62.
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Apr 26, 2024
@cambyzju
[fix](compile) fix two compile errors on MacOS (apache#33834)
607cfee
1. MacOS use libhdfs3, so we need call different function.
this compile error intro by PR apache#33680
2. size_t is not UInt64 on MacOS
this compile error intro by PR apache#33265
@cambyzjucambyzju mentioned this pull request Apr 26, 2024
Merged
cambyzju added a commit that referenced this pull request Apr 26, 2024
@cambyzju
[fix](compile) fix two compile errors on MacOS (#33834) (#34149)
10e0988
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@morrySnow@HappenLee
[fix](compile) fix two compile errors on MacOS (apache#33834)
ef1c028
1. MacOS use libhdfs3, so we need call different function.
this compile error intro by PR apache#33680
2. size_t is not UInt64 on MacOS
this compile error intro by PR apache#33265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@924060929924060929924060929 approved these changes
@HappenLeeHappenLeeHappenLee approved these changes
@platonekoplatonekoplatoneko approved these changes
@morningmanmorningmanAwaiting requested review from morningmanmorningman is a code owner

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@morrySnow@doris-robot@924060929@HappenLee@platoneko@cambyzju@dataroaring