Skip to content

[fix](memory) temporarily close Allocator address sanitizers - #33862

Merged
yiguolei merged 1 commit into
apache:masterfrom
xinyiZzz:20240417_fix_tracker_asan_temp
Apr 18, 2024
Merged

[fix](memory) temporarily close Allocator address sanitizers#33862
yiguolei merged 1 commit into
apache:masterfrom
xinyiZzz:20240417_fix_tracker_asan_temp

Conversation

@xinyiZzz

@xinyiZzzxinyiZzz commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

temporarily close check query memory tracker equal to 0 , fix#33396, requires more testing.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented Apr 18, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz

xinyiZzz commented Apr 18, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei approved these changes Apr 18, 2024
View reviewed changes

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 18, 2024
@github-actions

github-actionsBot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Apr 18, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit 9606252 into apache:masterApr 18, 2024
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Sep 13, 2024
@xinyiZzz
[fix](memory) temporarily close Allocator address sanitizersapache#3…
dcdc399
…3862
@xinyiZzzxinyiZzz mentioned this pull request Sep 13, 2024
Merged
yiguolei added a commit that referenced this pull request Sep 14, 2024
@xinyiZzz@yiguolei@Doris-Extras
[branch-2.1](memory) Allocator support address sanitizers (#40836)
f16615a
pick
#33396#33862#33853#33732#33841#33933#34901#35014
---------
Co-authored-by: yiguolei <676222867@qq.com>
Co-authored-by: yiguolei <yiguolei@gmail.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@xinyiZzz@HappenLee
[fix](memory) temporarily close Allocator address sanitizersapache#3…
d1eb1ab
…3862
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xinyiZzz@doris-robot@yiguolei@dataroaring