Skip to content

[improve](disk) Not add disk path to broken list if check status is not IO_ERROR - #34111

Merged
dataroaring merged 1 commit into
apache:masterfrom
zxealous:not-add-broken-path
Apr 25, 2024
Merged

[improve](disk) Not add disk path to broken list if check status is not IO_ERROR#34111
dataroaring merged 1 commit into
apache:masterfrom
zxealous:not-add-broken-path

Conversation

@zxealous

@zxealouszxealous commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Not add disk path to broken list if check status is not IO_ERROR

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented Apr 25, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zxealous

zxealous commented Apr 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Apr 25, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.20% (8918/25337)
Line Coverage: 26.97% (73318/271852)
Region Coverage: 26.15% (37881/144880)
Branch Coverage: 22.96% (19284/83978)
Coverage Report: http://coverage.selectdb-in.cc/coverage/57c089143394b4160a4e0ec17f5edd095e330c7d_57c089143394b4160a4e0ec17f5edd095e330c7d/report/index.html

xy720
xy720 approved these changes Apr 25, 2024
View reviewed changes

@xy720xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 25, 2024
@github-actions

github-actionsBot commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Apr 25, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 152c586 into apache:masterApr 25, 2024
zxealous added a commit to zxealous/doris that referenced this pull request Apr 25, 2024
@zxealous
[branch-2.0](cherry-pick) Not add disk path to broken list if check s…
6498eb2
…tatus is not IO_ERROR (apache#34111)
yiguolei pushed a commit that referenced this pull request Apr 25, 2024
@zxealous@Doris-Extras
[improve](disk) Not add disk path to broken list if check status is n…
9aa08d8
…ot IO_ERROR (#34111)
dataroaring pushed a commit that referenced this pull request Apr 26, 2024
@zxealous
[branch-2.0](cherry-pick) Not add disk path to broken list if check s…
0d37447
…tatus is not IO_ERROR (#34111) (#34144)
dataroaring pushed a commit that referenced this pull request Apr 27, 2024
@zxealous@dataroaring
[improve](disk) Not add disk path to broken list if check status is n…
17dadfe
…ot IO_ERROR (#34111)
@zxealous
zxealous deleted the not-add-broken-path branch April 28, 2024 09:29
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zxealousweixingyu12
[branch-2.0](cherry-pick) Not add disk path to broken list if check s…
2530d4d
…tatus is not IO_ERROR (apache#34111) (apache#34144)
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zxealous@HappenLee
[improve](disk) Not add disk path to broken list if check status is n…
b2e0983
…ot IO_ERROR (apache#34111)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xy720xy720xy720 approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.10-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zxealous@doris-robot@xy720@dataroaring