[Fix](auto-partition) fix auto partition load lost data in multi sender by zclllyybb · Pull Request #34740 · apache/doris

zclllyybb · 2024-05-12T18:33:58Z

Proposed changes

Issue Number: close #xxx

Before if we have multi sender but some of their sink node have no data of some specific partition, then this sink won't know it has to close it. So tablets channel won't be closed correctly.
Now change close time needed count to same with open in tablets channel.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

doris-robot · 2024-05-12T18:34:03Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

zclllyybb · 2024-05-12T18:36:38Z

run buildall

github-actions · 2024-05-12T18:40:02Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-12T18:42:31Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-12T20:13:46Z

TeamCity be ut coverage result:
Function Coverage: 35.65% (8987/25211)
Line Coverage: 27.31% (74293/272017)
Region Coverage: 26.54% (38389/144668)
Branch Coverage: 23.35% (19577/83826)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cdcabb351f1a7bdc80b7a73d1ff15ab8992f8c14_cdcabb351f1a7bdc80b7a73d1ff15ab8992f8c14/report/index.html

zclllyybb · 2024-05-12T20:21:09Z

run buildall

github-actions · 2024-05-12T20:26:40Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-12T20:49:57Z

TeamCity be ut coverage result:
Function Coverage: 35.65% (8987/25211)
Line Coverage: 27.31% (74293/272017)
Region Coverage: 26.54% (38392/144668)
Branch Coverage: 23.36% (19580/83826)
Coverage Report: http://coverage.selectdb-in.cc/coverage/21c0f3a7662207bc4d6c9e078c3c15e56b5fa724_21c0f3a7662207bc4d6c9e078c3c15e56b5fa724/report/index.html

doris-robot · 2024-05-12T21:01:05Z

TPC-H: Total hot run time: 40797 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21c0f3a7662207bc4d6c9e078c3c15e56b5fa724, data reload: false
------ Round 1 ----------------------------------
q1	17605	4341	4198	4198
q2	2032	205	193	193
q3	10441	1235	1198	1198
q4	10215	747	923	747
q5	7485	2686	2623	2623
q6	234	127	137	127
q7	1064	600	577	577
q8	9228	2158	2079	2079
q9	9091	6762	6735	6735
q10	9306	3899	3877	3877
q11	460	238	240	238
q12	423	219	232	219
q13	17455	3122	3298	3122
q14	259	221	218	218
q15	511	476	468	468
q16	465	407	401	401
q17	980	741	752	741
q18	8297	7679	7639	7639
q19	7478	1559	1502	1502
q20	625	323	312	312
q21	5210	4238	3309	3309
q22	349	274	286	274
Total cold run time: 119213 ms
Total hot run time: 40797 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4565	4449	4312	4312
q2	379	277	260	260
q3	3125	2920	2870	2870
q4	1884	1604	1599	1599
q5	5475	5482	5490	5482
q6	210	121	125	121
q7	2296	1987	1951	1951
q8	3231	3365	3363	3363
q9	8684	8675	8724	8675
q10	3912	3810	3828	3810
q11	577	505	506	505
q12	786	619	622	619
q13	17048	3144	3171	3144
q14	294	273	300	273
q15	516	465	468	465
q16	458	404	422	404
q17	1739	1473	1470	1470
q18	7673	7577	7305	7305
q19	1641	1495	1552	1495
q20	1960	1764	1768	1764
q21	8768	4841	4791	4791
q22	560	489	480	480
Total cold run time: 75781 ms
Total hot run time: 55158 ms

doris-robot · 2024-05-12T21:12:27Z

TPC-DS: Total hot run time: 186958 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21c0f3a7662207bc4d6c9e078c3c15e56b5fa724, data reload: false
query1	898	369	361	361
query2	6435	2316	2237	2237
query3	6637	204	211	204
query4	25153	21190	21261	21190
query5	4124	411	412	411
query6	261	171	167	167
query7	4585	288	288	288
query8	240	178	189	178
query9	8697	2448	2429	2429
query10	435	245	250	245
query11	14711	14238	14143	14143
query12	139	95	84	84
query13	1642	366	366	366
query14	9652	8593	8347	8347
query15	219	165	178	165
query16	7815	259	261	259
query17	1725	546	544	544
query18	2000	267	259	259
query19	186	146	143	143
query20	93	87	85	85
query21	195	129	127	127
query22	5036	4827	4888	4827
query23	34246	33455	33456	33455
query24	6691	2876	2908	2876
query25	527	360	382	360
query26	701	152	155	152
query27	2008	317	321	317
query28	3750	2065	2051	2051
query29	867	602	595	595
query30	233	178	152	152
query31	972	780	740	740
query32	86	51	54	51
query33	491	246	245	245
query34	868	487	486	486
query35	775	703	693	693
query36	1081	922	936	922
query37	106	66	70	66
query38	2864	2749	2762	2749
query39	1591	1548	1562	1548
query40	204	125	124	124
query41	42	39	38	38
query42	99	96	92	92
query43	556	543	524	524
query44	1084	720	735	720
query45	274	261	258	258
query46	1077	692	695	692
query47	1915	1910	1871	1871
query48	372	296	295	295
query49	771	391	395	391
query50	765	387	374	374
query51	6806	6742	6847	6742
query52	112	91	92	91
query53	357	282	280	280
query54	525	439	427	427
query55	73	74	74	74
query56	241	228	215	215
query57	1228	1156	1137	1137
query58	209	194	196	194
query59	3456	3047	3078	3047
query60	256	233	261	233
query61	93	85	88	85
query62	612	475	477	475
query63	309	281	285	281
query64	8347	7337	7449	7337
query65	3138	3084	3114	3084
query66	782	342	345	342
query67	15052	15122	14780	14780
query68	4488	531	539	531
query69	470	303	301	301
query70	1192	1057	1145	1057
query71	391	272	269	269
query72	7409	2574	2322	2322
query73	700	324	322	322
query74	6541	6032	5975	5975
query75	3283	2637	2597	2597
query76	2227	1016	1001	1001
query77	379	268	258	258
query78	10595	10008	10124	10008
query79	2398	507	504	504
query80	893	427	444	427
query81	503	224	224	224
query82	733	91	92	91
query83	234	157	159	157
query84	244	90	85	85
query85	1195	270	259	259
query86	464	292	308	292
query87	3263	3076	3057	3057
query88	4204	2450	2441	2441
query89	477	378	378	378
query90	2086	197	191	191
query91	122	101	96	96
query92	57	50	48	48
query93	1932	509	495	495
query94	1103	180	174	174
query95	398	302	303	302
query96	593	276	271	271
query97	3200	2981	2980	2980
query98	264	230	220	220
query99	1226	907	905	905
Total cold run time: 270754 ms
Total hot run time: 186958 ms

github-actions · 2024-05-13T11:32:16Z

clang-tidy review says "All clean, LGTM! 👍"

zclllyybb · 2024-05-13T18:17:56Z

run buildall

github-actions · 2024-05-13T19:28:22Z

clang-tidy review says "All clean, LGTM! 👍"

zclllyybb · 2024-05-13T19:45:52Z

run buildall

github-actions · 2024-05-13T19:52:03Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-13T20:15:16Z

TeamCity be ut coverage result:
Function Coverage: 35.66% (8989/25206)
Line Coverage: 27.31% (74307/272044)
Region Coverage: 26.54% (38391/144665)
Branch Coverage: 23.36% (19583/83826)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8e9edc0a3b474659744f6532b19c1bdd2008c3ac_8e9edc0a3b474659744f6532b19c1bdd2008c3ac/report/index.html

doris-robot · 2024-05-13T20:23:18Z

TPC-H: Total hot run time: 41730 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8e9edc0a3b474659744f6532b19c1bdd2008c3ac, data reload: false
------ Round 1 ----------------------------------
q1	17606	4264	4217	4217
q2	2010	192	198	192
q3	10456	1239	1236	1236
q4	10195	882	862	862
q5	7491	2710	2666	2666
q6	233	139	136	136
q7	1029	612	620	612
q8	9258	2103	2069	2069
q9	9372	6770	7131	6770
q10	9122	3878	3908	3878
q11	444	234	245	234
q12	448	228	225	225
q13	18347	3248	3068	3068
q14	251	223	240	223
q15	509	471	470	470
q16	524	410	386	386
q17	981	725	700	700
q18	8280	7846	7669	7669
q19	2033	1557	1514	1514
q20	640	313	311	311
q21	5281	4015	4142	4015
q22	355	280	277	277
Total cold run time: 114865 ms
Total hot run time: 41730 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4515	4447	4399	4399
q2	383	274	263	263
q3	3165	2825	2764	2764
q4	1921	1652	1679	1652
q5	5433	5452	5443	5443
q6	219	122	124	122
q7	2343	1996	1979	1979
q8	3207	3407	3408	3407
q9	8639	8611	8480	8480
q10	4022	3874	3829	3829
q11	592	501	503	501
q12	789	628	623	623
q13	16118	3169	2949	2949
q14	287	249	268	249
q15	514	460	467	460
q16	497	433	421	421
q17	1785	1504	1472	1472
q18	7693	7573	7374	7374
q19	1635	1545	1532	1532
q20	1927	1760	1732	1732
q21	5004	4816	4711	4711
q22	556	476	478	476
Total cold run time: 71244 ms
Total hot run time: 54838 ms

doris-robot · 2024-05-13T20:34:36Z

TPC-DS: Total hot run time: 187323 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8e9edc0a3b474659744f6532b19c1bdd2008c3ac, data reload: false
query1	897	366	348	348
query2	6447	2439	2355	2355
query3	6625	211	208	208
query4	22952	21140	21278	21140
query5	4155	415	414	414
query6	261	173	182	173
query7	4586	289	282	282
query8	231	188	181	181
query9	8579	2391	2363	2363
query10	443	254	253	253
query11	14629	14252	14250	14250
query12	141	91	89	89
query13	1641	372	377	372
query14	9767	7960	7819	7819
query15	211	176	174	174
query16	7249	267	263	263
query17	1299	555	563	555
query18	1913	289	277	277
query19	202	154	155	154
query20	92	85	87	85
query21	199	133	128	128
query22	5082	4809	4872	4809
query23	33969	33610	33565	33565
query24	5110	2863	2892	2863
query25	471	361	367	361
query26	692	154	151	151
query27	1853	320	328	320
query28	3700	2062	2055	2055
query29	817	615	622	615
query30	231	153	152	152
query31	926	759	751	751
query32	59	51	59	51
query33	397	250	241	241
query34	836	478	475	475
query35	761	674	659	659
query36	1040	899	895	895
query37	105	64	64	64
query38	2864	2782	2776	2776
query39	1621	1541	1548	1541
query40	204	127	123	123
query41	44	40	38	38
query42	106	93	98	93
query43	583	516	527	516
query44	1059	711	740	711
query45	258	256	265	256
query46	1070	716	739	716
query47	1972	1876	1893	1876
query48	363	302	293	293
query49	767	418	395	395
query50	755	378	383	378
query51	6903	6714	6718	6714
query52	112	88	91	88
query53	342	281	284	281
query54	529	428	425	425
query55	75	76	75	75
query56	243	224	226	224
query57	1259	1147	1171	1147
query58	216	210	198	198
query59	3320	3179	3099	3099
query60	251	231	232	231
query61	115	85	85	85
query62	568	481	456	456
query63	310	277	281	277
query64	7651	7402	7428	7402
query65	3128	3085	3095	3085
query66	703	331	348	331
query67	15248	15178	15020	15020
query68	4541	534	533	533
query69	474	309	307	307
query70	1192	1149	1154	1149
query71	436	268	263	263
query72	7151	2574	2333	2333
query73	718	320	321	320
query74	6530	6147	6196	6147
query75	3325	2635	2590	2590
query76	2183	954	997	954
query77	369	264	259	259
query78	10700	10276	10132	10132
query79	2547	514	517	514
query80	1005	449	472	449
query81	529	213	224	213
query82	752	98	94	94
query83	253	162	162	162
query84	254	86	87	86
query85	1082	273	280	273
query86	483	315	309	309
query87	3284	3119	3092	3092
query88	4117	2376	2350	2350
query89	473	383	384	383
query90	2030	188	194	188
query91	144	98	100	98
query92	67	50	49	49
query93	1800	516	506	506
query94	1104	188	188	188
query95	403	301	310	301
query96	598	275	266	266
query97	3142	2975	2984	2975
query98	237	224	215	215
query99	1198	925	865	865
Total cold run time: 264328 ms
Total hot run time: 187323 ms

zclllyybb · 2024-05-14T01:42:31Z

run buildall

github-actions · 2024-05-14T01:48:45Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-14T01:59:32Z

TeamCity be ut coverage result:
Function Coverage: 35.66% (8989/25206)
Line Coverage: 27.31% (74305/272044)
Region Coverage: 26.54% (38393/144665)
Branch Coverage: 23.36% (19585/83826)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9175dc17e45d6682d60bd26780b546e754143c2d_9175dc17e45d6682d60bd26780b546e754143c2d/report/index.html

zclllyybb · 2024-05-15T13:54:43Z

run buildall

github-actions · 2024-05-15T14:00:57Z

clang-tidy review says "All clean, LGTM! 👍"

liaoxin01 · 2024-05-15T14:22:27Z

 }
 };

+struct WriteBlockCallbackContext {


Only one variable, no need this structure？

introduced in progress of this pr. for more change possible in the future I think this is more friendly so didn't remove this.

doris-robot · 2024-05-15T15:14:38Z

TPC-H: Total hot run time: 41113 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9033628cd474f6de22225fd0fa16338e13dc0a9b, data reload: false
------ Round 1 ----------------------------------
q1	17613	4478	4263	4263
q2	2022	193	186	186
q3	10871	1452	1314	1314
q4	10454	849	769	769
q5	7523	2678	2692	2678
q6	219	134	136	134
q7	1033	604	597	597
q8	9418	2142	2091	2091
q9	9139	6706	6684	6684
q10	9074	3731	3709	3709
q11	451	242	231	231
q12	412	234	219	219
q13	17767	3014	2945	2945
q14	253	211	212	211
q15	526	478	477	477
q16	532	381	384	381
q17	955	680	672	672
q18	8093	7643	7453	7453
q19	2588	1536	1514	1514
q20	630	299	293	293
q21	5059	4010	4033	4010
q22	348	282	283	282
Total cold run time: 114980 ms
Total hot run time: 41113 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4277	4186	4216	4186
q2	371	263	264	263
q3	3021	2763	2765	2763
q4	1883	1586	1628	1586
q5	5261	5292	5296	5292
q6	211	127	128	127
q7	2231	1866	1850	1850
q8	3179	3344	3315	3315
q9	8360	8346	8310	8310
q10	3844	3696	3693	3693
q11	575	489	481	481
q12	770	603	585	585
q13	16464	2951	2957	2951
q14	296	268	265	265
q15	506	475	476	475
q16	457	405	435	405
q17	1763	1488	1485	1485
q18	7578	7596	7527	7527
q19	1664	1497	1600	1497
q20	1959	1793	1760	1760
q21	5146	4865	4810	4810
q22	573	503	488	488
Total cold run time: 70389 ms
Total hot run time: 54114 ms

doris-robot · 2024-05-15T15:26:14Z

TPC-DS: Total hot run time: 187038 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9033628cd474f6de22225fd0fa16338e13dc0a9b, data reload: false
query1	894	396	365	365
query2	6456	2387	2264	2264
query3	6650	220	218	218
query4	22907	21275	21157	21157
query5	4138	418	414	414
query6	270	176	182	176
query7	4579	299	292	292
query8	243	183	194	183
query9	8562	2402	2394	2394
query10	433	247	244	244
query11	14878	14272	14167	14167
query12	136	89	86	86
query13	1642	365	375	365
query14	10624	8497	7708	7708
query15	254	160	168	160
query16	8141	255	256	255
query17	1867	542	535	535
query18	2095	270	266	266
query19	198	154	148	148
query20	94	84	82	82
query21	194	136	126	126
query22	5063	4827	4828	4827
query23	34187	33606	33686	33606
query24	12037	2938	2878	2878
query25	656	373	364	364
query26	1759	171	158	158
query27	2910	319	337	319
query28	7503	2044	2037	2037
query29	1042	609	599	599
query30	286	172	175	172
query31	991	750	733	733
query32	88	50	60	50
query33	736	247	243	243
query34	1024	475	477	475
query35	822	684	680	680
query36	1089	886	922	886
query37	205	70	71	70
query38	2942	2786	2733	2733
query39	1627	1571	1538	1538
query40	270	129	121	121
query41	46	42	43	42
query42	112	95	100	95
query43	558	514	529	514
query44	1262	736	742	736
query45	276	265	266	265
query46	1093	728	751	728
query47	1978	1895	1858	1858
query48	372	303	299	299
query49	1182	397	401	397
query50	768	390	384	384
query51	6936	6804	6846	6804
query52	108	89	90	89
query53	350	290	284	284
query54	991	421	431	421
query55	77	74	74	74
query56	242	218	216	216
query57	1257	1171	1148	1148
query58	222	214	208	208
query59	3522	3293	2914	2914
query60	252	225	233	225
query61	117	84	89	84
query62	676	500	455	455
query63	309	293	287	287
query64	9728	7350	7432	7350
query65	3132	3102	3115	3102
query66	1396	347	348	347
query67	15365	15111	14990	14990
query68	4659	529	536	529
query69	493	300	300	300
query70	1104	1115	1141	1115
query71	407	270	275	270
query72	7050	2531	2408	2408
query73	697	324	322	322
query74	6500	6045	6011	6011
query75	3432	2654	2623	2623
query76	2843	969	1066	969
query77	417	268	266	266
query78	10519	10259	10259	10259
query79	1439	527	509	509
query80	1052	422	425	422
query81	527	238	248	238
query82	1062	92	98	92
query83	241	162	167	162
query84	236	83	83	83
query85	1211	317	267	267
query86	386	323	285	285
query87	3270	3105	3179	3105
query88	3082	2356	2353	2353
query89	470	389	373	373
query90	1921	181	183	181
query91	123	99	97	97
query92	59	48	49	48
query93	1167	507	489	489
query94	1209	179	176	176
query95	386	293	299	293
query96	571	272	266	266
query97	3174	3022	2985	2985
query98	235	217	215	215
query99	1135	924	917	917
Total cold run time: 283896 ms
Total hot run time: 187038 ms

zclllyybb · 2024-05-15T15:26:15Z

run buildall

doris-robot · 2024-05-15T15:31:44Z

ClickBench: Total hot run time: 30.37 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9033628cd474f6de22225fd0fa16338e13dc0a9b, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.67	0.07	0.06
query5	0.51	0.50	0.52
query6	1.12	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.53	0.49	0.50
query10	0.54	0.55	0.55
query11	0.16	0.12	0.11
query12	0.14	0.12	0.12
query13	0.59	0.58	0.60
query14	0.79	0.76	0.77
query15	0.83	0.81	0.82
query16	0.36	0.36	0.34
query17	0.94	0.97	0.96
query18	0.21	0.25	0.24
query19	1.81	1.69	1.65
query20	0.02	0.01	0.01
query21	15.48	0.69	0.64
query22	4.13	7.33	2.01
query23	18.27	1.35	1.25
query24	2.06	0.22	0.18
query25	0.14	0.08	0.08
query26	0.27	0.17	0.18
query27	0.08	0.08	0.07
query28	13.35	1.00	1.01
query29	12.93	3.29	3.22
query30	0.24	0.06	0.05
query31	2.88	0.39	0.37
query32	3.28	0.47	0.48
query33	2.80	2.85	2.79
query34	17.22	4.46	4.50
query35	4.47	4.51	4.59
query36	0.63	0.46	0.46
query37	0.17	0.15	0.16
query38	0.15	0.15	0.14
query39	0.04	0.03	0.03
query40	0.16	0.13	0.13
query41	0.10	0.04	0.04
query42	0.05	0.05	0.05
query43	0.03	0.04	0.03
Total cold run time: 109.57 s
Total hot run time: 30.37 s

github-actions · 2024-05-15T15:32:13Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-15T17:02:06Z

TeamCity be ut coverage result:
Function Coverage: 35.69% (8996/25207)
Line Coverage: 27.36% (74440/272078)
Region Coverage: 26.59% (38479/144699)
Branch Coverage: 23.41% (19630/83852)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f5800639c9b784e6207ab9e471e5f8937586eed4_f5800639c9b784e6207ab9e471e5f8937586eed4/report/index.html

zclllyybb · 2024-05-24T09:35:21Z

close this since #35287 covered

…er (#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace #34740 Co-authored-by: zhaochangle <zhaochangle@selectdb.com>

…er (apache#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace apache#34740 Co-authored-by: zhaochangle <zhaochangle@selectdb.com>

…er (#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace #34740 Co-authored-by: zhaochangle <zhaochangle@selectdb.com>

…er (apache#35287) Change `use_cnt` mechanism for incremental (auto partition) channels and streams, it's now dynamically counted. Use `close_wait()` of regular partitions as a synchronize point to make sure all sinks are in close phase before closing any incremental (auto partition) channels and streams. Add dummy (fake) partition and tablet if there is no regular partition in the auto partition table. Replace apache#34740 Co-authored-by: zhaochangle <zhaochangle@selectdb.com>

github-actionsBot added the meta-change label May 12, 2024

zclllyybb force-pushed the ap_fix_load branch from aba715d to cdcabb3Compare May 12, 2024 18:36

zclllyybb force-pushed the ap_fix_load branch from cdcabb3 to 21c0f3aCompare May 12, 2024 20:20

HappenLee reviewed May 13, 2024
View reviewed changes

Comment threadbe/src/vec/sink/writer/vtablet_writer.cpp

HappenLee reviewed May 13, 2024
View reviewed changes

Comment threadbe/src/vec/sink/writer/vtablet_writer.cpp Outdated

zclllyybb force-pushed the ap_fix_load branch from 8e9edc0 to 9175dc1Compare May 14, 2024 01:42

zclllyybb added 3 commits May 14, 2024 16:57

1
5cd4737

make hang on reciever
054bafa

just use mark_close
ccb8935

zclllyybb added 2 commits May 14, 2024 16:57

testcases
fd3bf9d

temporarily change some cases
a320be6

zclllyybb commented May 15, 2024
View reviewed changes

Comment threadbe/src/runtime/load_channel.cpp Outdated

zclllyybb commented May 15, 2024
View reviewed changes

Comment threadbe/src/runtime/tablets_channel.cpp Outdated

zclllyybb force-pushed the ap_fix_load branch from 9175dc1 to 9033628Compare May 15, 2024 13:54

liaoxin01 reviewed May 15, 2024
View reviewed changes

make non-auto table not hang on close. add comment.
f580063

zclllyybb force-pushed the ap_fix_load branch from 9033628 to f580063Compare May 15, 2024 15:26

kaijchen mentioned this pull request May 24, 2024
[fix](auto-partition) fix auto partition load lost data in multi sender #35287
Merged

zclllyybb closed this May 24, 2024

zclllyybb deleted the ap_fix_load branch May 24, 2024 09:35

Uh oh!

Conversation

zclllyybb commented May 12, 2024

Proposed changes

Further comments

Uh oh!

doris-robot commented May 12, 2024

Uh oh!

zclllyybb commented May 12, 2024

Uh oh!

github-actionsBot commented May 12, 2024

Uh oh!

github-actionsBot commented May 12, 2024

Uh oh!

doris-robot commented May 12, 2024

Uh oh!

zclllyybb commented May 12, 2024

Uh oh!

github-actionsBot commented May 12, 2024

Uh oh!

doris-robot commented May 12, 2024

Uh oh!

doris-robot commented May 12, 2024

Uh oh!

doris-robot commented May 12, 2024

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented May 13, 2024

Uh oh!

zclllyybb commented May 13, 2024

Uh oh!

github-actionsBot commented May 13, 2024

Uh oh!

zclllyybb commented May 13, 2024

Uh oh!

github-actionsBot commented May 13, 2024

Uh oh!

doris-robot commented May 13, 2024

Uh oh!

doris-robot commented May 13, 2024

Uh oh!

doris-robot commented May 13, 2024

Uh oh!

zclllyybb commented May 14, 2024

Uh oh!

github-actionsBot commented May 14, 2024

Uh oh!

doris-robot commented May 14, 2024

Uh oh!

Uh oh!

Uh oh!

zclllyybb commented May 15, 2024

Uh oh!

github-actionsBot commented May 15, 2024

Uh oh!

Uh oh!

liaoxin01May 15, 2024

Choose a reason for hiding this comment

Uh oh!

zclllyybbMay 15, 2024

Choose a reason for hiding this comment

Uh oh!

doris-robot commented May 15, 2024

Uh oh!

doris-robot commented May 15, 2024

Uh oh!

zclllyybb commented May 15, 2024

Uh oh!

doris-robot commented May 15, 2024

Uh oh!

github-actionsBot commented May 15, 2024

Uh oh!

doris-robot commented May 15, 2024

Uh oh!

zclllyybb commented May 24, 2024

Uh oh!

Reviewers

Assignees

Labels