Skip to content

[fix](reader) avoid be coredump in block reader in abnormal situation - #34878

Merged
yiguolei merged 1 commit into
apache:masterfrom
jacktengg:fix-0515
May 15, 2024
Merged

[fix](reader) avoid be coredump in block reader in abnormal situation#34878
yiguolei merged 1 commit into
apache:masterfrom
jacktengg:fix-0515

Conversation

@jacktengg

@jacktenggjacktengg commented May 15, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented May 15, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@jacktengg

jacktengg commented May 15, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

github-actions[bot]
github-actionsBot reviewed May 15, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/vec/olap/block_reader.cpp
@jacktenggjacktengg mentioned this pull request May 15, 2024
Merged
@doris-robot

doris-robot commented May 15, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.66% (8984/25192)
Line Coverage: 27.33% (74272/271801)
Region Coverage: 26.56% (38386/144514)
Branch Coverage: 23.37% (19570/83738)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ee3142cfa9681ab2cc13bbc49a9786508b7d9035_ee3142cfa9681ab2cc13bbc49a9786508b7d9035/report/index.html

@yiguoleiyiguolei added dev/2.0.x usercase Important user case type label labels May 15, 2024
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 15, 2024
@github-actions

github-actionsBot commented May 15, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented May 15, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit 4dd3e4e into apache:masterMay 15, 2024
yiguolei pushed a commit that referenced this pull request May 15, 2024
@jacktengg@Doris-Extras
[fix](reader) avoid be coredump in block reader in abnormal situation (…
2cbe674
…#34878)
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@jacktengg@HappenLee
[fix](reader) avoid be coredump in block reader in abnormal situation (…
0f4146b
…apache#34878)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@yiguoleiyiguoleiyiguolei approved these changes
+1 more reviewer
@RoanHeNaNRoanHeNaNRoanHeNaN approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.11-mergeddev/3.0.0-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jacktengg@doris-robot@yiguolei@RoanHeNaN@dataroaring