Skip to content

[fix](multi-catalog)remove http scheme in oss endpoint - #34907

Merged
morningman merged 1 commit into
apache:masterfrom
wsjz:rm_oss_http
May 17, 2024
Merged

[fix](multi-catalog)remove http scheme in oss endpoint#34907
morningman merged 1 commit into
apache:masterfrom
wsjz:rm_oss_http

Conversation

@wsjz

@wsjzwsjz commented May 15, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

remove http scheme in oss endpoint, scheme maybe appear in url (http://bucket.http//.region.aliyuncs.com) if use http client

p2 case (test_cloud_accessible_oss.groovy) :

CREATE CATALOG dlf
PROPERTIES (
"type"="hms",
"hive.metastore.type" = "dlf",
"dlf.endpoint" = "dlf.cn-beijing.aliyuncs.com",
"dlf.region" = "cn-beijing",
"dlf.proxy.mode" = "DLF_ONLY",
"dlf.uid" = "xx",
"dlf.access_key" = "",
"dlf.secret_key" = "",
"dlf.access.public" = "true"
);
use jz_datalake;
select * from web_site where web_site_id='AAAAAAAAKBAAAAAA' order by web_site_sk,web_site_id limit 1;

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman

Copy link
Copy Markdown
Contributor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 17, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit db34ad5 into apache:masterMay 17, 2024
yiguolei pushed a commit that referenced this pull request May 18, 2024
remove http scheme in oss endpoint, scheme maybe appear in url (http://bucket.http//.region.aliyuncs.com) if use http client
dataroaring pushed a commit that referenced this pull request May 26, 2024
remove http scheme in oss endpoint, scheme maybe appear in url (http://bucket.http//.region.aliyuncs.com) if use http client
@morningmanmorningman mentioned this pull request Jun 1, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@wsjz
wsjz deleted the rm_oss_http branch November 18, 2024 01:19
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
remove http scheme in oss endpoint, scheme maybe appear in url (http://bucket.http//.region.aliyuncs.com) if use http client
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.11-mergeddev/2.1.4-mergeddev/3.0.0-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@wsjz@doris-robot@morningman@wuwenchi@gavinchou