Skip to content

[Fix](tablet id) use int64_t instead of int32_t or uint32_t for table… - #34962

Merged
dataroaring merged 1 commit into
apache:masterfrom
eldenmoon:fix-tablet-id
May 16, 2024
Merged

[Fix](tablet id) use int64_t instead of int32_t or uint32_t for table…#34962
dataroaring merged 1 commit into
apache:masterfrom
eldenmoon:fix-tablet-id

Conversation

@eldenmoon

@eldenmooneldenmoon commented May 16, 2024

Copy link
Copy Markdown
Member

…t_id

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented May 16, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon
eldenmoon marked this pull request as ready for review May 16, 2024 09:10
@eldenmoon

eldenmoon commented May 16, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented May 16, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes May 16, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 16, 2024
@github-actions

github-actionsBot commented May 16, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented May 16, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

airborne12
airborne12 approved these changes May 16, 2024
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaokang
xiaokang approved these changes May 16, 2024
View reviewed changes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot

doris-robot commented May 16, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.70% (9004/25219)
Line Coverage: 27.37% (74489/272146)
Region Coverage: 26.61% (38508/144709)
Branch Coverage: 23.43% (19643/83838)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e9feb3ad93dcbced75249755260aad0682f1f786_e9feb3ad93dcbced75249755260aad0682f1f786/report/index.html

@dataroaring
dataroaring merged commit 173db9d into apache:masterMay 16, 2024
dataroaring pushed a commit that referenced this pull request May 16, 2024
@eldenmoon@dataroaring
[Fix](tablet id) use int64_t instead of int32_t or uint32_t for table…
4245ffc
…t_id (#34962)
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request May 17, 2024
@eldenmoon
[Fix](tablet id) use int64_t instead of int32_t or uint32_t for table…
4000fff
…t_id (apache#34962)
@eldenmooneldenmoon mentioned this pull request May 17, 2024
Merged
yiguolei pushed a commit that referenced this pull request May 18, 2024
@eldenmoon@Doris-Extras
[Fix](tablet id) use int64_t instead of int32_t or uint32_t for table…
db273d5
…t_id (#34962)
xiaokang pushed a commit that referenced this pull request May 20, 2024
@eldenmoon@Yukang-Lian
[Pick](Branch-2.0) pick to fix tablet_id overflow#34912#34962(#34995)
4fa2bde
Co-authored-by: abmdocrt <Yukang.Lian2022@gmail.com>
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@eldenmoon@Yukang-Lianweixingyu12
[Pick](Branch-2.0) pick to fix tablet_id overflowapache#34912apache…
fa766b9
…#34962 (apache#34995)
Co-authored-by: abmdocrt <Yukang.Lian2022@gmail.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@eldenmoon@HappenLee
[Fix](tablet id) use int64_t instead of int32_t or uint32_t for table…
ad6f4db
…t_id (apache#34962)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokangxiaokangxiaokang approved these changes
@airborne12airborne12airborne12 approved these changes
@gavinchougavinchougavinchou approved these changes
@qidayeqidayeqidaye approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.11-mergeddev/3.0.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@eldenmoon@doris-robot@xiaokang@airborne12@gavinchou@qidaye@dataroaring