Skip to content

[chore](multi catalog) Print serde properties when show create hive-external-table - #34966

Merged
morningman merged 3 commits into
apache:masterfrom
xy720:print-serde-properties-master
May 22, 2024
Merged

[chore](multi catalog) Print serde properties when show create hive-external-table#34966
morningman merged 3 commits into
apache:masterfrom
xy720:print-serde-properties-master

Conversation

@xy720

@xy720xy720 commented May 16, 2024

Copy link
Copy Markdown
Member

Proposed changes

Issue Number: close #xxx

before:

CREATE TABLE `test`(
`id` int,
`name` string)
ROW FORMAT SERDE
'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'
STORED AS INPUTFORMAT
'org.apache.hadoop.mapred.TextInputFormat'
OUTPUTFORMAT
'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
LOCATION
'hdfs://HDFS1012837/usr/hive/warehouse/test.db/test'
TBLPROPERTIES (
...
)

after:

CREATE TABLE `test`(
`id` int,
`name` string)
ROW FORMAT SERDE
'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'
WITH SERDEPROPERTIES (
'serialization.format' = ',',
'field.delim' = ',')
STORED AS INPUTFORMAT
'org.apache.hadoop.mapred.TextInputFormat'
OUTPUTFORMAT
'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
LOCATION
'hdfs://HDFS1012837/usr/hive/warehouse/test.db/test'
TBLPROPERTIES (
...
)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xy720

Copy link
Copy Markdown
MemberAuthor

run buildall

@xy720

Copy link
Copy Markdown
MemberAuthor

run buildall

@xy720

Copy link
Copy Markdown
MemberAuthor

run cloud_p1

cambyzju
cambyzju previously approved these changes May 17, 2024

@cambyzjucambyzju left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 17, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add UT or test case

@xy720
xy720force-pushed the print-serde-properties-master branch from b414895 to c9548a5CompareMay 20, 2024 15:27
@xy720

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label May 20, 2024
@xy720
xy720 requested a review from morningmanMay 21, 2024 02:56

@lide-reedlide-reed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 21, 2024

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
morningman merged commit b2b609a into apache:masterMay 22, 2024
dataroaring pushed a commit that referenced this pull request May 26, 2024
…xternal-table (#34966)
before:
```
CREATE TABLE `test`(
`id` int,
`name` string)
ROW FORMAT SERDE
'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'
STORED AS INPUTFORMAT
'org.apache.hadoop.mapred.TextInputFormat'
OUTPUTFORMAT
'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
LOCATION
'hdfs://HDFS1012837/usr/hive/warehouse/test.db/test'
TBLPROPERTIES (
...
)
```
after:
```
CREATE TABLE `test`(
`id` int,
`name` string)
ROW FORMAT SERDE
'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'
WITH SERDEPROPERTIES (
'serialization.format' = ',',
'field.delim' = ',')
STORED AS INPUTFORMAT
'org.apache.hadoop.mapred.TextInputFormat'
OUTPUTFORMAT
'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
LOCATION
'hdfs://HDFS1012837/usr/hive/warehouse/test.db/test'
TBLPROPERTIES (
...
)
```
morningman pushed a commit to morningman/doris that referenced this pull request Jul 1, 2024
…xternal-table (apache#34966)
before:
```
CREATE TABLE `test`(
`id` int,
`name` string)
ROW FORMAT SERDE
'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'
STORED AS INPUTFORMAT
'org.apache.hadoop.mapred.TextInputFormat'
OUTPUTFORMAT
'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
LOCATION
'hdfs://HDFS1012837/usr/hive/warehouse/test.db/test'
TBLPROPERTIES (
...
)
```
after:
```
CREATE TABLE `test`(
`id` int,
`name` string)
ROW FORMAT SERDE
'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'
WITH SERDEPROPERTIES (
'serialization.format' = ',',
'field.delim' = ',')
STORED AS INPUTFORMAT
'org.apache.hadoop.mapred.TextInputFormat'
OUTPUTFORMAT
'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
LOCATION
'hdfs://HDFS1012837/usr/hive/warehouse/test.db/test'
TBLPROPERTIES (
...
)
```
morningman added a commit that referenced this pull request Jul 2, 2024
…xternal-table (#34966) (#37096)
bp #34966
Co-authored-by: xy720 <22125576+xy720@users.noreply.github.com>
morningman added a commit to morningman/doris that referenced this pull request Jul 9, 2024
…xternal-table (apache#34966) (apache#37096)
bp apache#34966
Co-authored-by: xy720 <22125576+xy720@users.noreply.github.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
…xternal-table (apache#34966)
before:
```
CREATE TABLE `test`(
`id` int,
`name` string)
ROW FORMAT SERDE
'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'
STORED AS INPUTFORMAT
'org.apache.hadoop.mapred.TextInputFormat'
OUTPUTFORMAT
'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
LOCATION
'hdfs://HDFS1012837/usr/hive/warehouse/test.db/test'
TBLPROPERTIES (
...
)
```
after:
```
CREATE TABLE `test`(
`id` int,
`name` string)
ROW FORMAT SERDE
'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'
WITH SERDEPROPERTIES (
'serialization.format' = ',',
'field.delim' = ',')
STORED AS INPUTFORMAT
'org.apache.hadoop.mapred.TextInputFormat'
OUTPUTFORMAT
'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
LOCATION
'hdfs://HDFS1012837/usr/hive/warehouse/test.db/test'
TBLPROPERTIES (
...
)
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.12-mergeddev/2.1.5-mergeddev/3.0.0-mergedreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@xy720@doris-robot@lide-reed@morningman@cambyzju@gavinchou