[fix](nereids)AdjustNullable rule should handle union node with no children by starocean999 · Pull Request #35074 · apache/doris

starocean999 · 2024-05-20T10:28:22Z

Proposed changes

The output slot's nullable info is not correctly calculated in union node. Because old code only get correct result if union node has children. But the union node may have no children but only have constantExprList. So in that case, we should calculate output's nullable info by both children and constantExprList.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

doris-robot · 2024-05-20T10:28:27Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

starocean999 · 2024-05-20T10:28:31Z

run buildall

starocean999 · 2024-05-21T10:56:11Z

run buildall

doris-robot · 2024-05-21T11:14:00Z

TPC-H: Total hot run time: 40353 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d9a04c9f43024de96985fa39b858f97cffa2126a, data reload: false
------ Round 1 ----------------------------------
q1	18028	4417	4357	4357
q2	2621	192	193	192
q3	11121	1169	1201	1169
q4	10484	700	813	700
q5	8144	2711	2631	2631
q6	222	135	135	135
q7	922	534	535	534
q8	9247	2106	2048	2048
q9	9724	7065	6986	6986
q10	8940	3706	3701	3701
q11	447	242	233	233
q12	447	209	210	209
q13	17843	2948	2949	2948
q14	265	210	220	210
q15	518	476	484	476
q16	498	382	378	378
q17	948	741	711	711
q18	8003	7492	7453	7453
q19	3496	1528	1487	1487
q20	647	302	304	302
q21	4998	3214	4005	3214
q22	346	279	284	279
Total cold run time: 117909 ms
Total hot run time: 40353 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4437	4195	4139	4139
q2	377	250	263	250
q3	2937	2733	2709	2709
q4	1877	1533	1549	1533
q5	5238	5269	5259	5259
q6	207	125	125	125
q7	1716	1365	1378	1365
q8	3175	3334	3278	3278
q9	8862	8900	8943	8900
q10	3845	3676	3671	3671
q11	603	478	480	478
q12	750	595	605	595
q13	16293	2958	2977	2958
q14	291	280	260	260
q15	514	478	472	472
q16	485	416	403	403
q17	1760	1487	1462	1462
q18	7632	7600	7400	7400
q19	1628	1528	1507	1507
q20	2017	1793	1783	1783
q21	4920	4821	4806	4806
q22	552	491	496	491
Total cold run time: 70116 ms
Total hot run time: 53844 ms

doris-robot · 2024-05-21T11:25:45Z

TPC-DS: Total hot run time: 181671 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d9a04c9f43024de96985fa39b858f97cffa2126a, data reload: false
query1	909	382	364	364
query2	6459	2385	2399	2385
query3	6658	218	214	214
query4	24033	21225	21344	21225
query5	4153	417	432	417
query6	263	172	168	168
query7	4569	290	276	276
query8	235	186	192	186
query9	8444	2390	2388	2388
query10	429	247	249	247
query11	14783	14141	14144	14141
query12	136	91	86	86
query13	1637	358	362	358
query14	8865	7942	7694	7694
query15	224	173	171	171
query16	8093	281	257	257
query17	1861	536	539	536
query18	2072	281	264	264
query19	200	147	149	147
query20	96	85	85	85
query21	196	126	126	126
query22	5084	4885	4799	4799
query23	34091	33504	33691	33504
query24	10809	2932	2857	2857
query25	648	390	388	388
query26	1483	159	164	159
query27	2993	326	342	326
query28	7556	2047	2029	2029
query29	938	638	621	621
query30	313	175	172	172
query31	983	767	765	765
query32	93	54	56	54
query33	761	261	250	250
query34	1050	497	480	480
query35	803	693	667	667
query36	1082	937	946	937
query37	151	76	77	76
query38	2874	2784	2761	2761
query39	1632	1564	1586	1564
query40	270	125	132	125
query41	49	46	47	46
query42	107	105	96	96
query43	570	593	568	568
query44	1216	725	753	725
query45	275	252	248	248
query46	1074	707	733	707
query47	1955	1880	1875	1875
query48	368	301	295	295
query49	1109	416	410	410
query50	777	397	387	387
query51	6794	6690	6813	6690
query52	106	96	97	96
query53	351	282	287	282
query54	944	438	424	424
query55	74	78	77	77
query56	244	231	237	231
query57	1241	1108	1132	1108
query58	243	207	217	207
query59	3630	3052	3060	3052
query60	287	242	241	241
query61	107	106	106	106
query62	670	468	472	468
query63	317	289	287	287
query64	10057	2294	1816	1816
query65	3251	3144	3100	3100
query66	1396	366	360	360
query67	15497	14882	14825	14825
query68	8484	553	561	553
query69	567	311	318	311
query70	1402	1252	1146	1146
query71	508	267	286	267
query72	7986	2550	2364	2364
query73	2150	320	323	320
query74	6695	6280	6214	6214
query75	4454	2657	2636	2636
query76	5178	1031	1030	1030
query77	628	264	268	264
query78	10778	10042	10038	10038
query79	7322	508	526	508
query80	1148	429	429	429
query81	518	253	244	244
query82	238	98	99	98
query83	201	165	183	165
query84	260	83	84	83
query85	1006	266	259	259
query86	348	300	283	283
query87	3321	3124	3085	3085
query88	4897	2342	2358	2342
query89	521	384	390	384
query90	2085	187	192	187
query91	122	98	97	97
query92	62	52	52	52
query93	5791	484	493	484
query94	1231	177	180	177
query95	393	298	336	298
query96	617	263	261	261
query97	3154	3013	2995	2995
query98	250	220	208	208
query99	1228	908	893	893
Total cold run time: 304181 ms
Total hot run time: 181671 ms

doris-robot · 2024-05-21T11:31:16Z

ClickBench: Total hot run time: 30.64 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d9a04c9f43024de96985fa39b858f97cffa2126a, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.04	0.03
query3	0.23	0.05	0.05
query4	1.66	0.07	0.07
query5	0.50	0.48	0.50
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.48
query10	0.55	0.55	0.54
query11	0.15	0.11	0.12
query12	0.15	0.11	0.12
query13	0.59	0.58	0.61
query14	0.77	0.80	0.79
query15	0.83	0.80	0.80
query16	0.37	0.36	0.37
query17	0.97	0.96	1.00
query18	0.22	0.24	0.25
query19	1.76	1.74	1.73
query20	0.01	0.00	0.01
query21	15.55	0.68	0.66
query22	3.64	7.47	2.05
query23	18.26	1.36	1.32
query24	1.98	0.23	0.21
query25	0.13	0.08	0.09
query26	0.27	0.18	0.17
query27	0.08	0.08	0.08
query28	13.28	1.02	0.99
query29	13.25	3.27	3.30
query30	0.24	0.06	0.05
query31	2.88	0.38	0.37
query32	3.29	0.49	0.46
query33	2.91	2.86	2.93
query34	17.10	4.40	4.45
query35	4.57	4.48	4.50
query36	0.66	0.46	0.46
query37	0.18	0.15	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.17	0.15	0.16
query41	0.09	0.05	0.04
query42	0.05	0.04	0.04
query43	0.04	0.04	0.03
Total cold run time: 109.44 s
Total hot run time: 30.64 s

starocean999 · 2024-05-23T04:02:33Z

run buildall

github-actions · 2024-05-23T04:25:55Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-05-23T04:25:57Z

PR approved by anyone and no changes requested.

doris-robot · 2024-05-23T05:01:44Z

TPC-H: Total hot run time: 40252 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3067d1f7ad67da0ce7a906361146facec3bd7e26, data reload: false
------ Round 1 ----------------------------------
q1	17618	4299	4272	4272
q2	2020	191	185	185
q3	10867	1302	1232	1232
q4	10492	879	770	770
q5	7831	2721	2741	2721
q6	220	134	130	130
q7	967	605	608	605
q8	9613	2112	2112	2112
q9	9351	6630	6601	6601
q10	9775	3736	3704	3704
q11	466	241	224	224
q12	417	225	211	211
q13	17753	3002	2970	2970
q14	265	226	219	219
q15	507	478	477	477
q16	498	382	373	373
q17	962	664	673	664
q18	8120	7472	7625	7472
q19	2637	1562	1544	1544
q20	642	313	305	305
q21	4947	3188	3342	3188
q22	347	282	273	273
Total cold run time: 116315 ms
Total hot run time: 40252 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4397	4157	4209	4157
q2	376	278	265	265
q3	2975	2767	2778	2767
q4	1913	1602	1629	1602
q5	5242	5264	5299	5264
q6	213	125	123	123
q7	2147	1761	1712	1712
q8	3210	3335	3323	3323
q9	8372	8306	8394	8306
q10	3918	3740	3735	3735
q11	579	515	495	495
q12	776	604	620	604
q13	16408	2952	2965	2952
q14	290	271	267	267
q15	527	477	469	469
q16	481	416	411	411
q17	1760	1482	1487	1482
q18	7740	7574	7476	7476
q19	2871	1574	1578	1574
q20	1996	1762	1765	1762
q21	4977	4890	4753	4753
q22	573	509	498	498
Total cold run time: 71741 ms
Total hot run time: 53997 ms

doris-robot · 2024-05-23T05:12:36Z

TPC-DS: Total hot run time: 169070 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3067d1f7ad67da0ce7a906361146facec3bd7e26, data reload: false
query1	912	386	369	369
query2	6452	2364	2300	2300
query3	6657	210	209	209
query4	19564	17329	17386	17329
query5	4245	417	417	417
query6	244	158	161	158
query7	4583	295	301	295
query8	235	182	191	182
query9	8436	2380	2347	2347
query10	466	276	270	270
query11	10668	10022	9933	9933
query12	135	90	87	87
query13	1661	365	355	355
query14	9330	6967	7212	6967
query15	209	168	172	168
query16	7797	269	269	269
query17	1506	526	527	526
query18	1953	278	275	275
query19	206	170	159	159
query20	91	80	88	80
query21	192	129	131	129
query22	4262	4071	3871	3871
query23	33424	33460	33093	33093
query24	12296	2763	2838	2763
query25	658	369	384	369
query26	1834	156	164	156
query27	3081	309	314	309
query28	7691	2019	2036	2019
query29	1166	606	601	601
query30	318	173	172	172
query31	922	746	737	737
query32	82	53	55	53
query33	764	281	279	279
query34	1075	480	482	480
query35	734	656	609	609
query36	1108	941	922	922
query37	276	71	75	71
query38	2936	2788	2755	2755
query39	844	804	795	795
query40	277	126	123	123
query41	46	44	39	39
query42	105	95	97	95
query43	597	565	546	546
query44	1200	721	742	721
query45	193	170	170	170
query46	1077	738	711	711
query47	1833	1739	1780	1739
query48	367	289	302	289
query49	1178	379	386	379
query50	789	387	382	382
query51	6942	6743	6908	6743
query52	102	85	93	85
query53	348	290	282	282
query54	952	429	418	418
query55	72	74	71	71
query56	291	245	264	245
query57	1115	1060	1052	1052
query58	239	206	209	206
query59	3358	3099	3107	3099
query60	263	256	250	250
query61	90	87	89	87
query62	643	464	446	446
query63	310	277	286	277
query64	9801	2182	1745	1745
query65	3202	3072	3114	3072
query66	1388	329	327	327
query67	15339	14716	14772	14716
query68	4494	534	536	534
query69	437	264	275	264
query70	1177	1040	1098	1040
query71	390	262	280	262
query72	7260	5392	2739	2739
query73	714	325	317	317
query74	6023	5649	5558	5558
query75	3394	2645	2654	2645
query76	2444	1005	999	999
query77	447	264	263	263
query78	10214	9979	9692	9692
query79	2473	510	509	509
query80	1097	432	424	424
query81	532	248	241	241
query82	794	96	93	93
query83	257	172	183	172
query84	234	97	84	84
query85	1266	268	263	263
query86	428	300	308	300
query87	3316	3137	3120	3120
query88	4218	2338	2326	2326
query89	477	387	367	367
query90	2027	181	181	181
query91	122	100	99	99
query92	64	52	49	49
query93	1901	510	491	491
query94	1304	260	180	180
query95	402	310	305	305
query96	600	266	271	266
query97	3171	3027	3008	3008
query98	229	221	218	218
query99	1085	871	868	868
Total cold run time: 274121 ms
Total hot run time: 169070 ms

doris-robot · 2024-05-23T05:18:05Z

ClickBench: Total hot run time: 30.57 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3067d1f7ad67da0ce7a906361146facec3bd7e26, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.03	0.04
query3	0.23	0.04	0.05
query4	1.68	0.07	0.08
query5	0.50	0.49	0.49
query6	1.11	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.52	0.50	0.49
query10	0.56	0.56	0.54
query11	0.16	0.11	0.10
query12	0.14	0.12	0.11
query13	0.59	0.59	0.59
query14	0.76	0.78	0.78
query15	0.83	0.81	0.80
query16	0.35	0.37	0.36
query17	1.02	1.06	1.02
query18	0.21	0.20	0.27
query19	1.84	1.79	1.80
query20	0.01	0.02	0.01
query21	15.54	0.70	0.69
query22	4.01	7.51	1.99
query23	18.34	1.34	1.20
query24	1.74	0.29	0.21
query25	0.13	0.09	0.07
query26	0.26	0.17	0.17
query27	0.08	0.08	0.08
query28	13.26	1.01	1.00
query29	13.15	3.24	3.25
query30	0.24	0.06	0.06
query31	2.86	0.37	0.38
query32	3.30	0.46	0.47
query33	2.92	2.81	2.87
query34	17.18	4.43	4.43
query35	4.51	4.49	4.53
query36	0.66	0.48	0.47
query37	0.17	0.16	0.15
query38	0.15	0.15	0.14
query39	0.04	0.03	0.04
query40	0.15	0.15	0.15
query41	0.09	0.06	0.05
query42	0.05	0.06	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.57 s
Total hot run time: 30.57 s

englefly · 2024-05-23T09:19:08Z

 if (setOperation instanceof LogicalUnion) {
 LogicalUnion logicalUnion = (LogicalUnion) setOperation;
+ int consExprListSize = logicalUnion.getConstantExprsList().size();
+ if (consExprListSize > 0 && inputNullable == null) {


!logicalUnion.getConstantExprsList().isEmpty() && !setOperation.children().isEmpty()

englefly · 2024-05-23T09:19:44Z

 }
 }
 }
+ if (inputNullable == null) {


logicalUnion.getConstantExprsList().isEmpty() && setOperation.children().isEmpty()
=> inputNullable == null

starocean999 · 2024-05-23T09:52:20Z

run buildall

doris-robot · 2024-05-23T10:11:27Z

TPC-H: Total hot run time: 39882 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6bf64202255799eff7611c4f278ee8cc148aaafe, data reload: false
------ Round 1 ----------------------------------
q1	17860	4358	4209	4209
q2	2022	193	195	193
q3	10798	1299	1132	1132
q4	11179	789	703	703
q5	7892	2702	2644	2644
q6	219	131	130	130
q7	957	619	597	597
q8	9577	2084	2076	2076
q9	9079	6579	6576	6576
q10	9205	3655	3747	3655
q11	458	244	233	233
q12	499	219	206	206
q13	17766	3014	2988	2988
q14	253	223	228	223
q15	509	466	471	466
q16	533	372	375	372
q17	952	688	666	666
q18	8161	7465	7484	7465
q19	2929	1524	1522	1522
q20	658	309	308	308
q21	4964	3238	3320	3238
q22	352	288	280	280
Total cold run time: 116822 ms
Total hot run time: 39882 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4331	4604	4204	4204
q2	366	273	270	270
q3	2956	2779	2726	2726
q4	1854	1575	1561	1561
q5	5213	5287	5262	5262
q6	210	125	129	125
q7	2131	1722	1720	1720
q8	3170	3317	3284	3284
q9	8311	8327	8342	8327
q10	3918	3656	3696	3656
q11	594	490	499	490
q12	774	594	587	587
q13	17426	2982	3015	2982
q14	280	261	261	261
q15	519	465	471	465
q16	464	415	424	415
q17	1747	1472	1441	1441
q18	7678	7610	7545	7545
q19	1640	1519	1592	1519
q20	1990	1801	1760	1760
q21	9930	4599	4704	4599
q22	559	488	475	475
Total cold run time: 76061 ms
Total hot run time: 53674 ms

doris-robot · 2024-05-23T10:22:25Z

TPC-DS: Total hot run time: 169486 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6bf64202255799eff7611c4f278ee8cc148aaafe, data reload: false
query1	922	376	382	376
query2	6956	2325	2384	2325
query3	6649	204	207	204
query4	19703	17493	17305	17305
query5	4125	430	429	429
query6	263	160	157	157
query7	4577	309	290	290
query8	252	186	188	186
query9	8706	2444	2431	2431
query10	456	280	261	261
query11	10490	10277	9975	9975
query12	132	93	87	87
query13	1635	377	357	357
query14	10102	7065	7003	7003
query15	206	172	172	172
query16	7802	284	273	273
query17	1828	537	534	534
query18	1933	279	285	279
query19	218	157	157	157
query20	95	84	89	84
query21	199	128	136	128
query22	4143	4030	3930	3930
query23	33713	32945	32981	32945
query24	12105	2778	2877	2778
query25	675	371	383	371
query26	1797	162	163	162
query27	2996	327	321	321
query28	7577	2071	2095	2071
query29	1124	609	603	603
query30	303	171	173	171
query31	978	758	736	736
query32	88	50	54	50
query33	769	276	296	276
query34	986	481	469	469
query35	740	604	577	577
query36	1055	901	910	901
query37	281	71	71	71
query38	2899	2760	2755	2755
query39	863	793	778	778
query40	273	140	120	120
query41	46	46	42	42
query42	100	96	93	93
query43	599	526	551	526
query44	1199	708	735	708
query45	179	160	164	160
query46	1083	730	702	702
query47	1832	1750	1782	1750
query48	367	296	286	286
query49	1183	374	391	374
query50	774	392	380	380
query51	6815	6750	6766	6750
query52	96	86	88	86
query53	345	290	287	287
query54	975	434	425	425
query55	75	74	71	71
query56	264	239	238	238
query57	1119	1073	1013	1013
query58	237	206	206	206
query59	3291	3266	3030	3030
query60	271	257	247	247
query61	95	90	89	89
query62	623	469	460	460
query63	308	280	281	280
query64	9741	2252	1755	1755
query65	3190	3098	3109	3098
query66	1371	330	331	330
query67	15265	14836	14798	14798
query68	4966	532	544	532
query69	477	266	270	266
query70	1148	1141	1128	1128
query71	451	266	315	266
query72	7696	5444	2753	2753
query73	742	320	318	318
query74	6040	5606	5622	5606
query75	3761	2601	2593	2593
query76	3599	942	962	942
query77	625	263	255	255
query78	10384	9824	9810	9810
query79	2282	538	528	528
query80	1252	451	439	439
query81	529	258	249	249
query82	1046	95	99	95
query83	282	179	173	173
query84	240	93	89	89
query85	1567	335	271	271
query86	484	292	298	292
query87	3288	3116	3092	3092
query88	4008	2426	2424	2424
query89	490	411	385	385
query90	1993	188	191	188
query91	130	99	98	98
query92	61	48	49	48
query93	2172	520	518	518
query94	1217	186	184	184
query95	392	310	314	310
query96	594	268	267	267
query97	3166	3058	3035	3035
query98	244	229	215	215
query99	1192	835	853	835
Total cold run time: 278575 ms
Total hot run time: 169486 ms

doris-robot · 2024-05-23T10:27:56Z

ClickBench: Total hot run time: 30.72 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6bf64202255799eff7611c4f278ee8cc148aaafe, data reload: false
query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.24	0.06	0.06
query4	1.66	0.09	0.10
query5	0.51	0.50	0.51
query6	1.13	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.53	0.48	0.49
query10	0.57	0.55	0.53
query11	0.15	0.11	0.12
query12	0.14	0.12	0.11
query13	0.59	0.59	0.62
query14	0.80	0.76	0.78
query15	0.83	0.81	0.81
query16	0.37	0.36	0.37
query17	0.98	0.95	0.93
query18	0.22	0.26	0.22
query19	1.74	1.70	1.76
query20	0.02	0.01	0.01
query21	15.52	0.67	0.66
query22	4.80	6.38	2.15
query23	18.23	1.38	1.30
query24	1.73	0.23	0.20
query25	0.14	0.08	0.08
query26	0.27	0.17	0.17
query27	0.08	0.08	0.07
query28	13.50	1.00	0.99
query29	13.23	3.35	3.25
query30	0.26	0.06	0.05
query31	2.86	0.40	0.40
query32	3.26	0.47	0.48
query33	2.93	2.93	2.91
query34	17.14	4.41	4.50
query35	4.50	4.48	4.52
query36	0.65	0.45	0.46
query37	0.17	0.17	0.16
query38	0.15	0.15	0.14
query39	0.05	0.04	0.03
query40	0.17	0.13	0.14
query41	0.10	0.04	0.04
query42	0.06	0.04	0.05
query43	0.04	0.03	0.04
Total cold run time: 110.51 s
Total hot run time: 30.72 s

starocean999 · 2024-05-24T00:44:34Z

run buildall

doris-robot · 2024-05-24T01:09:50Z

TPC-H: Total hot run time: 40581 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a788620a7bf7ec1cb96f1f3263b8495914ff2de4, data reload: false
------ Round 1 ----------------------------------
q1	18149	4454	4411	4411
q2	2517	197	215	197
q3	11071	1175	1163	1163
q4	10649	850	733	733
q5	7575	2693	2688	2688
q6	219	130	134	130
q7	959	619	600	600
q8	9617	2105	2067	2067
q9	8846	6522	6480	6480
q10	8872	3720	3691	3691
q11	470	236	231	231
q12	438	213	214	213
q13	18836	2950	2966	2950
q14	260	224	225	224
q15	510	480	469	469
q16	527	381	381	381
q17	963	654	705	654
q18	8089	7404	7432	7404
q19	6146	1572	1493	1493
q20	649	299	310	299
q21	4886	3831	3857	3831
q22	339	282	272	272
Total cold run time: 120587 ms
Total hot run time: 40581 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4380	4236	4225	4225
q2	363	262	249	249
q3	2933	2793	2686	2686
q4	1847	1609	1567	1567
q5	5239	5279	5268	5268
q6	208	122	123	122
q7	2086	1713	1724	1713
q8	3168	3303	3293	3293
q9	8319	8275	8342	8275
q10	3851	3709	3680	3680
q11	578	494	493	493
q12	781	610	608	608
q13	16445	2971	3013	2971
q14	300	259	282	259
q15	509	476	467	467
q16	463	441	422	422
q17	1763	1458	1451	1451
q18	7569	7441	7448	7441
q19	1687	1562	1598	1562
q20	1963	1768	1812	1768
q21	4919	4724	4679	4679
q22	533	485	487	485
Total cold run time: 69904 ms
Total hot run time: 53684 ms

doris-robot · 2024-05-24T01:20:45Z

TPC-DS: Total hot run time: 169240 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a788620a7bf7ec1cb96f1f3263b8495914ff2de4, data reload: false
query1	911	375	361	361
query2	6441	2508	2359	2359
query3	6662	206	208	206
query4	19872	17060	17351	17060
query5	4183	425	422	422
query6	260	176	166	166
query7	4593	297	293	293
query8	237	191	187	187
query9	8450	2359	2371	2359
query10	456	305	264	264
query11	10731	10112	10077	10077
query12	134	100	86	86
query13	1635	363	368	363
query14	9296	7739	6806	6806
query15	213	180	174	174
query16	7793	261	254	254
query17	1855	527	530	527
query18	1946	270	279	270
query19	200	167	166	166
query20	93	90	87	87
query21	197	129	127	127
query22	4203	4037	3885	3885
query23	33966	33018	32981	32981
query24	11981	2850	2798	2798
query25	663	357	391	357
query26	1811	159	155	155
query27	3062	324	318	318
query28	7596	2034	2017	2017
query29	1149	610	607	607
query30	287	172	173	172
query31	975	760	760	760
query32	81	54	55	54
query33	760	273	263	263
query34	1053	494	487	487
query35	734	615	597	597
query36	1064	928	916	916
query37	281	72	76	72
query38	2904	2820	2729	2729
query39	911	808	797	797
query40	280	132	138	132
query41	80	44	42	42
query42	101	99	99	99
query43	604	556	584	556
query44	1244	719	734	719
query45	179	167	165	165
query46	1071	734	735	734
query47	1831	1746	1761	1746
query48	383	288	287	287
query49	1185	395	387	387
query50	763	407	391	391
query51	6895	6873	6751	6751
query52	108	90	105	90
query53	351	291	290	290
query54	955	430	419	419
query55	75	74	77	74
query56	266	246	268	246
query57	1152	1039	1016	1016
query58	258	215	215	215
query59	3529	3049	3283	3049
query60	291	266	254	254
query61	92	87	87	87
query62	656	435	458	435
query63	314	299	294	294
query64	9789	2221	1795	1795
query65	3178	3066	3105	3066
query66	1385	341	320	320
query67	15288	14744	14777	14744
query68	4531	545	542	542
query69	446	267	281	267
query70	1134	1138	1168	1138
query71	393	272	277	272
query72	7611	5493	2696	2696
query73	713	326	320	320
query74	6117	5634	5553	5553
query75	3386	2655	2634	2634
query76	2604	995	970	970
query77	442	275	279	275
query78	10161	9874	9900	9874
query79	2469	510	509	509
query80	1069	460	450	450
query81	527	253	254	253
query82	950	99	101	99
query83	257	184	181	181
query84	243	93	89	89
query85	1331	337	326	326
query86	440	310	302	302
query87	3266	3160	3100	3100
query88	4254	2353	2335	2335
query89	485	414	395	395
query90	1970	193	189	189
query91	135	106	107	106
query92	64	49	50	49
query93	1689	514	496	496
query94	1286	198	192	192
query95	419	323	318	318
query96	595	265	264	264
query97	3170	3023	3000	3000
query98	239	221	220	220
query99	1148	844	866	844
Total cold run time: 275486 ms
Total hot run time: 169240 ms

doris-robot · 2024-05-24T01:26:16Z

ClickBench: Total hot run time: 30.38 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a788620a7bf7ec1cb96f1f3263b8495914ff2de4, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.04	0.05
query3	0.23	0.05	0.04
query4	1.68	0.07	0.07
query5	0.49	0.49	0.50
query6	1.13	0.72	0.73
query7	0.02	0.01	0.01
query8	0.06	0.04	0.04
query9	0.55	0.49	0.47
query10	0.53	0.56	0.54
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.59	0.60	0.59
query14	0.77	0.79	0.78
query15	0.84	0.82	0.81
query16	0.37	0.37	0.37
query17	0.98	0.94	0.94
query18	0.20	0.26	0.26
query19	1.77	1.74	1.69
query20	0.02	0.01	0.01
query21	15.71	0.67	0.66
query22	4.58	7.24	1.82
query23	18.31	1.32	1.22
query24	1.79	0.25	0.23
query25	0.16	0.08	0.07
query26	0.26	0.17	0.17
query27	0.08	0.08	0.08
query28	13.29	1.02	1.00
query29	13.10	3.25	3.25
query30	0.26	0.06	0.06
query31	2.86	0.39	0.39
query32	3.31	0.48	0.47
query33	2.87	2.91	2.91
query34	17.25	4.46	4.41
query35	4.49	4.46	4.51
query36	0.64	0.45	0.46
query37	0.18	0.16	0.15
query38	0.15	0.15	0.14
query39	0.04	0.04	0.03
query40	0.16	0.14	0.14
query41	0.10	0.04	0.04
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.33 s
Total hot run time: 30.38 s

starocean999 · 2024-05-24T02:45:07Z

run buildall

github-actions · 2024-05-24T03:10:24Z

PR approved by at least one committer and no changes requested.

doris-robot · 2024-05-24T03:43:55Z

TPC-H: Total hot run time: 41160 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dc37fc688ee625d9982919218359f7ee299e4c9d, data reload: false
------ Round 1 ----------------------------------
q1	17612	4301	4290	4290
q2	2019	195	193	193
q3	10463	1267	1212	1212
q4	10195	748	853	748
q5	7457	2699	2647	2647
q6	222	140	138	138
q7	959	610	618	610
q8	9216	2134	2094	2094
q9	9197	6709	6743	6709
q10	9114	3922	3875	3875
q11	460	243	245	243
q12	488	227	232	227
q13	18372	3251	3228	3228
q14	265	227	231	227
q15	535	492	496	492
q16	517	406	403	403
q17	965	637	701	637
q18	8368	7875	7810	7810
q19	5493	1548	1495	1495
q20	651	313	320	313
q21	5156	3901	3283	3283
q22	354	286	290	286
Total cold run time: 118078 ms
Total hot run time: 41160 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4505	4398	4411	4398
q2	385	273	284	273
q3	3148	2946	2878	2878
q4	1939	1727	1678	1678
q5	5315	5457	5499	5457
q6	220	133	133	133
q7	2205	1859	1825	1825
q8	3219	3383	3400	3383
q9	8671	8643	8710	8643
q10	4116	3816	3703	3703
q11	585	462	480	462
q12	810	614	611	611
q13	15990	3164	3104	3104
q14	306	264	289	264
q15	523	493	493	493
q16	492	435	445	435
q17	1834	1540	1516	1516
q18	7960	7605	7400	7400
q19	1661	1573	1549	1549
q20	1967	1767	1792	1767
q21	4889	4679	4639	4639
q22	561	500	508	500
Total cold run time: 71301 ms
Total hot run time: 55111 ms

doris-robot · 2024-05-24T03:54:31Z

TPC-DS: Total hot run time: 169796 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dc37fc688ee625d9982919218359f7ee299e4c9d, data reload: false
query1	917	384	360	360
query2	6435	2431	2455	2431
query3	6684	220	221	220
query4	19552	17456	17286	17286
query5	4101	422	426	422
query6	251	157	156	156
query7	4592	299	290	290
query8	241	195	186	186
query9	8485	2365	2351	2351
query10	454	291	267	267
query11	10581	10177	10166	10166
query12	143	95	91	91
query13	1649	368	369	368
query14	10146	7133	7731	7133
query15	231	176	174	174
query16	7906	283	278	278
query17	1684	553	533	533
query18	1895	284	279	279
query19	209	200	157	157
query20	95	85	85	85
query21	203	131	130	130
query22	4137	4031	3927	3927
query23	33528	33010	33030	33010
query24	6872	2936	2855	2855
query25	565	361	373	361
query26	698	167	164	164
query27	1966	331	320	320
query28	3800	2023	2021	2021
query29	862	617	627	617
query30	261	170	178	170
query31	974	742	743	742
query32	91	52	55	52
query33	521	267	262	262
query34	851	482	475	475
query35	718	600	584	584
query36	1026	917	897	897
query37	104	74	77	74
query38	2908	2793	2793	2793
query39	832	784	760	760
query40	202	126	130	126
query41	46	44	42	42
query42	104	97	97	97
query43	552	565	552	552
query44	1078	714	736	714
query45	185	193	162	162
query46	1070	704	739	704
query47	1844	1753	1776	1753
query48	366	297	294	294
query49	811	395	401	395
query50	767	376	391	376
query51	6889	6763	6830	6763
query52	100	93	88	88
query53	356	288	289	288
query54	556	454	425	425
query55	76	75	75	75
query56	266	245	254	245
query57	1126	1051	1014	1014
query58	259	220	203	203
query59	3403	3315	3161	3161
query60	297	264	253	253
query61	93	88	87	87
query62	577	470	447	447
query63	313	286	294	286
query64	8495	2223	1781	1781
query65	3131	3088	3130	3088
query66	771	327	332	327
query67	15286	14844	14802	14802
query68	4566	544	549	544
query69	440	275	274	274
query70	1177	1128	1161	1128
query71	396	275	273	273
query72	7668	2722	2605	2605
query73	720	324	321	321
query74	6046	5571	5564	5564
query75	3332	2625	2664	2625
query76	2253	1054	944	944
query77	401	280	314	280
query78	10278	9809	9699	9699
query79	2534	525	517	517
query80	967	448	437	437
query81	537	248	243	243
query82	759	97	96	96
query83	254	171	167	167
query84	249	85	86	85
query85	1251	273	269	269
query86	504	292	290	290
query87	3274	3083	3140	3083
query88	4187	2350	2321	2321
query89	490	404	399	399
query90	2063	190	241	190
query91	128	98	97	97
query92	68	48	48	48
query93	1863	509	504	504
query94	1130	198	186	186
query95	410	308	312	308
query96	580	271	264	264
query97	3215	3002	3022	3002
query98	242	221	210	210
query99	1146	828	860	828
Total cold run time: 259315 ms
Total hot run time: 169796 ms

doris-robot · 2024-05-24T04:00:01Z

ClickBench: Total hot run time: 29.98 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dc37fc688ee625d9982919218359f7ee299e4c9d, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.08	0.08
query5	0.50	0.50	0.49
query6	1.13	0.73	0.72
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.54	0.48	0.48
query10	0.53	0.56	0.55
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.58	0.60
query14	0.77	0.79	0.78
query15	0.84	0.81	0.80
query16	0.37	0.38	0.38
query17	1.02	1.03	0.97
query18	0.22	0.25	0.23
query19	1.81	1.77	1.76
query20	0.02	0.01	0.01
query21	15.56	0.67	0.64
query22	4.08	7.98	1.37
query23	18.25	1.35	1.30
query24	1.82	0.21	0.22
query25	0.16	0.08	0.09
query26	0.26	0.16	0.17
query27	0.09	0.08	0.08
query28	13.39	1.01	0.99
query29	13.82	3.25	3.22
query30	0.24	0.06	0.05
query31	2.88	0.39	0.37
query32	3.29	0.47	0.47
query33	2.95	3.04	2.89
query34	17.09	4.45	4.43
query35	4.52	4.47	4.66
query36	0.64	0.47	0.45
query37	0.17	0.15	0.15
query38	0.16	0.14	0.14
query39	0.04	0.03	0.03
query40	0.16	0.13	0.14
query41	0.08	0.04	0.05
query42	0.06	0.04	0.04
query43	0.04	0.04	0.03
Total cold run time: 110.48 s
Total hot run time: 29.98 s

…hildren (#35074) The output slot's nullable info is not correctly calculated in union node. Because old code only get correct result if union node has children. But the union node may have no children but only have constantExprList. So in that case, we should calculate output's nullable info byboth children and constantExprList.

…ildren #35074 (#35385)

…hildren (#35074) The output slot's nullable info is not correctly calculated in union node. Because old code only get correct result if union node has children. But the union node may have no children but only have constantExprList. So in that case, we should calculate output's nullable info byboth children and constantExprList.

…hildren (apache#35074) The output slot's nullable info is not correctly calculated in union node. Because old code only get correct result if union node has children. But the union node may have no children but only have constantExprList. So in that case, we should calculate output's nullable info byboth children and constantExprList.

…ildren apache#35074 (apache#35385)

…hildren (apache#35074) The output slot's nullable info is not correctly calculated in union node. Because old code only get correct result if union node has children. But the union node may have no children but only have constantExprList. So in that case, we should calculate output's nullable info byboth children and constantExprList.

starocean999 force-pushed the nereids_1020 branch from 689bc3b to d9a04c9Compare May 21, 2024 10:55

starocean999 marked this pull request as ready for review May 22, 2024 01:30

morrySnow reviewed May 22, 2024
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AdjustNullable.java

morrySnow added dev/2.1.x dev/2.0.x labels May 22, 2024

starocean999 force-pushed the nereids_1020 branch from d9a04c9 to 3067d1fCompare May 23, 2024 04:02

morrySnow previously approved these changes May 23, 2024
View reviewed changes

morrySnow added the p0_b label May 23, 2024

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 23, 2024

github-actionsBot added the reviewed label May 23, 2024

englefly reviewed May 23, 2024
View reviewed changes

starocean999 dismissed morrySnow’s stale review via 6bf6420May 23, 2024 09:52

starocean999 force-pushed the nereids_1020 branch from 3067d1f to 6bf6420Compare May 23, 2024 09:52

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label May 23, 2024

update code
a788620

starocean999 force-pushed the nereids_1020 branch from 6bf6420 to a788620Compare May 24, 2024 00:44

remove unused code
dc37fc6

starocean999 mentioned this pull request May 24, 2024
[fix](nereids)AdjustNullable rule should handle union node with no children #35323
Merged

morrySnow approved these changes May 24, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 24, 2024

englefly approved these changes May 24, 2024
View reviewed changes

morrySnow merged commit 50742d6 into apache:masterMay 24, 2024

starocean999 mentioned this pull request May 24, 2024
[fix](nereids)AdjustNullable rule should handle union node with no children #35385
Merged

xiaokang pushed a commit that referenced this pull request May 26, 2024
[fix](nereids)AdjustNullable rule should handle union node with no ch…
80bb393
…ildren #35074 (#35385)

xiaokang added dev/2.0.11-merged and removed dev/2.0.x labels May 26, 2024

morrySnow added dev/2.1.4-merged and removed dev/2.1.x labels May 27, 2024

morningman mentioned this pull request Jun 22, 2024
Release Notes 2.1.4 #35752
Closed

dataroaring added the dev/3.0.0-merged label Aug 5, 2024

mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
[fix](nereids)AdjustNullable rule should handle union node with no ch…
170bbb0
…ildren apache#35074 (apache#35385)

Uh oh!

Conversation

starocean999 commented May 20, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Further comments

Uh oh!

doris-robot commented May 20, 2024

Uh oh!

starocean999 commented May 20, 2024

Uh oh!

starocean999 commented May 21, 2024

Uh oh!

doris-robot commented May 21, 2024

Uh oh!

doris-robot commented May 21, 2024

Uh oh!

doris-robot commented May 21, 2024

Uh oh!

Uh oh!

starocean999 commented May 23, 2024

Uh oh!

github-actionsBot commented May 23, 2024

Uh oh!

github-actionsBot commented May 23, 2024

Uh oh!

doris-robot commented May 23, 2024

Uh oh!

doris-robot commented May 23, 2024

Uh oh!

doris-robot commented May 23, 2024

Uh oh!

engleflyMay 23, 2024

Choose a reason for hiding this comment

Uh oh!

engleflyMay 23, 2024

Choose a reason for hiding this comment

Uh oh!

starocean999 commented May 23, 2024

Uh oh!

doris-robot commented May 23, 2024

Uh oh!

doris-robot commented May 23, 2024

Uh oh!

doris-robot commented May 23, 2024

Uh oh!

starocean999 commented May 24, 2024

Uh oh!

doris-robot commented May 24, 2024

Uh oh!

doris-robot commented May 24, 2024

Uh oh!

doris-robot commented May 24, 2024

Uh oh!

starocean999 commented May 24, 2024

Uh oh!

github-actionsBot commented May 24, 2024

Uh oh!

doris-robot commented May 24, 2024

Uh oh!

doris-robot commented May 24, 2024

Uh oh!

doris-robot commented May 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

starocean999 commented May 20, 2024•
edited
Loading