Uh oh!
There was an error while loading. Please reload this page.
[fix](tvf) Partition columns in CTAS need to be compatible with the STRING type of external tables/TVF - #35489
Merged
Merged
Conversation
doris-robot
commented
May 28, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
BePPPower
commented
May 28, 2024
ContributorAuthor
run buildall |
1 similar comment
BePPPower
commented
May 28, 2024
ContributorAuthor
run buildall |
doris-robot
commented
May 28, 2024
TPC-H: Total hot run time: 41484 ms |
doris-robot
commented
May 28, 2024
TPC-DS: Total hot run time: 172657 ms |
doris-robot
commented
May 28, 2024
ClickBench: Total hot run time: 29.65 s |
BePPPower
commented
May 29, 2024
ContributorAuthor
run buildall |
doris-robot
commented
May 29, 2024
TPC-H: Total hot run time: 41732 ms |
doris-robot
commented
May 29, 2024
TPC-DS: Total hot run time: 171530 ms |
doris-robot
commented
May 29, 2024
ClickBench: Total hot run time: 30.96 s |
BePPPower
commented
May 29, 2024
ContributorAuthor
run buildall |
doris-robot
commented
May 29, 2024
TPC-H: Total hot run time: 40241 ms |
doris-robot
commented
May 29, 2024
TPC-DS: Total hot run time: 168917 ms |
doris-robot
commented
May 29, 2024
ClickBench: Total hot run time: 30.42 s |
BePPPower
commented
May 29, 2024
ContributorAuthor
run buildall |
doris-robot
commented
May 29, 2024
TPC-H: Total hot run time: 40639 ms |
doris-robot
commented
May 29, 2024
TPC-DS: Total hot run time: 167949 ms |
doris-robot
commented
May 29, 2024
ClickBench: Total hot run time: 30.2 s |
BePPPower
commented
May 30, 2024
ContributorAuthor
run p0 external |
Uh oh!
There was an error while loading. Please reload this page.
BePPPower
commented
May 30, 2024
ContributorAuthor
run buildall |
1 similar comment
BePPPower
commented
May 31, 2024
ContributorAuthor
run buildall |
doris-robot
commented
May 31, 2024
TPC-H: Total hot run time: 41406 ms |
doris-robot
commented
May 31, 2024
TPC-DS: Total hot run time: 168882 ms |
doris-robot
commented
May 31, 2024
ClickBench: Total hot run time: 30.81 s |
Contributor
PR approved by at least one committer and no changes requested. |
doris-robot
commented
Jun 25, 2024
ClickBench: Total hot run time: 30.7 s |
BePPPower
commented
Jun 25, 2024
ContributorAuthor
run feut |
morningman
previously approved these changes
Jun 25, 2024
Uh oh!
There was an error while loading. Please reload this page.
BePPPower
commented
Jun 26, 2024
ContributorAuthor
run buildall |
doris-robot
commented
Jun 26, 2024
TPC-H: Total hot run time: 39907 ms |
doris-robot
commented
Jun 26, 2024
TPC-DS: Total hot run time: 173249 ms |
doris-robot
commented
Jun 26, 2024
ClickBench: Total hot run time: 30.54 s |
wuwenchi
approved these changes
Jun 26, 2024
BePPPower
commented
Jun 26, 2024
ContributorAuthor
run p0 |
1 similar comment
BePPPower
commented
Jun 26, 2024
ContributorAuthor
run p0 |
BePPPower
commented
Jun 27, 2024
ContributorAuthor
run cloud_p1 |
dataroaring pushed a commit
that referenced
this pull request
Jun 28, 2024
…TRING type of external tables/TVF (#35489) Partition columns in CTAS need to be compatible with the STRING type of external tables/TVF 1. For TVF queries with partition columns in the file path, map these partition columns to the `VARCHAR(65533)` type. (Previously, they were of `STRING` type.) 3. If you use the `STRING` type of an external table as a partition column, CTAS will automatically convert it to `VARCHAR(65535)` type."
BePPPower added a commit
to BePPPower/doris
that referenced
this pull request
Jul 2, 2024
…TRING type of external tables/TVF (apache#35489) Partition columns in CTAS need to be compatible with the STRING type of external tables/TVF 1. For TVF queries with partition columns in the file path, map these partition columns to the `VARCHAR(65533)` type. (Previously, they were of `STRING` type.) 3. If you use the `STRING` type of an external table as a partition column, CTAS will automatically convert it to `VARCHAR(65535)` type."
morningman added a commit
that referenced
this pull request
Aug 23, 2024
) Fix 2 bugs: 1. introduced from #35489 When the target table is unpartitioned with text type column from external table, NPE will be thrown. Only happen when using old planner. The new planner works well. 2. If first column is varchar type, the new planner will change it to string type and then failed because first column can not be string type.
morningman added a commit
to morningman/doris
that referenced
this pull request
Aug 23, 2024
…che#39744) Fix 2 bugs: 1. introduced from apache#35489 When the target table is unpartitioned with text type column from external table, NPE will be thrown. Only happen when using old planner. The new planner works well. 2. If first column is varchar type, the new planner will change it to string type and then failed because first column can not be string type.
dataroaring pushed a commit
that referenced
this pull request
Aug 26, 2024
) Fix 2 bugs: 1. introduced from #35489 When the target table is unpartitioned with text type column from external table, NPE will be thrown. Only happen when using old planner. The new planner works well. 2. If first column is varchar type, the new planner will change it to string type and then failed because first column can not be string type.
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…TRING type of external tables/TVF (apache#35489) Partition columns in CTAS need to be compatible with the STRING type of external tables/TVF 1. For TVF queries with partition columns in the file path, map these partition columns to the `VARCHAR(65533)` type. (Previously, they were of `STRING` type.) 3. If you use the `STRING` type of an external table as a partition column, CTAS will automatically convert it to `VARCHAR(65535)` type."
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…che#39744) Fix 2 bugs: 1. introduced from apache#35489 When the target table is unpartitioned with text type column from external table, NPE will be thrown. Only happen when using old planner. The new planner works well. 2. If first column is varchar type, the new planner will change it to string type and then failed because first column can not be string type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Partition columns in CTAS need to be compatible with the STRING type of external tables/TVF
For TVF queries with partition columns in the file path, map these partition columns to the
VARCHAR(65533)type. (Previously, they were ofSTRINGtype.)If you use the
STRINGtype of an external table as a partition column, CTAS will automatically convert it toVARCHAR(65535)type."Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...