[fix](bit shift) fix undefined behavior of bit shift functions. by RoanHeNaN · Pull Request #35723 · apache/doris

RoanHeNaN · 2024-05-31T09:02:38Z

If the value of rhs is negative or is not less than the number of bits in lhs, the behavior is undefined.

According to https://en.cppreference.com/w/cpp/language/operator_arithmetic, bit_shift_left/right(value, 64) has undefined behavior.

doris-robot · 2024-05-31T09:02:43Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions · 2024-05-31T09:08:35Z

clang-tidy review says "All clean, LGTM! 👍"

RoanHeNaN · 2024-05-31T09:48:31Z

run buildall

github-actions · 2024-05-31T09:51:54Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-31T09:54:03Z

clang-tidy review says "All clean, LGTM! 👍"

RoanHeNaN · 2024-05-31T09:57:11Z

run buildall

github-actions · 2024-05-31T10:03:18Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-31T10:21:12Z

TeamCity be ut coverage result:
Function Coverage: 36.29% (9232/25442)
Line Coverage: 27.63% (75708/273965)
Region Coverage: 26.85% (39194/145989)
Branch Coverage: 23.60% (19892/84280)
Coverage Report: http://coverage.selectdb-in.cc/coverage/02e5c526954029e1a36b0b9e4b7ee95fb04189cb_02e5c526954029e1a36b0b9e4b7ee95fb04189cb/report/index.html

doris-robot · 2024-05-31T10:33:50Z

TPC-H: Total hot run time: 41539 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 02e5c526954029e1a36b0b9e4b7ee95fb04189cb, data reload: false
------ Round 1 ----------------------------------
q1	17606	4423	4276	4276
q2	2023	192	202	192
q3	10470	1157	1104	1104
q4	10206	837	789	789
q5	7474	2678	2627	2627
q6	232	132	135	132
q7	938	627	616	616
q8	9225	2108	2079	2079
q9	9343	6689	6714	6689
q10	9371	3927	3871	3871
q11	449	237	245	237
q12	451	222	227	222
q13	17541	3180	3162	3162
q14	259	218	208	208
q15	510	471	466	466
q16	523	402	393	393
q17	998	668	633	633
q18	8391	7759	7870	7759
q19	5305	1488	1483	1483
q20	646	329	325	325
q21	5217	4068	3952	3952
q22	388	324	326	324
Total cold run time: 117566 ms
Total hot run time: 41539 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4644	4563	4473	4473
q2	366	269	266	266
q3	3141	2974	2882	2882
q4	1878	1604	1628	1604
q5	5503	5570	5554	5554
q6	219	125	124	124
q7	2135	1864	1803	1803
q8	3263	3386	3352	3352
q9	8616	8743	8781	8743
q10	4132	3864	3923	3864
q11	612	531	511	511
q12	844	676	662	662
q13	16091	3401	3421	3401
q14	327	306	340	306
q15	559	527	489	489
q16	492	454	448	448
q17	1837	1515	1502	1502
q18	8987	7891	7581	7581
q19	1631	1563	1433	1433
q20	2017	1803	1761	1761
q21	12484	4579	4674	4579
q22	578	511	498	498
Total cold run time: 80356 ms
Total hot run time: 55836 ms

RoanHeNaN · 2024-05-31T11:14:21Z

run buildall

github-actions · 2024-05-31T11:20:05Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-31T11:35:56Z

TeamCity be ut coverage result:
Function Coverage: 36.29% (9232/25442)
Line Coverage: 27.63% (75704/273965)
Region Coverage: 26.85% (39204/145989)
Branch Coverage: 23.61% (19897/84280)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b649f1481fb466b6eafa54a290c47d2b88bce139_b649f1481fb466b6eafa54a290c47d2b88bce139/report/index.html

doris-robot · 2024-05-31T11:36:02Z

TPC-H: Total hot run time: 40169 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b649f1481fb466b6eafa54a290c47d2b88bce139, data reload: false
------ Round 1 ----------------------------------
q1	18274	4556	4429	4429
q2	2588	200	209	200
q3	11785	1114	1136	1114
q4	10435	801	838	801
q5	7846	2711	2675	2675
q6	227	136	138	136
q7	957	614	601	601
q8	9230	2031	2064	2031
q9	8923	6466	6507	6466
q10	8868	3696	3735	3696
q11	445	253	240	240
q12	461	223	217	217
q13	17778	2993	2970	2970
q14	265	228	209	209
q15	514	482	468	468
q16	542	389	382	382
q17	959	676	755	676
q18	8123	7614	7403	7403
q19	7181	1603	1506	1506
q20	659	331	320	320
q21	4907	3379	3307	3307
q22	375	322	324	322
Total cold run time: 121342 ms
Total hot run time: 40169 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4379	4262	4270	4262
q2	363	286	270	270
q3	2999	2807	2768	2768
q4	1884	1593	1576	1576
q5	5235	5273	5290	5273
q6	213	126	125	125
q7	2126	1693	1755	1693
q8	3189	3334	3318	3318
q9	8305	8321	8316	8316
q10	3836	3673	3642	3642
q11	581	488	484	484
q12	786	600	611	600
q13	16413	2923	2963	2923
q14	295	277	255	255
q15	512	485	480	480
q16	466	404	414	404
q17	1766	1501	1495	1495
q18	7610	7572	7445	7445
q19	1699	1579	1486	1486
q20	1952	1793	1798	1793
q21	4746	4715	4669	4669
q22	606	541	533	533
Total cold run time: 69961 ms
Total hot run time: 53810 ms

doris-robot · 2024-05-31T11:46:59Z

TPC-DS: Total hot run time: 172164 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b649f1481fb466b6eafa54a290c47d2b88bce139, data reload: false
query1	944	376	366	366
query2	6464	2409	2345	2345
query3	6651	206	210	206
query4	19355	17421	17465	17421
query5	4238	416	423	416
query6	261	154	159	154
query7	4582	299	289	289
query8	317	304	287	287
query9	8531	2459	2419	2419
query10	458	278	267	267
query11	10532	10155	10127	10127
query12	136	92	93	92
query13	1659	372	383	372
query14	8589	7586	6860	6860
query15	222	185	183	183
query16	7813	255	259	255
query17	1873	522	503	503
query18	1954	269	268	268
query19	198	161	155	155
query20	88	86	85	85
query21	200	146	126	126
query22	4163	3990	3963	3963
query23	33652	32840	32902	32840
query24	11666	2839	2845	2839
query25	675	362	378	362
query26	1840	150	151	150
query27	2986	322	329	322
query28	7711	2079	2092	2079
query29	1203	603	590	590
query30	300	146	153	146
query31	950	741	740	740
query32	92	54	55	54
query33	756	273	261	261
query34	1009	483	477	477
query35	726	603	593	593
query36	1081	918	942	918
query37	181	66	71	66
query38	2891	2774	2823	2774
query39	869	806	798	798
query40	284	128	119	119
query41	53	51	51	51
query42	101	97	98	97
query43	578	551	535	535
query44	1214	743	790	743
query45	183	169	173	169
query46	1094	727	702	702
query47	1863	1770	1801	1770
query48	369	301	300	300
query49	1211	370	385	370
query50	792	409	396	396
query51	6733	6624	6642	6624
query52	106	91	95	91
query53	356	286	287	286
query54	834	457	448	448
query55	77	74	75	74
query56	263	240	241	240
query57	1132	1039	1039	1039
query58	238	211	211	211
query59	3460	3169	3046	3046
query60	275	254	254	254
query61	92	85	87	85
query62	650	468	463	463
query63	313	289	289	289
query64	9753	2212	1785	1785
query65	3154	3081	3108	3081
query66	1380	333	326	326
query67	15124	14947	14713	14713
query68	4630	552	525	525
query69	438	264	266	264
query70	1181	1062	1176	1062
query71	402	273	275	273
query72	7452	5493	5697	5493
query73	724	336	324	324
query74	6134	5628	5606	5606
query75	3468	2651	2599	2599
query76	2937	987	952	952
query77	424	274	264	264
query78	10212	9797	9678	9678
query79	2316	524	513	513
query80	1268	432	490	432
query81	521	223	216	216
query82	658	89	91	89
query83	272	169	169	169
query84	242	85	86	85
query85	1842	264	261	261
query86	523	303	293	293
query87	3325	3133	3124	3124
query88	4165	2397	2397	2397
query89	479	404	378	378
query90	1991	186	190	186
query91	121	95	99	95
query92	69	49	50	49
query93	2310	527	503	503
query94	1254	185	181	181
query95	410	311	313	311
query96	599	275	267	267
query97	3184	3105	3034	3034
query98	256	229	222	222
query99	1211	868	844	844
Total cold run time: 274516 ms
Total hot run time: 172164 ms

doris-robot · 2024-05-31T11:52:27Z

ClickBench: Total hot run time: 30.09 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b649f1481fb466b6eafa54a290c47d2b88bce139, data reload: false
query1	0.04	0.04	0.02
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.52	0.47	0.48
query6	1.12	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.50	0.50
query10	0.55	0.55	0.53
query11	0.16	0.11	0.12
query12	0.14	0.12	0.11
query13	0.60	0.59	0.60
query14	0.79	0.76	0.78
query15	0.84	0.82	0.82
query16	0.37	0.36	0.37
query17	0.95	0.95	0.97
query18	0.20	0.25	0.24
query19	1.76	1.73	1.77
query20	0.02	0.01	0.01
query21	15.70	0.67	0.66
query22	4.12	7.73	1.59
query23	18.15	1.43	1.25
query24	1.34	0.40	0.21
query25	0.14	0.08	0.08
query26	0.27	0.16	0.16
query27	0.08	0.08	0.07
query28	13.35	1.01	0.99
query29	13.21	3.32	3.29
query30	0.24	0.07	0.06
query31	2.89	0.41	0.37
query32	3.24	0.48	0.47
query33	2.86	2.82	2.91
query34	17.13	4.42	4.39
query35	4.53	4.54	4.51
query36	0.65	0.46	0.46
query37	0.18	0.16	0.15
query38	0.15	0.15	0.14
query39	0.05	0.03	0.03
query40	0.16	0.15	0.14
query41	0.09	0.05	0.04
query42	0.06	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.29 s
Total hot run time: 30.09 s

github-actions · 2024-06-03T02:00:54Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-06-03T02:00:57Z

PR approved by anyone and no changes requested.

…he#35723) `If the value of rhs is negative or is not less than the number of bits in lhs, the behavior is undefined.`

FIX
60e8344

fix
49ee709

RoanHeNaN force-pushed the fix-ub-bitshift branch from 110d942 to 49ee709Compare May 31, 2024 09:46

FIX
ac69493

FORMAT
02e5c52

FIX
b649f14

RoanHeNaN marked this pull request as ready for review May 31, 2024 14:57

yiguolei approved these changes Jun 3, 2024
View reviewed changes

github-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 3, 2024

Mryange approved these changes Jun 3, 2024
View reviewed changes

jacktengg approved these changes Jun 3, 2024
View reviewed changes

HappenLee merged commit 539cad8 into apache:masterJun 3, 2024

RoanHeNaN deleted the fix-ub-bitshift branch June 3, 2024 16:51

seawinde pushed a commit to seawinde/doris that referenced this pull request Jun 5, 2024
[fix](bit shift) fix undefined behavior of bit shift functions. (apac…
7a9c835
…he#35723) `If the value of rhs is negative or is not less than the number of bits in lhs, the behavior is undefined.`

seawinde pushed a commit to seawinde/doris that referenced this pull request Jun 5, 2024
[fix](bit shift) fix undefined behavior of bit shift functions. (apac…
e763b8a
…he#35723) `If the value of rhs is negative or is not less than the number of bits in lhs, the behavior is undefined.`

dataroaring mentioned this pull request Aug 11, 2024
[fix](ub) fix some ub error #35769
Merged

dataroaring added the dev/3.0.0-merged label Aug 11, 2024

Uh oh!

Conversation

RoanHeNaN commented May 31, 2024

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

github-actionsBot commented May 31, 2024

Uh oh!

RoanHeNaN commented May 31, 2024

Uh oh!

github-actionsBot commented May 31, 2024

Uh oh!

github-actionsBot commented May 31, 2024

Uh oh!

RoanHeNaN commented May 31, 2024

Uh oh!

github-actionsBot commented May 31, 2024

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

RoanHeNaN commented May 31, 2024

Uh oh!

github-actionsBot commented May 31, 2024

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

doris-robot commented May 31, 2024

Uh oh!

github-actionsBot commented Jun 3, 2024

Uh oh!

github-actionsBot commented Jun 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants