Skip to content

[fix](Nereids) unix_timestamp compute signature and fold const is wrong - #35727

Merged
yiguolei merged 1 commit into
apache:masterfrom
morrySnow:fix_unix_timestamp
Jun 3, 2024
Merged

[fix](Nereids) unix_timestamp compute signature and fold const is wrong#35727
yiguolei merged 1 commit into
apache:masterfrom
morrySnow:fix_unix_timestamp

Conversation

@morrySnow

@morrySnowmorrySnow commented May 31, 2024

Copy link
Copy Markdown
Contributor
  1. compute signature should call super#computeSignature first
  2. fold const return type not changed after signature changed in [Enhancement](function) support unix_timestamp with float #26827

we already have p0 for this case, but our regression framework has bug
that it report success when compare decimal type if real result lose scale

@doris-robot

doris-robot commented May 31, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow

morrySnow commented May 31, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented May 31, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 41754 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4fe7a51ad87c3e7567ebe5717219cef53b0c14a3, data reload: false
------ Round 1 ----------------------------------
q1	17619	4446	4281	4281
q2	2034	198	201	198
q3	10446	1153	1108	1108
q4	10199	903	920	903
q5	7458	2684	2745	2684
q6	222	136	144	136
q7	969	627	625	625
q8	9264	2157	2137	2137
q9	9407	6772	6729	6729
q10	10123	3969	3877	3877
q11	444	245	250	245
q12	444	245	251	245
q13	17304	3273	3251	3251
q14	272	228	229	228
q15	533	493	470	470
q16	524	395	378	378
q17	971	661	665	661
q18	8498	8003	8085	8003
q19	8007	1640	1596	1596
q20	677	336	354	336
q21	5425	4212	3321	3321
q22	414	351	342	342
Total cold run time: 121254 ms
Total hot run time: 41754 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4766	4530	4576	4530
q2	406	273	276	273
q3	3308	3108	3065	3065
q4	2055	1756	1669	1669
q5	5360	5587	5535	5535
q6	224	132	131	131
q7	2195	1839	1868	1839
q8	3270	3388	3400	3388
q9	8573	8577	8662	8577
q10	4104	3922	3659	3659
q11	578	487	499	487
q12	769	619	654	619
q13	17229	3138	3113	3113
q14	304	261	262	261
q15	529	493	487	487
q16	499	441	457	441
q17	1816	1574	1483	1483
q18	7949	7595	7298	7298
q19	1664	1591	1441	1441
q20	1977	1811	1776	1776
q21	9562	4777	4809	4777
q22	603	523	529	523
Total cold run time: 77740 ms
Total hot run time: 55372 ms

@doris-robot

doris-robot commented May 31, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 171730 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4fe7a51ad87c3e7567ebe5717219cef53b0c14a3, data reload: false
query1	923	381	378	378
query2	6450	2417	2283	2283
query3	6634	205	204	204
query4	22043	17362	17426	17362
query5	4102	416	417	416
query6	246	158	153	153
query7	4574	301	298	298
query8	300	286	282	282
query9	8582	2436	2401	2401
query10	455	287	285	285
query11	10578	10058	10044	10044
query12	140	90	87	87
query13	1635	362	375	362
query14	10205	6740	7644	6740
query15	239	190	190	190
query16	7761	268	257	257
query17	1713	536	543	536
query18	1954	276	267	267
query19	196	156	156	156
query20	95	90	84	84
query21	201	135	132	132
query22	4192	3939	3830	3830
query23	33629	33128	33177	33128
query24	11051	2837	2818	2818
query25	604	360	355	355
query26	1155	154	164	154
query27	2396	317	333	317
query28	6774	2086	2104	2086
query29	926	610	624	610
query30	241	148	153	148
query31	972	762	730	730
query32	92	51	55	51
query33	753	272	259	259
query34	966	481	491	481
query35	732	621	603	603
query36	1067	907	919	907
query37	132	64	70	64
query38	2903	2811	2773	2773
query39	846	782	802	782
query40	203	123	122	122
query41	52	52	46	46
query42	105	104	100	100
query43	582	566	559	559
query44	1200	742	773	742
query45	186	164	175	164
query46	1078	729	733	729
query47	1876	1779	1801	1779
query48	381	301	334	301
query49	864	390	394	390
query50	779	395	403	395
query51	6766	7112	6670	6670
query52	101	92	92	92
query53	352	284	300	284
query54	981	446	426	426
query55	75	74	74	74
query56	284	246	250	246
query57	1119	1046	1062	1046
query58	250	211	208	208
query59	3462	3195	3049	3049
query60	274	272	256	256
query61	97	143	89	89
query62	636	464	447	447
query63	314	297	290	290
query64	8748	2201	1729	1729
query65	3174	3096	3121	3096
query66	864	324	326	324
query67	15261	14912	14699	14699
query68	4584	545	534	534
query69	451	262	262	262
query70	1166	1074	1129	1074
query71	414	273	271	271
query72	7500	5801	5349	5349
query73	768	324	325	324
query74	6006	5694	5590	5590
query75	3324	2661	2629	2629
query76	2535	908	988	908
query77	559	265	261	261
query78	10236	9811	9603	9603
query79	1998	531	513	513
query80	1029	447	439	439
query81	508	232	219	219
query82	660	93	92	92
query83	249	173	171	171
query84	246	88	85	85
query85	1773	279	269	269
query86	473	307	272	272
query87	3322	3145	3075	3075
query88	4054	2382	2402	2382
query89	476	377	390	377
query90	2045	194	194	194
query91	127	97	103	97
query92	58	48	50	48
query93	2332	518	500	500
query94	1270	193	188	188
query95	395	305	315	305
query96	595	280	273	273
query97	3158	2994	3042	2994
query98	244	232	218	218
query99	1179	858	849	849
Total cold run time: 272255 ms
Total hot run time: 171730 ms

@doris-robot

doris-robot commented May 31, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.53 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4fe7a51ad87c3e7567ebe5717219cef53b0c14a3, data reload: false
query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.22	0.06	0.07
query4	1.65	0.08	0.08
query5	0.49	0.48	0.51
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.53	0.49	0.48
query10	0.54	0.54	0.55
query11	0.16	0.12	0.11
query12	0.15	0.12	0.11
query13	0.60	0.60	0.59
query14	0.80	0.76	0.80
query15	0.83	0.82	0.80
query16	0.36	0.38	0.35
query17	0.98	1.01	0.98
query18	0.20	0.25	0.26
query19	1.82	1.74	1.66
query20	0.02	0.01	0.01
query21	15.44	0.71	0.68
query22	4.26	7.78	1.88
query23	18.26	1.54	1.31
query24	1.82	0.23	0.25
query25	0.15	0.09	0.09
query26	0.26	0.17	0.17
query27	0.08	0.07	0.08
query28	13.29	1.03	1.00
query29	13.31	3.29	3.26
query30	0.25	0.05	0.07
query31	2.88	0.38	0.38
query32	3.29	0.48	0.46
query33	2.91	2.95	2.89
query34	17.39	4.39	4.43
query35	4.53	4.52	4.64
query36	0.65	0.46	0.45
query37	0.19	0.16	0.16
query38	0.15	0.14	0.14
query39	0.05	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.04	0.05
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.17 s
Total hot run time: 30.53 s

@morrySnow

morrySnow commented May 31, 2024

Copy link
Copy Markdown
ContributorAuthor

run cloud_p1

@morrySnow
morrySnowforce-pushed the fix_unix_timestamp branch from 4fe7a51 to 83acb92CompareMay 31, 2024 11:34
@morrySnow

morrySnow commented May 31, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented May 31, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 41717 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 83acb9217e78614ee9c1c53f0620daee25915942, data reload: false
------ Round 1 ----------------------------------
q1	17608	4281	4281	4281
q2	2025	193	195	193
q3	10434	1213	1021	1021
q4	10196	884	855	855
q5	7478	2741	2739	2739
q6	218	134	137	134
q7	965	615	617	615
q8	9214	2109	2065	2065
q9	9485	6650	6726	6650
q10	9261	3923	3912	3912
q11	438	244	234	234
q12	436	223	232	223
q13	17397	3172	3285	3172
q14	259	209	227	209
q15	502	467	470	467
q16	494	398	392	392
q17	978	666	689	666
q18	8340	7737	7756	7737
q19	4575	1525	1508	1508
q20	634	315	301	301
q21	5152	4023	4117	4023
q22	372	329	320	320
Total cold run time: 116461 ms
Total hot run time: 41717 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4599	4396	4499	4396
q2	366	278	271	271
q3	3133	2957	2815	2815
q4	1866	1582	1586	1582
q5	5458	5463	5447	5447
q6	221	127	125	125
q7	2160	1856	1849	1849
q8	3229	3346	3373	3346
q9	8590	8654	8657	8654
q10	4006	3722	3834	3722
q11	586	512	484	484
q12	793	623	626	623
q13	17139	3105	3154	3105
q14	313	275	278	275
q15	526	477	481	477
q16	492	427	449	427
q17	1800	1538	1453	1453
q18	7721	7444	7496	7444
q19	1678	1615	1526	1526
q20	1959	1785	1760	1760
q21	4808	4720	4731	4720
q22	601	522	510	510
Total cold run time: 72044 ms
Total hot run time: 55011 ms

@doris-robot

doris-robot commented May 31, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 169479 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 83acb9217e78614ee9c1c53f0620daee25915942, data reload: false
query1	926	383	363	363
query2	6477	2340	2328	2328
query3	6644	209	214	209
query4	19798	17210	17447	17210
query5	4158	430	432	430
query6	255	167	167	167
query7	4591	296	286	286
query8	326	297	275	275
query9	8640	2446	2430	2430
query10	478	295	278	278
query11	10520	9932	10056	9932
query12	143	94	92	92
query13	1661	379	376	376
query14	9494	6952	7638	6952
query15	227	185	200	185
query16	7168	271	264	264
query17	1292	533	539	533
query18	1918	294	279	279
query19	215	159	179	159
query20	93	88	88	88
query21	195	131	131	131
query22	4162	3930	3988	3930
query23	33391	32885	33252	32885
query24	5114	2942	2833	2833
query25	480	386	410	386
query26	694	155	157	155
query27	1838	320	318	318
query28	3811	2095	2101	2095
query29	859	623	610	610
query30	228	149	156	149
query31	913	776	750	750
query32	61	53	57	53
query33	475	289	280	280
query34	853	475	471	471
query35	713	637	633	633
query36	1036	888	936	888
query37	110	74	77	74
query38	2836	2793	2764	2764
query39	862	786	792	786
query40	203	126	128	126
query41	58	55	55	55
query42	105	98	104	98
query43	576	534	553	534
query44	1108	737	765	737
query45	185	172	170	170
query46	1050	703	717	703
query47	1869	1748	1801	1748
query48	371	299	300	299
query49	787	403	411	403
query50	768	381	381	381
query51	6649	6560	6916	6560
query52	110	89	101	89
query53	352	296	296	296
query54	553	440	426	426
query55	76	76	75	75
query56	289	297	265	265
query57	1127	1026	1019	1019
query58	240	237	218	218
query59	3392	3086	3236	3086
query60	302	275	272	272
query61	112	111	109	109
query62	546	452	469	452
query63	312	284	297	284
query64	2686	1942	1858	1858
query65	3165	3082	3119	3082
query66	683	345	352	345
query67	15146	14801	15024	14801
query68	4594	531	537	531
query69	440	275	273	273
query70	1190	1120	1064	1064
query71	419	270	272	270
query72	7626	2872	2658	2658
query73	710	321	329	321
query74	6055	5580	5509	5509
query75	3321	2640	2629	2629
query76	2244	978	936	936
query77	380	273	269	269
query78	10216	9786	9761	9761
query79	1571	513	509	509
query80	978	458	446	446
query81	507	223	221	221
query82	945	96	95	95
query83	249	174	177	174
query84	248	93	88	88
query85	938	331	319	319
query86	434	305	281	281
query87	3303	3117	3133	3117
query88	3695	2388	2403	2388
query89	477	387	393	387
query90	2024	197	193	193
query91	142	122	117	117
query92	59	52	54	52
query93	1687	506	494	494
query94	1315	196	191	191
query95	410	321	316	316
query96	581	272	272	272
query97	3196	3018	3029	3018
query98	240	227	223	223
query99	1155	859	839	839
Total cold run time: 247824 ms
Total hot run time: 169479 ms

@doris-robot

doris-robot commented May 31, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.75 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 83acb9217e78614ee9c1c53f0620daee25915942, data reload: false
query1	0.04	0.03	0.04
query2	0.07	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.50	0.47	0.49
query6	1.12	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.54	0.49	0.49
query10	0.56	0.55	0.53
query11	0.15	0.11	0.12
query12	0.15	0.11	0.11
query13	0.59	0.59	0.58
query14	0.79	0.79	0.80
query15	0.83	0.81	0.81
query16	0.36	0.37	0.36
query17	0.99	0.96	1.04
query18	0.20	0.26	0.25
query19	1.86	1.80	1.72
query20	0.01	0.01	0.01
query21	15.75	0.66	0.66
query22	4.31	6.79	2.19
query23	18.32	1.40	1.28
query24	1.78	0.27	0.20
query25	0.15	0.08	0.08
query26	0.26	0.17	0.17
query27	0.08	0.08	0.09
query28	13.39	1.01	1.00
query29	13.53	3.26	3.26
query30	0.24	0.06	0.06
query31	2.87	0.39	0.38
query32	3.29	0.48	0.45
query33	2.88	2.88	2.89
query34	17.20	4.52	4.43
query35	4.56	4.43	4.57
query36	0.69	0.46	0.46
query37	0.17	0.16	0.16
query38	0.16	0.15	0.16
query39	0.04	0.03	0.04
query40	0.17	0.15	0.14
query41	0.09	0.04	0.05
query42	0.05	0.04	0.04
query43	0.03	0.03	0.04
Total cold run time: 110.75 s
Total hot run time: 30.75 s

@morrySnow

morrySnow commented May 31, 2024

Copy link
Copy Markdown
ContributorAuthor

run feut

@924060929

924060929 commented Jun 1, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Integer.parseInt can not process float string

jshell> Integer.parseInt("3.14159")
| 异常错误java.lang.NumberFormatException：Forinputstring: "3.14159"
| atNumberFormatException.forInputString (NumberFormatException.java:67)
| atInteger.parseInt (Integer.java:668)
| atInteger.parseInt (Integer.java:786)
| at (#1:1)

yiguolei
yiguolei previously approved these changes Jun 3, 2024
View reviewed changes
@morrySnow
morrySnowforce-pushed the fix_unix_timestamp branch from 83acb92 to b8acd12CompareJune 3, 2024 03:32
@morrySnow

morrySnow commented Jun 3, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jun 3, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 40549 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b8acd122e32aa9ec979466b2eef9d86d9336dc84, data reload: false
------ Round 1 ----------------------------------
q1	17711	4465	4373	4373
q2	3094	193	196	193
q3	12185	1138	1214	1138
q4	10529	812	953	812
q5	7855	2684	2661	2661
q6	220	137	141	137
q7	961	632	600	600
q8	10014	2101	2076	2076
q9	9195	6506	6426	6426
q10	9013	3679	3752	3679
q11	429	249	238	238
q12	427	237	228	228
q13	18033	2994	3030	2994
q14	261	230	220	220
q15	535	481	473	473
q16	539	381	383	381
q17	961	678	721	678
q18	8070	7597	7400	7400
q19	6136	1369	1496	1369
q20	645	317	296	296
q21	4991	3887	3843	3843
q22	397	334	339	334
Total cold run time: 122201 ms
Total hot run time: 40549 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4341	4245	4203	4203
q2	379	260	276	260
q3	3005	2761	2685	2685
q4	1877	1610	1644	1610
q5	5242	5283	5276	5276
q6	217	128	130	128
q7	2140	1705	1714	1705
q8	3190	3286	3297	3286
q9	8346	8328	8305	8305
q10	3859	3660	3676	3660
q11	590	500	489	489
q12	766	619	616	616
q13	17171	2999	3039	2999
q14	279	262	274	262
q15	504	469	474	469
q16	501	417	415	415
q17	1796	1495	1489	1489
q18	7698	7500	7405	7405
q19	1651	1590	1650	1590
q20	1988	1811	1789	1789
q21	4885	4764	4750	4750
q22	603	536	550	536
Total cold run time: 71028 ms
Total hot run time: 53927 ms

@doris-robot

doris-robot commented Jun 3, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 170895 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b8acd122e32aa9ec979466b2eef9d86d9336dc84, data reload: false
query1	931	376	389	376
query2	6439	2455	2375	2375
query3	6645	207	204	204
query4	19607	17421	17267	17267
query5	4135	455	465	455
query6	255	173	154	154
query7	4591	308	295	295
query8	332	293	302	293
query9	8450	2378	2351	2351
query10	460	324	283	283
query11	10499	10027	10032	10027
query12	139	92	88	88
query13	1630	363	371	363
query14	10231	7641	7297	7297
query15	246	193	196	193
query16	7770	261	268	261
query17	1840	536	552	536
query18	1810	293	271	271
query19	193	154	157	154
query20	92	86	94	86
query21	210	133	128	128
query22	4431	4156	4001	4001
query23	33770	33228	33133	33133
query24	11980	2865	2863	2863
query25	652	368	372	368
query26	1854	157	152	152
query27	2936	329	327	327
query28	7489	2045	2046	2045
query29	1120	608	604	604
query30	280	154	152	152
query31	946	762	729	729
query32	93	56	54	54
query33	768	286	309	286
query34	919	491	472	472
query35	754	627	613	613
query36	1081	964	926	926
query37	213	71	70	70
query38	2885	2766	2720	2720
query39	893	792	810	792
query40	280	125	123	123
query41	59	52	52	52
query42	130	101	102	101
query43	575	568	573	568
query44	1296	745	765	745
query45	206	168	163	163
query46	1079	728	729	728
query47	1862	1775	1790	1775
query48	373	305	301	301
query49	1187	414	414	414
query50	793	389	390	389
query51	6954	6836	6950	6836
query52	103	91	91	91
query53	359	286	295	286
query54	1009	494	440	440
query55	74	74	74	74
query56	276	259	280	259
query57	1145	1041	1071	1041
query58	269	258	253	253
query59	3408	3094	3239	3094
query60	297	270	280	270
query61	91	93	90	90
query62	622	432	454	432
query63	315	295	293	293
query64	9847	2227	1747	1747
query65	3197	3094	3106	3094
query66	1333	320	334	320
query67	15324	14901	15080	14901
query68	4583	570	535	535
query69	583	424	404	404
query70	1174	1107	1144	1107
query71	425	302	352	302
query72	7155	2717	2600	2600
query73	754	323	328	323
query74	5833	5600	5498	5498
query75	3463	2680	2669	2669
query76	3052	927	957	927
query77	662	308	300	300
query78	10245	9793	9841	9793
query79	2047	516	508	508
query80	855	475	461	461
query81	570	223	220	220
query82	678	105	101	101
query83	266	172	167	167
query84	232	84	84	84
query85	1806	270	316	270
query86	479	326	303	303
query87	3258	3100	3088	3088
query88	4048	2468	2473	2468
query89	476	394	392	392
query90	1802	195	200	195
query91	139	110	109	109
query92	63	50	51	50
query93	2230	526	510	510
query94	1197	202	198	198
query95	431	324	331	324
query96	586	283	280	280
query97	3236	2998	3004	2998
query98	262	225	215	215
query99	1229	926	852	852
Total cold run time: 275851 ms
Total hot run time: 170895 ms

@morrySnow

morrySnow commented Jun 3, 2024

Copy link
Copy Markdown
ContributorAuthor

run feut

@doris-robot

doris-robot commented Jun 3, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.46 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b8acd122e32aa9ec979466b2eef9d86d9336dc84, data reload: false
query1	0.04	0.04	0.03
query2	0.08	0.04	0.03
query3	0.24	0.05	0.05
query4	1.70	0.08	0.08
query5	0.49	0.49	0.51
query6	1.12	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.53	0.49	0.50
query10	0.54	0.54	0.54
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.59
query14	0.79	0.76	0.78
query15	0.82	0.82	0.82
query16	0.35	0.34	0.34
query17	0.96	1.03	0.99
query18	0.20	0.25	0.22
query19	1.87	1.77	1.67
query20	0.01	0.01	0.01
query21	15.71	0.66	0.65
query22	3.76	7.92	1.84
query23	18.29	1.32	1.30
query24	1.32	0.44	0.20
query25	0.15	0.10	0.08
query26	0.27	0.18	0.17
query27	0.08	0.08	0.08
query28	13.36	1.01	0.99
query29	13.21	3.29	3.33
query30	0.25	0.06	0.06
query31	2.87	0.40	0.38
query32	3.26	0.47	0.47
query33	2.89	2.95	2.87
query34	17.25	4.42	4.41
query35	4.46	4.51	4.51
query36	0.65	0.46	0.45
query37	0.18	0.15	0.16
query38	0.16	0.15	0.14
query39	0.05	0.04	0.03
query40	0.17	0.14	0.14
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.03	0.03
Total cold run time: 109.24 s
Total hot run time: 30.46 s

yiguolei
yiguolei previously approved these changes Jun 3, 2024
View reviewed changes
@github-actions

github-actionsBot commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 3, 2024
@github-actions

github-actionsBot commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

924060929
924060929 previously approved these changes Jun 3, 2024
View reviewed changes
@morrySnow
[fix](Nereids) unix_timestamp compute signature and fold const is wrong
95ab9ce
1. compute signature should call super#computeSignature first
2. fold const return type not changed after signature changed in apache#26827
@morrySnow
morrySnow dismissed stale reviews from 924060929 and yiguolei via 95ab9ceJune 3, 2024 06:40
@morrySnow
morrySnowforce-pushed the fix_unix_timestamp branch from b8acd12 to 95ab9ceCompareJune 3, 2024 06:40
@morrySnow

morrySnow commented Jun 3, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Jun 3, 2024
@doris-robot

doris-robot commented Jun 3, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 40781 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 95ab9ce68b7e146ec94e79cc3d5f70c225b3d578, data reload: false
------ Round 1 ----------------------------------
q1	17625	5008	4301	4301
q2	2033	191	196	191
q3	10551	1272	1095	1095
q4	10187	834	809	809
q5	7557	2692	2688	2688
q6	223	136	133	133
q7	967	617	626	617
q8	9210	2136	2121	2121
q9	9224	6668	6680	6668
q10	9160	3849	3906	3849
q11	458	240	239	239
q12	446	224	227	224
q13	18250	3218	3185	3185
q14	270	216	226	216
q15	524	475	485	475
q16	542	401	390	390
q17	1014	621	729	621
q18	8433	7880	7762	7762
q19	5204	1266	1375	1266
q20	667	343	344	343
q21	5092	3246	4087	3246
q22	402	359	342	342
Total cold run time: 118039 ms
Total hot run time: 40781 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4580	4462	4457	4457
q2	386	278	282	278
q3	3103	2933	2862	2862
q4	2085	1664	1593	1593
q5	5341	5513	5485	5485
q6	233	129	131	129
q7	2175	1824	1820	1820
q8	3185	3349	3374	3349
q9	8651	8541	8585	8541
q10	4106	3817	3789	3789
q11	568	477	490	477
q12	775	610	618	610
q13	16904	3107	3102	3102
q14	298	258	268	258
q15	521	472	465	465
q16	462	414	419	414
q17	1779	1509	1491	1491
q18	8062	7705	7263	7263
q19	1731	1589	1567	1567
q20	2624	1794	1765	1765
q21	6919	4735	4642	4642
q22	674	507	523	507
Total cold run time: 75162 ms
Total hot run time: 54864 ms

@doris-robot

doris-robot commented Jun 3, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 169436 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 95ab9ce68b7e146ec94e79cc3d5f70c225b3d578, data reload: false
query1	917	376	371	371
query2	6452	2412	2327	2327
query3	6636	206	204	204
query4	19625	17531	17097	17097
query5	4141	452	442	442
query6	237	167	158	158
query7	4589	284	289	284
query8	307	277	287	277
query9	8596	2409	2369	2369
query10	435	291	265	265
query11	10568	10046	10028	10028
query12	131	90	88	88
query13	1642	369	371	369
query14	8853	7702	7537	7537
query15	235	181	192	181
query16	7765	289	260	260
query17	1733	543	511	511
query18	1902	266	268	266
query19	208	146	152	146
query20	104	86	89	86
query21	209	135	128	128
query22	4230	4120	3898	3898
query23	33651	32949	32972	32949
query24	10819	2828	2780	2780
query25	603	353	357	353
query26	1194	151	151	151
query27	2656	322	330	322
query28	7145	2068	2080	2068
query29	878	609	608	608
query30	246	145	153	145
query31	939	720	733	720
query32	89	51	56	51
query33	754	269	264	264
query34	990	483	472	472
query35	732	632	608	608
query36	1090	950	919	919
query37	154	66	68	66
query38	2866	2722	2728	2722
query39	874	788	772	772
query40	206	122	118	118
query41	53	51	57	51
query42	114	97	93	93
query43	587	552	545	545
query44	1209	716	739	716
query45	196	168	166	166
query46	1076	735	734	734
query47	1840	1758	1793	1758
query48	374	298	288	288
query49	904	400	400	400
query50	792	375	372	372
query51	6965	6784	6782	6782
query52	101	90	90	90
query53	362	282	285	282
query54	863	453	432	432
query55	71	70	72	70
query56	271	256	260	256
query57	1157	1061	1065	1061
query58	258	248	241	241
query59	3408	3577	3075	3075
query60	286	264	261	261
query61	90	89	108	89
query62	629	462	473	462
query63	309	285	287	285
query64	8864	2224	1686	1686
query65	3198	3079	3118	3079
query66	773	320	317	317
query67	15491	15117	14982	14982
query68	4477	533	578	533
query69	452	299	306	299
query70	1113	1138	1134	1134
query71	395	271	283	271
query72	7374	2720	2537	2537
query73	751	324	314	314
query74	5921	5536	5485	5485
query75	3305	2616	2662	2616
query76	2219	882	946	882
query77	423	292	285	285
query78	10304	9733	9675	9675
query79	2201	508	502	502
query80	873	452	444	444
query81	587	215	215	215
query82	823	100	95	95
query83	232	166	162	162
query84	242	84	88	84
query85	1451	326	264	264
query86	454	308	332	308
query87	3303	3086	3090	3086
query88	3963	2330	2326	2326
query89	479	380	371	371
query90	1885	189	182	182
query91	120	98	98	98
query92	58	48	48	48
query93	2023	514	497	497
query94	1263	178	183	178
query95	397	314	306	306
query96	596	265	268	265
query97	3183	2961	3103	2961
query98	242	219	216	216
query99	1157	851	844	844
Total cold run time: 267908 ms
Total hot run time: 169436 ms

@doris-robot

doris-robot commented Jun 3, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.62 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 95ab9ce68b7e146ec94e79cc3d5f70c225b3d578, data reload: false
query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.22	0.04	0.05
query4	1.68	0.07	0.07
query5	0.50	0.48	0.50
query6	1.13	0.72	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.54	0.55	0.52
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.59	0.58	0.60
query14	0.79	0.78	0.76
query15	0.82	0.81	0.81
query16	0.36	0.34	0.36
query17	1.03	0.95	0.94
query18	0.20	0.24	0.23
query19	1.81	1.68	1.70
query20	0.01	0.02	0.01
query21	15.49	0.68	0.67
query22	4.82	6.19	2.26
query23	18.31	1.28	1.23
query24	1.92	0.21	0.22
query25	0.15	0.08	0.08
query26	0.26	0.17	0.18
query27	0.07	0.08	0.09
query28	13.35	1.02	1.00
query29	12.75	3.33	3.30
query30	0.24	0.05	0.05
query31	2.88	0.38	0.40
query32	3.27	0.47	0.47
query33	2.93	2.83	2.89
query34	17.07	4.41	4.37
query35	4.54	4.45	4.51
query36	0.71	0.49	0.47
query37	0.17	0.15	0.15
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.14	0.15
query41	0.09	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 110.21 s
Total hot run time: 30.62 s

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 3, 2024
@github-actions

github-actionsBot commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@yiguolei
yiguolei merged commit f4d029d into apache:masterJun 3, 2024
yiguolei pushed a commit that referenced this pull request Jun 3, 2024
@morrySnow@Doris-Extras
[fix](Nereids) unix_timestamp compute signature and fold const is wro…
958687f
…ng (#35727)
1. compute signature should call super#computeSignature first
2. fold const return type not changed after signature changed in #26827
we already have p0 for this case, but our regression framework has bug
that it report success when compare decimal type if real result lose
scale
@morrySnow
morrySnow deleted the fix_unix_timestamp branch June 3, 2024 11:04
dataroaring pushed a commit that referenced this pull request Jun 4, 2024
@morrySnow@dataroaring
[fix](Nereids) unix_timestamp compute signature and fold const is wro…
a654811
…ng (#35727)
1. compute signature should call super#computeSignature first
2. fold const return type not changed after signature changed in #26827
we already have p0 for this case, but our regression framework has bug
that it report success when compare decimal type if real result lose
scale
seawinde pushed a commit to seawinde/doris that referenced this pull request Jun 5, 2024
@morrySnow@seawinde
[fix](Nereids) unix_timestamp compute signature and fold const is wro…
9fa74bf
…ng (apache#35727)
1. compute signature should call super#computeSignature first
2. fold const return type not changed after signature changed in apache#26827
we already have p0 for this case, but our regression framework has bug
that it report success when compare decimal type if real result lose
scale
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@morrySnow@HappenLee
[fix](Nereids) unix_timestamp compute signature and fold const is wro…
522fa37
…ng (apache#35727)
1. compute signature should call super#computeSignature first
2. fold const return type not changed after signature changed in apache#26827
we already have p0 for this case, but our regression framework has bug
that it report success when compare decimal type if real result lose
scale
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@924060929924060929924060929 approved these changes
@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.4-mergeddev/3.0.0-mergedp0_wreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morrySnow@doris-robot@924060929@yiguolei@dataroaring