[Fix](Tablet) Fix the issue of redundant loading of stale rowset meta by platoneko · Pull Request #35768 · apache/doris

platoneko · 2024-06-02T08:27:37Z

Proposed changes

Fix the issue of redundant loading of stale rowset meta in TabletMeta::init_from_pb

doris-robot · 2024-06-02T08:27:42Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

platoneko · 2024-06-02T08:29:34Z

run buildall

platoneko · 2024-06-02T08:31:32Z

run buildall

github-actions · 2024-06-02T08:33:30Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-06-02T08:34:32Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-06-02T08:36:56Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-06-02T10:02:23Z

TPC-H: Total hot run time: 40940 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 913595ab6285ced6a976fe5e68a711a35f23d931, data reload: false
------ Round 1 ----------------------------------
q1	17607	4339	4274	4274
q2	2029	192	196	192
q3	10447	1217	1108	1108
q4	10197	775	868	775
q5	7483	2730	2760	2730
q6	232	145	139	139
q7	970	620	606	606
q8	9219	2155	2116	2116
q9	9218	6735	6684	6684
q10	9232	3867	4037	3867
q11	493	254	244	244
q12	463	258	233	233
q13	18702	3275	3211	3211
q14	270	224	231	224
q15	512	482	480	480
q16	514	408	408	408
q17	995	603	568	568
q18	8554	8008	7804	7804
q19	5914	1337	1339	1337
q20	650	332	318	318
q21	5112	3266	4084	3266
q22	419	356	356	356
Total cold run time: 119232 ms
Total hot run time: 40940 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4577	4453	4422	4422
q2	382	278	279	278
q3	3116	2935	2930	2930
q4	2032	1740	1673	1673
q5	5315	5532	5491	5491
q6	227	126	128	126
q7	2196	1831	1785	1785
q8	3220	3376	3388	3376
q9	8675	8610	8633	8610
q10	4140	3932	3813	3813
q11	618	495	488	488
q12	780	611	602	602
q13	16074	3115	3202	3115
q14	296	269	274	269
q15	526	465	472	465
q16	477	412	440	412
q17	1812	1520	1496	1496
q18	8090	7821	7307	7307
q19	1779	1585	1543	1543
q20	3022	1801	1818	1801
q21	7968	4729	4766	4729
q22	661	521	527	521
Total cold run time: 75983 ms
Total hot run time: 55252 ms

doris-robot · 2024-06-02T10:16:34Z

TeamCity be ut coverage result:
Function Coverage: 36.26% (9232/25459)
Line Coverage: 27.60% (75679/274184)
Region Coverage: 26.82% (39185/146098)
Branch Coverage: 23.54% (19853/84332)
Coverage Report: http://coverage.selectdb-in.cc/coverage/913595ab6285ced6a976fe5e68a711a35f23d931_913595ab6285ced6a976fe5e68a711a35f23d931/report/index.html

github-actions · 2024-06-03T07:01:20Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-06-03T07:25:13Z

clang-tidy review says "All clean, LGTM! 👍"

platoneko · 2024-06-03T08:58:10Z

run buildall

doris-robot · 2024-06-03T10:28:23Z

TPC-H: Total hot run time: 40869 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fe26a7b05135ec906f22708e76bee556eb1e4571, data reload: false
------ Round 1 ----------------------------------
q1	17611	4370	4284	4284
q2	2029	198	200	198
q3	10465	1268	1152	1152
q4	10188	843	744	744
q5	7500	2735	2693	2693
q6	227	136	142	136
q7	966	631	599	599
q8	9213	2111	2128	2111
q9	9165	6708	6747	6708
q10	9079	3806	3950	3806
q11	477	250	301	250
q12	448	229	233	229
q13	18560	3192	3141	3141
q14	282	239	231	231
q15	527	482	487	482
q16	540	411	393	393
q17	1002	645	776	645
q18	8464	7966	7736	7736
q19	3535	1317	1381	1317
q20	661	333	331	331
q21	5074	4014	3342	3342
q22	398	343	341	341
Total cold run time: 116411 ms
Total hot run time: 40869 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4550	4477	4420	4420
q2	405	279	263	263
q3	3102	2906	2884	2884
q4	2034	1665	1627	1627
q5	5326	5547	5480	5480
q6	219	123	124	123
q7	2197	1807	1799	1799
q8	3217	3372	3355	3355
q9	8695	8667	8616	8616
q10	4119	3850	3787	3787
q11	604	493	492	492
q12	784	577	595	577
q13	16902	3041	3154	3041
q14	290	280	261	261
q15	528	487	475	475
q16	477	431	412	412
q17	1813	1521	1497	1497
q18	8126	7877	7469	7469
q19	1752	1670	1508	1508
q20	3033	1795	1800	1795
q21	4852	4691	4790	4691
q22	864	532	555	532
Total cold run time: 73889 ms
Total hot run time: 55104 ms

doris-robot · 2024-06-03T10:39:16Z

TPC-DS: Total hot run time: 172505 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fe26a7b05135ec906f22708e76bee556eb1e4571, data reload: false
query1	922	385	364	364
query2	6461	2280	2421	2280
query3	6639	205	204	204
query4	19883	17470	17287	17287
query5	4128	452	439	439
query6	235	156	152	152
query7	4590	304	290	290
query8	307	278	271	271
query9	8423	2414	2382	2382
query10	467	305	288	288
query11	10767	10268	10324	10268
query12	137	92	86	86
query13	1626	356	366	356
query14	9363	7055	6843	6843
query15	238	190	184	184
query16	7152	260	259	259
query17	1027	528	518	518
query18	1905	271	266	266
query19	191	151	156	151
query20	91	85	88	85
query21	214	127	125	125
query22	4489	4197	4281	4197
query23	33414	32904	33042	32904
query24	11012	2839	2768	2768
query25	614	350	359	350
query26	1369	154	155	154
query27	2956	321	347	321
query28	7252	2056	2058	2056
query29	984	618	593	593
query30	291	148	148	148
query31	958	754	724	724
query32	91	51	55	51
query33	762	277	273	273
query34	996	490	468	468
query35	746	605	608	605
query36	1078	921	863	863
query37	145	66	67	66
query38	2831	2748	2726	2726
query39	864	786	816	786
query40	212	127	125	125
query41	50	54	59	54
query42	115	99	92	92
query43	579	568	576	568
query44	1260	738	750	738
query45	201	172	163	163
query46	1064	692	744	692
query47	1879	1813	1808	1808
query48	373	302	304	302
query49	1030	396	399	396
query50	778	386	384	384
query51	6967	6722	6742	6722
query52	109	90	86	86
query53	354	280	282	280
query54	854	448	437	437
query55	72	69	71	69
query56	271	249	252	249
query57	1141	1043	1065	1043
query58	244	254	240	240
query59	3438	3173	3209	3173
query60	297	300	276	276
query61	92	88	86	86
query62	639	437	433	433
query63	312	282	281	281
query64	9000	2210	1779	1779
query65	3152	3110	3084	3084
query66	1102	325	331	325
query67	15614	14903	14917	14903
query68	4811	539	526	526
query69	590	493	355	355
query70	1122	1136	1180	1136
query71	410	285	283	283
query72	7149	5409	5388	5388
query73	759	317	316	316
query74	5903	5589	5572	5572
query75	3328	2614	2668	2614
query76	2885	877	970	877
query77	612	289	287	287
query78	10231	9847	9679	9679
query79	2271	501	509	501
query80	830	454	462	454
query81	584	237	219	219
query82	903	100	107	100
query83	240	174	174	174
query84	326	82	84	82
query85	1409	279	269	269
query86	481	288	298	288
query87	3311	3057	3043	3043
query88	4131	2412	2425	2412
query89	463	365	370	365
query90	1788	186	181	181
query91	123	97	99	97
query92	63	49	49	49
query93	1983	513	499	499
query94	1148	184	178	178
query95	414	309	304	304
query96	584	271	270	270
query97	3172	3035	2997	2997
query98	252	218	212	212
query99	1086	843	839	839
Total cold run time: 270179 ms
Total hot run time: 172505 ms

doris-robot · 2024-06-03T10:44:45Z

ClickBench: Total hot run time: 30.94 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fe26a7b05135ec906f22708e76bee556eb1e4571, data reload: false
query1	0.04	0.04	0.04
query2	0.08	0.03	0.04
query3	0.22	0.05	0.05
query4	1.69	0.07	0.07
query5	0.52	0.48	0.50
query6	1.13	0.72	0.74
query7	0.02	0.02	0.01
query8	0.06	0.04	0.04
query9	0.53	0.47	0.50
query10	0.53	0.55	0.53
query11	0.16	0.11	0.10
query12	0.14	0.12	0.12
query13	0.58	0.58	0.60
query14	0.78	0.78	0.76
query15	0.82	0.82	0.81
query16	0.37	0.36	0.34
query17	0.97	0.97	1.00
query18	0.22	0.25	0.22
query19	1.92	1.69	1.72
query20	0.02	0.01	0.00
query21	15.48	0.68	0.66
query22	4.93	5.79	2.37
query23	18.30	1.40	1.31
query24	1.69	0.23	0.22
query25	0.14	0.08	0.08
query26	0.27	0.19	0.18
query27	0.07	0.08	0.08
query28	13.43	1.02	0.99
query29	13.28	3.32	3.26
query30	0.24	0.05	0.06
query31	2.86	0.38	0.39
query32	3.29	0.46	0.46
query33	2.83	2.89	2.89
query34	17.09	4.43	4.41
query35	4.48	4.54	4.58
query36	0.68	0.48	0.46
query37	0.19	0.15	0.16
query38	0.16	0.14	0.14
query39	0.04	0.04	0.03
query40	0.17	0.14	0.14
query41	0.08	0.05	0.04
query42	0.05	0.04	0.05
query43	0.04	0.03	0.04
Total cold run time: 110.59 s
Total hot run time: 30.94 s

platoneko · 2024-06-03T12:26:07Z

run buildall

github-actions · 2024-06-03T12:32:45Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-06-03T13:43:46Z

TPC-H: Total hot run time: 40930 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c2d8af6ac2b7b7a4d471e7994de3d3379b8d4cdd, data reload: false
------ Round 1 ----------------------------------
q1	17610	4384	4365	4365
q2	2029	203	200	200
q3	10610	1260	1165	1165
q4	10880	857	807	807
q5	7544	2740	2643	2643
q6	221	138	140	138
q7	970	636	605	605
q8	9317	2128	2157	2128
q9	9322	6630	6645	6630
q10	9140	3744	3704	3704
q11	455	262	251	251
q12	449	237	226	226
q13	17772	2973	2992	2973
q14	282	224	230	224
q15	520	473	475	473
q16	494	393	390	390
q17	973	672	618	618
q18	8035	7384	7333	7333
q19	2525	1512	1501	1501
q20	668	315	324	315
q21	4906	3904	3974	3904
q22	400	346	337	337
Total cold run time: 115122 ms
Total hot run time: 40930 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4390	4291	4264	4264
q2	374	263	268	263
q3	3011	2709	2774	2709
q4	1888	1600	1606	1600
q5	5277	5256	5239	5239
q6	221	128	129	128
q7	2136	1766	1744	1744
q8	3200	3355	3308	3308
q9	8339	8348	8330	8330
q10	3880	3684	3723	3684
q11	601	494	477	477
q12	756	589	621	589
q13	17412	2981	3014	2981
q14	301	257	263	257
q15	519	485	479	479
q16	462	418	424	418
q17	1806	1512	1514	1512
q18	7652	7510	7331	7331
q19	1718	1620	1683	1620
q20	1985	1776	1775	1775
q21	4902	4768	4678	4678
q22	624	555	549	549
Total cold run time: 71454 ms
Total hot run time: 53935 ms

doris-robot · 2024-06-03T13:54:45Z

TPC-DS: Total hot run time: 173433 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c2d8af6ac2b7b7a4d471e7994de3d3379b8d4cdd, data reload: false
query1	929	388	388	388
query2	6468	2564	2417	2417
query3	6658	206	213	206
query4	19687	17536	17379	17379
query5	4125	472	468	468
query6	266	170	161	161
query7	4600	308	302	302
query8	312	284	289	284
query9	8517	2436	2417	2417
query10	444	300	285	285
query11	10637	10133	10129	10129
query12	136	90	89	89
query13	1630	372	378	372
query14	9449	7920	7246	7246
query15	223	193	190	190
query16	7776	273	276	273
query17	1814	538	521	521
query18	1794	267	270	267
query19	201	158	172	158
query20	92	91	85	85
query21	210	136	133	133
query22	4361	3989	4100	3989
query23	33813	33126	33022	33022
query24	11107	2818	2878	2818
query25	626	358	367	358
query26	1482	162	156	156
query27	2808	331	332	331
query28	7383	2113	2093	2093
query29	954	618	607	607
query30	274	153	156	153
query31	964	747	739	739
query32	87	55	55	55
query33	758	278	279	278
query34	971	495	481	481
query35	761	624	616	616
query36	1084	940	919	919
query37	142	68	72	68
query38	2904	2748	2736	2736
query39	877	816	798	798
query40	282	129	131	129
query41	55	51	55	51
query42	123	103	98	98
query43	590	566	539	539
query44	1265	746	758	746
query45	208	177	167	167
query46	1080	748	759	748
query47	1832	1775	1737	1737
query48	380	302	314	302
query49	1163	408	416	408
query50	787	398	398	398
query51	6878	6864	6739	6739
query52	106	93	88	88
query53	360	294	295	294
query54	892	453	451	451
query55	75	73	73	73
query56	281	258	262	258
query57	1123	1023	1076	1023
query58	253	247	248	247
query59	3452	3222	3097	3097
query60	295	284	305	284
query61	90	88	148	88
query62	629	423	435	423
query63	326	301	296	296
query64	9729	2195	1715	1715
query65	3179	3123	3130	3123
query66	1348	352	336	336
query67	15479	14806	14908	14806
query68	4604	566	552	552
query69	468	307	316	307
query70	1161	1122	1134	1122
query71	470	295	283	283
query72	7023	5366	5451	5366
query73	737	321	328	321
query74	6024	5575	5480	5480
query75	3383	2690	2712	2690
query76	2875	910	921	910
query77	444	302	301	301
query78	10291	9966	9743	9743
query79	2671	533	529	529
query80	1143	479	469	469
query81	569	231	224	224
query82	767	105	105	105
query83	240	175	185	175
query84	247	87	85	85
query85	1702	264	267	264
query86	562	315	300	300
query87	3241	3102	3164	3102
query88	4006	2359	2349	2349
query89	470	414	397	397
query90	1761	195	196	195
query91	126	96	97	96
query92	64	50	51	50
query93	1894	530	520	520
query94	1177	192	186	186
query95	410	324	323	323
query96	587	270	268	268
query97	3183	3089	3007	3007
query98	244	222	226	222
query99	1126	841	864	841
Total cold run time: 273254 ms
Total hot run time: 173433 ms

doris-robot · 2024-06-03T13:59:51Z

TeamCity be ut coverage result:
Function Coverage: 36.24% (9240/25500)
Line Coverage: 27.58% (75875/275093)
Region Coverage: 26.82% (39289/146474)
Branch Coverage: 23.56% (19907/84510)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c2d8af6ac2b7b7a4d471e7994de3d3379b8d4cdd_c2d8af6ac2b7b7a4d471e7994de3d3379b8d4cdd/report/index.html

doris-robot · 2024-06-03T14:00:16Z

ClickBench: Total hot run time: 30.89 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c2d8af6ac2b7b7a4d471e7994de3d3379b8d4cdd, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.67	0.10	0.09
query5	0.50	0.48	0.49
query6	1.12	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.53	0.55	0.56
query11	0.16	0.11	0.12
query12	0.16	0.12	0.12
query13	0.61	0.59	0.60
query14	0.78	0.78	0.79
query15	0.85	0.82	0.81
query16	0.36	0.37	0.36
query17	1.04	1.04	1.06
query18	0.22	0.26	0.24
query19	1.81	1.72	1.75
query20	0.02	0.01	0.00
query21	15.70	0.66	0.66
query22	4.17	7.21	2.05
query23	18.29	1.33	1.32
query24	1.72	0.29	0.21
query25	0.13	0.09	0.08
query26	0.26	0.17	0.18
query27	0.08	0.08	0.07
query28	13.34	1.01	1.01
query29	13.21	3.32	3.34
query30	0.25	0.06	0.05
query31	2.86	0.39	0.39
query32	3.30	0.48	0.47
query33	2.94	2.95	2.93
query34	17.15	4.37	4.41
query35	4.48	4.46	4.50
query36	0.65	0.48	0.47
query37	0.18	0.16	0.16
query38	0.16	0.15	0.14
query39	0.04	0.03	0.04
query40	0.16	0.14	0.14
query41	0.09	0.04	0.04
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.04 s
Total hot run time: 30.89 s

dataroaring

LGTM

…a::init_from_pb`

platoneko · 2024-06-04T07:31:04Z

run buildall

github-actions · 2024-06-04T07:34:36Z

clang-tidy review says "All clean, LGTM! 👍"

xy720

LGTM

github-actions · 2024-06-04T08:00:18Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-06-04T08:00:20Z

PR approved by anyone and no changes requested.

doris-robot · 2024-06-04T08:41:38Z

TPC-H: Total hot run time: 40158 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 39cc91ce828b52c2e21a7f484280b5f40eb4c0e3, data reload: false
------ Round 1 ----------------------------------
q1	18680	4621	4354	4354
q2	2027	190	193	190
q3	10466	1151	1238	1151
q4	10146	764	745	745
q5	7484	2720	2701	2701
q6	217	135	134	134
q7	957	609	600	600
q8	9219	2081	2106	2081
q9	8951	6538	6528	6528
q10	8962	3756	3759	3756
q11	458	254	243	243
q12	425	226	220	220
q13	17795	2989	3002	2989
q14	272	227	233	227
q15	514	477	485	477
q16	513	381	379	379
q17	979	706	702	702
q18	8082	7533	7412	7412
q19	3783	1512	1452	1452
q20	655	334	322	322
q21	5050	3154	3956	3154
q22	402	342	341	341
Total cold run time: 116037 ms
Total hot run time: 40158 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4395	4210	4226	4210
q2	370	266	268	266
q3	2955	2742	2782	2742
q4	1869	1653	1606	1606
q5	5277	5312	5305	5305
q6	214	126	125	125
q7	2082	1709	1758	1709
q8	3230	3326	3316	3316
q9	8412	8441	8373	8373
q10	3891	3729	3696	3696
q11	604	497	496	496
q12	762	585	592	585
q13	16466	2957	2989	2957
q14	297	273	279	273
q15	513	467	472	467
q16	479	414	407	407
q17	1805	1495	1503	1495
q18	7653	7434	7323	7323
q19	1688	1584	1688	1584
q20	1989	1790	1798	1790
q21	4936	4795	4821	4795
q22	639	555	544	544
Total cold run time: 70526 ms
Total hot run time: 54064 ms

doris-robot · 2024-06-04T08:52:39Z

TPC-DS: Total hot run time: 172221 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 39cc91ce828b52c2e21a7f484280b5f40eb4c0e3, data reload: false
query1	915	391	381	381
query2	6486	2337	2504	2337
query3	6652	215	210	210
query4	19049	17323	17435	17323
query5	4198	451	451	451
query6	243	155	158	155
query7	4588	298	297	297
query8	298	284	293	284
query9	8622	2460	2455	2455
query10	451	295	270	270
query11	10584	10034	10062	10034
query12	132	87	87	87
query13	1634	362	357	357
query14	10248	7520	6055	6055
query15	236	192	187	187
query16	7843	272	262	262
query17	1838	511	513	511
query18	1959	281	268	268
query19	200	151	147	147
query20	104	86	86	86
query21	207	130	127	127
query22	4402	4087	4170	4087
query23	33704	33119	33205	33119
query24	12094	2746	2853	2746
query25	671	349	363	349
query26	1797	157	156	156
query27	3031	316	318	316
query28	7738	2082	2086	2082
query29	1113	609	617	609
query30	274	149	146	146
query31	1005	729	724	724
query32	99	54	54	54
query33	769	283	273	273
query34	1017	473	472	472
query35	729	618	616	616
query36	1066	930	918	918
query37	291	72	69	69
query38	2848	2814	2744	2744
query39	844	772	758	758
query40	288	123	125	123
query41	56	50	54	50
query42	118	97	97	97
query43	577	540	571	540
query44	1231	717	754	717
query45	194	166	163	163
query46	1069	711	729	711
query47	1868	1767	1795	1767
query48	392	297	304	297
query49	1205	450	402	402
query50	779	382	390	382
query51	6926	6819	6759	6759
query52	101	90	89	89
query53	360	296	292	292
query54	976	446	437	437
query55	73	73	72	72
query56	281	255	264	255
query57	1145	1045	1077	1045
query58	247	249	240	240
query59	3344	3090	3133	3090
query60	290	275	269	269
query61	91	116	87	87
query62	655	452	436	436
query63	320	284	284	284
query64	9792	2228	1729	1729
query65	3175	3085	3127	3085
query66	1369	341	337	337
query67	15408	15017	15127	15017
query68	4569	548	550	548
query69	517	407	356	356
query70	1112	1145	1089	1089
query71	396	297	292	292
query72	7354	5452	5751	5452
query73	757	333	327	327
query74	5829	5560	5468	5468
query75	3319	2679	2636	2636
query76	2589	900	920	900
query77	463	305	299	299
query78	10440	9786	9793	9786
query79	2254	514	524	514
query80	1378	483	477	477
query81	585	219	220	219
query82	781	103	112	103
query83	266	176	173	173
query84	260	89	88	88
query85	1996	329	314	314
query86	488	310	336	310
query87	3287	3102	3078	3078
query88	3703	2447	2455	2447
query89	492	394	385	385
query90	1798	187	187	187
query91	136	111	109	109
query92	67	50	54	50
query93	2516	518	500	500
query94	1285	200	196	196
query95	419	320	326	320
query96	601	276	269	269
query97	3188	3047	2973	2973
query98	249	222	217	217
query99	1211	845	848	845
Total cold run time: 276614 ms
Total hot run time: 172221 ms

doris-robot · 2024-06-04T08:58:11Z

ClickBench: Total hot run time: 30.73 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 39cc91ce828b52c2e21a7f484280b5f40eb4c0e3, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.24	0.04	0.05
query4	1.66	0.08	0.08
query5	0.51	0.48	0.49
query6	1.14	0.72	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.50	0.50
query10	0.54	0.54	0.55
query11	0.14	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.60
query14	0.78	0.77	0.77
query15	0.84	0.80	0.81
query16	0.37	0.37	0.37
query17	1.05	1.04	1.03
query18	0.21	0.25	0.25
query19	1.89	1.71	1.75
query20	0.01	0.01	0.01
query21	15.70	0.66	0.66
query22	4.38	7.60	2.04
query23	18.24	1.36	1.25
query24	1.81	0.27	0.20
query25	0.14	0.09	0.09
query26	0.27	0.17	0.16
query27	0.08	0.08	0.08
query28	13.34	1.01	1.00
query29	13.18	3.31	3.28
query30	0.25	0.06	0.06
query31	2.85	0.38	0.39
query32	3.29	0.46	0.46
query33	2.83	2.89	2.90
query34	17.00	4.40	4.46
query35	4.47	4.50	4.50
query36	0.66	0.47	0.47
query37	0.18	0.16	0.16
query38	0.15	0.14	0.14
query39	0.04	0.03	0.04
query40	0.17	0.13	0.14
query41	0.09	0.04	0.04
query42	0.05	0.05	0.04
query43	0.04	0.03	0.03
Total cold run time: 110.06 s
Total hot run time: 30.73 s

doris-robot · 2024-06-04T09:08:43Z

TeamCity be ut coverage result:
Function Coverage: 37.40% (9283/24823)
Line Coverage: 28.73% (76011/264585)
Region Coverage: 28.11% (39378/140084)
Branch Coverage: 24.52% (19918/81224)
Coverage Report: http://coverage.selectdb-in.cc/coverage/39cc91ce828b52c2e21a7f484280b5f40eb4c0e3_39cc91ce828b52c2e21a7f484280b5f40eb4c0e3/report/index.html

dataroaring

LGTM

…apache#35768) ## Proposed changes Fix the issue of redundant loading of stale rowset meta in `TabletMeta::init_from_pb`

#35768)" (#35882)

…apache#35768) ## Proposed changes Fix the issue of redundant loading of stale rowset meta in `TabletMeta::init_from_pb`

…#35768) ## Proposed changes Fix the issue of redundant loading of stale rowset meta in `TabletMeta::init_from_pb`

…apache#35768) ## Proposed changes Fix the issue of redundant loading of stale rowset meta in `TabletMeta::init_from_pb`

platoneko force-pushed the reduntent-stale-rowset branch from 6ec2757 to 8ec3772Compare June 2, 2024 08:28

platoneko requested review from gavinchou, liaoxin01 and zhannngchen and removed request for zhannngchen June 2, 2024 08:29

platoneko force-pushed the reduntent-stale-rowset branch from 8ec3772 to 913595aCompare June 2, 2024 08:31

platoneko marked this pull request as draft June 2, 2024 15:19

platoneko force-pushed the reduntent-stale-rowset branch from 913595a to cc47f64Compare June 3, 2024 06:55

platoneko marked this pull request as ready for review June 3, 2024 09:01

dataroaring previously approved these changes Jun 4, 2024
View reviewed changes

Fix the issue of redundant loading of stale rowset meta in `TabletMet…
39cc91c
…a::init_from_pb`

platoneko dismissed dataroaring’s stale review via 39cc91cJune 4, 2024 07:28

platoneko force-pushed the reduntent-stale-rowset branch from c2d8af6 to 39cc91cCompare June 4, 2024 07:28

xy720 approved these changes Jun 4, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 4, 2024

github-actionsBot added the reviewed label Jun 4, 2024

dataroaring approved these changes Jun 4, 2024
View reviewed changes

dataroaring added the dev/2.1.x label Jun 4, 2024

dataroaring merged commit 68d57bb into apache:masterJun 4, 2024

platoneko added a commit to platoneko/doris that referenced this pull request Jun 4, 2024
[Fix](Tablet) Fix the issue of redundant loading of stale rowset meta (…
499c1a1
…apache#35768) ## Proposed changes Fix the issue of redundant loading of stale rowset meta in `TabletMeta::init_from_pb`

yiguolei pushed a commit that referenced this pull request Jun 4, 2024
Pick "[Fix](Tablet) Fix the issue of redundant loading of stale rowset (
c2b830e
#35768)" (#35882)

seawinde pushed a commit to seawinde/doris that referenced this pull request Jun 5, 2024
[Fix](Tablet) Fix the issue of redundant loading of stale rowset meta (…
83f7ed9
…apache#35768) ## Proposed changes Fix the issue of redundant loading of stale rowset meta in `TabletMeta::init_from_pb`

dataroaring pushed a commit that referenced this pull request Jun 7, 2024
[Fix](Tablet) Fix the issue of redundant loading of stale rowset meta (…
891e6bd
…#35768) ## Proposed changes Fix the issue of redundant loading of stale rowset meta in `TabletMeta::init_from_pb`

dataroaring added dev/2.1.4-merged and removed dev/2.1.x labels Jun 11, 2024

morningman mentioned this pull request Jun 20, 2024
Pick "[Fix](Tablet) Fix the issue of redundant loading of stale rowset (#35768)" #35882
Merged

dataroaring added the dev/3.0.0-merged label Aug 5, 2024

Uh oh!

Conversation

platoneko commented Jun 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Uh oh!

doris-robot commented Jun 2, 2024

Uh oh!

platoneko commented Jun 2, 2024

Uh oh!

platoneko commented Jun 2, 2024

Uh oh!

github-actionsBot commented Jun 2, 2024

Uh oh!

github-actionsBot commented Jun 2, 2024

Uh oh!

github-actionsBot commented Jun 2, 2024

Uh oh!

doris-robot commented Jun 2, 2024

Uh oh!

doris-robot commented Jun 2, 2024

Uh oh!

github-actionsBot commented Jun 3, 2024

Uh oh!

github-actionsBot commented Jun 3, 2024

Uh oh!

platoneko commented Jun 3, 2024

Uh oh!

doris-robot commented Jun 3, 2024

Uh oh!

doris-robot commented Jun 3, 2024

Uh oh!

doris-robot commented Jun 3, 2024

Uh oh!

platoneko commented Jun 3, 2024

Uh oh!

github-actionsBot commented Jun 3, 2024

Uh oh!

doris-robot commented Jun 3, 2024

Uh oh!

doris-robot commented Jun 3, 2024

Uh oh!

doris-robot commented Jun 3, 2024

Uh oh!

doris-robot commented Jun 3, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

platoneko commented Jun 4, 2024

Uh oh!

github-actionsBot commented Jun 4, 2024

Uh oh!

xy720 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jun 4, 2024

Uh oh!

github-actionsBot commented Jun 4, 2024

Uh oh!

doris-robot commented Jun 4, 2024

Uh oh!

doris-robot commented Jun 4, 2024

Uh oh!

doris-robot commented Jun 4, 2024

Uh oh!

doris-robot commented Jun 4, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

platoneko commented Jun 2, 2024•
edited
Loading