Skip to content

[OUTFILE] Support INTO OUTFILE to export query result - #3584

Merged
morningman merged 18 commits into
apache:masterfrom
morningman:parquet_writer
May 25, 2020
Merged

[OUTFILE] Support INTO OUTFILE to export query result#3584
morningman merged 18 commits into
apache:masterfrom
morningman:parquet_writer

Conversation

@morningman

@morningmanmorningman commented May 13, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

The proposal can be found here: #3549

This CL mainly changes:

  1. Support SELECT INTO OUTFILE command.
  2. Support export query result to a file via Broker.
  3. Support CSV export format with specified column separator and line delimiter.

The following feature will be implemented in next PR:

  1. Support Parquet export file.

For easy review, please first see the proposal #3549.
Than see the user doc in administrator-guide/outfile.md

@morningmanmorningman added kind/feature Categorizes issue or PR as related to a new feature. api-review Categorizes an issue or PR as actively needing an API review. area/sql/function Issues or PRs related to the SQL functions labels May 13, 2020
@morningmanmorningman self-assigned this May 13, 2020
@morningman

morningman commented May 15, 2020

Copy link
Copy Markdown
ContributorAuthor

This CL is ready for reviewing.
But I have no idea why continuous-integration/travis-ci/pr failed...

yangzhg
yangzhg reviewed May 18, 2020
View reviewed changes
Comment threadbe/src/exec/parquet_writer.cpp
Comment threadbe/src/exec/parquet_writer.cpp
Comment threadbe/src/runtime/file_result_writer.cpp
Comment threadbe/src/runtime/file_result_writer.cpp Outdated
Comment threadbe/src/runtime/file_result_writer.cpp Outdated
Comment threadbe/src/runtime/mysql_result_writer.h Outdated
Comment threadbe/src/runtime/mysql_result_writer.h
Comment threadbe/src/runtime/result_sink.cpp
Comment threadbuild.sh Outdated
Comment threaddocs/zh-CN/administrator-guide/outfile.md Outdated
zhangy5
zhangy5 reviewed May 19, 2020
View reviewed changes
Comment threaddocs/zh-CN/administrator-guide/outfile.md Outdated
kangkaisen
kangkaisen reviewed May 20, 2020
View reviewed changes
Comment threaddocs/zh-CN/administrator-guide/outfile.md Outdated
Comment threaddocs/zh-CN/administrator-guide/outfile.md Outdated
Comment threaddocs/zh-CN/administrator-guide/outfile.md
Comment threadbe/src/runtime/mysql_result_writer.h Outdated
Comment threadbe/src/runtime/mysql_result_writer.h Outdated
Comment threadbe/src/runtime/file_result_writer.h
Comment threadbe/src/runtime/file_result_writer.h Outdated
@morningman

morningman commented May 22, 2020

Copy link
Copy Markdown
ContributorAuthor

Hi @kangkaisen any more comment?

kangkaisen
kangkaisen previously approved these changes May 22, 2020
View reviewed changes

@kangkaisenkangkaisen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

imay
imay reviewed May 22, 2020
View reviewed changes
Comment threaddocs/zh-CN/administrator-guide/outfile.md Outdated
Comment threaddocs/zh-CN/administrator-guide/outfile.md
Comment threaddocs/zh-CN/administrator-guide/outfile.md Outdated
@morningman

morningman commented May 23, 2020

Copy link
Copy Markdown
ContributorAuthor

Hi @imay Please review

imay
imay reviewed May 24, 2020
View reviewed changes

@imayimay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface LGTM, the implementation details need other's review.

Comment threadbe/src/runtime/query_statistics.h
EmmyMiao87
EmmyMiao87 approved these changes May 25, 2020
View reviewed changes

@EmmyMiao87EmmyMiao87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
morningman merged commit 3ffc447 into apache:masterMay 25, 2020
@EmmyMiao87EmmyMiao87 mentioned this pull request Aug 17, 2020
Closed
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Nov 12, 2024
@deardeng
(selectdb-cloud) Fix -230 case affected by the default cluster of oth…
ef24c06
…er cases (apache#3584)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imayimayimay left review comments
@yangzhgyangzhgyangzhg left review comments
@EmmyMiao87EmmyMiao87EmmyMiao87 approved these changes
@kangkaisenkangkaisenkangkaisen left review comments
+1 more reviewer
@zhangy5zhangy5zhangy5 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@morningmanmorningman

Labels

api-reviewCategorizes an issue or PR as actively needing an API review.area/sql/functionIssues or PRs related to the SQL functionskind/featureCategorizes issue or PR as related to a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@morningman@imay@yangzhg@kangkaisen@zhangy5@EmmyMiao87@morningman-cmy