Uh oh!
There was an error while loading. Please reload this page.
[improve](cloud) use delete bitmap cache to reduce sync rowset time - #35856
Merged
Conversation
doris-robot
commented
Jun 4, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
hust-hhb
commented
Jun 4, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Jun 4, 2024
TeamCity be ut coverage result: |
doris-robot
commented
Jun 4, 2024
TPC-H: Total hot run time: 41494 ms |
doris-robot
commented
Jun 4, 2024
TPC-DS: Total hot run time: 171359 ms |
doris-robot
commented
Jun 4, 2024
ClickBench: Total hot run time: 29.95 s |
hust-hhbforce-pushed
the
use-delete-bitmap-cache
branch
from
June 13, 2024 10:08
0372ffc to
753f892Comparehust-hhb
commented
Jun 13, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
hust-hhb
commented
Jun 14, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Jun 14, 2024
TPC-H: Total hot run time: 40248 ms |
doris-robot
commented
Jun 14, 2024
TeamCity be ut coverage result: |
doris-robot
commented
Jun 14, 2024
TPC-DS: Total hot run time: 172534 ms |
doris-robot
commented
Jun 14, 2024
ClickBench: Total hot run time: 30.58 s |
Uh oh!
There was an error while loading. Please reload this page.
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
dataroaring pushed a commit
that referenced
this pull request
Jun 21, 2024
…35856) My test show that get_delete_bitmap from metaservice may cost too much time while doing sync_rowset in cloud mode, which may lead to calculating delete bitmap slow on publish phase, we can use the existing delete bitmap cache to slove this problem.
dataroaring pushed a commit
that referenced
this pull request
Sep 26, 2024
…map from cache failed (#41309) ## Proposed changes Issue Number: close #xxx To accelerate the speed of sync latest delete bitmap, #35856 try to get the delete bitmap from `CloudTxnDeleteBitmapCache` first. In the following situation, compaction may get empty delete bitmap and cause duplicate key: 1. compaction started 2. several load succeed during the compaction 3. compaction finished data merging and start to calculate delete bitmap generated by latest load tasks 4. compaction try to sync rowset and delete bitmap, it get delete bitmap first from `CloudTxnDeleteBitmapCache` 5. `CloudTxnDeleteBitmapCache::get_delete_bitmap()` can get txn infos from it's inner map, but cache missed when it try to get delete bitmap from LRU cache, it don't report error but returned an empty delete bitmap 6. compaction used wrong delete bitmap, duplicate key occured.
dataroaring pushed a commit
that referenced
this pull request
Sep 26, 2024
…map from cache failed (#41309) ## Proposed changes Issue Number: close #xxx To accelerate the speed of sync latest delete bitmap, #35856 try to get the delete bitmap from `CloudTxnDeleteBitmapCache` first. In the following situation, compaction may get empty delete bitmap and cause duplicate key: 1. compaction started 2. several load succeed during the compaction 3. compaction finished data merging and start to calculate delete bitmap generated by latest load tasks 4. compaction try to sync rowset and delete bitmap, it get delete bitmap first from `CloudTxnDeleteBitmapCache` 5. `CloudTxnDeleteBitmapCache::get_delete_bitmap()` can get txn infos from it's inner map, but cache missed when it try to get delete bitmap from LRU cache, it don't report error but returned an empty delete bitmap 6. compaction used wrong delete bitmap, duplicate key occured.
cjj2010 pushed a commit
to cjj2010/doris
that referenced
this pull request
Oct 12, 2024
…map from cache failed (apache#41309) ## Proposed changes Issue Number: close #xxx To accelerate the speed of sync latest delete bitmap, apache#35856 try to get the delete bitmap from `CloudTxnDeleteBitmapCache` first. In the following situation, compaction may get empty delete bitmap and cause duplicate key: 1. compaction started 2. several load succeed during the compaction 3. compaction finished data merging and start to calculate delete bitmap generated by latest load tasks 4. compaction try to sync rowset and delete bitmap, it get delete bitmap first from `CloudTxnDeleteBitmapCache` 5. `CloudTxnDeleteBitmapCache::get_delete_bitmap()` can get txn infos from it's inner map, but cache missed when it try to get delete bitmap from LRU cache, it don't report error but returned an empty delete bitmap 6. compaction used wrong delete bitmap, duplicate key occured.
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…pache#35856) My test show that get_delete_bitmap from metaservice may cost too much time while doing sync_rowset in cloud mode, which may lead to calculating delete bitmap slow on publish phase, we can use the existing delete bitmap cache to slove this problem.
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…map from cache failed (apache#41309) ## Proposed changes Issue Number: close #xxx To accelerate the speed of sync latest delete bitmap, apache#35856 try to get the delete bitmap from `CloudTxnDeleteBitmapCache` first. In the following situation, compaction may get empty delete bitmap and cause duplicate key: 1. compaction started 2. several load succeed during the compaction 3. compaction finished data merging and start to calculate delete bitmap generated by latest load tasks 4. compaction try to sync rowset and delete bitmap, it get delete bitmap first from `CloudTxnDeleteBitmapCache` 5. `CloudTxnDeleteBitmapCache::get_delete_bitmap()` can get txn infos from it's inner map, but cache missed when it try to get delete bitmap from LRU cache, it don't report error but returned an empty delete bitmap 6. compaction used wrong delete bitmap, duplicate key occured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
My test show that get_delete_bitmap from metaservice may cost too much time while doing sync_rowset in cloud mode, which may lead to calculating delete bitmap slow on publish phase, we can use the existing delete bitmap cache to slove this problem.