Skip to content

[bugfix](paimon)paimon's field length judgment error - #35981

Merged
morningman merged 1 commit into
apache:masterfrom
wuwenchi:fix-paimon-testcase
Jun 13, 2024
Merged

[bugfix](paimon)paimon's field length judgment error#35981
morningman merged 1 commit into
apache:masterfrom
wuwenchi:fix-paimon-testcase

Conversation

@wuwenchi

@wuwenchiwuwenchi commented Jun 6, 2024•
edited by morningman
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Introduced from #35309
fields.length indicates the fields we want to read. If a table has 10 fields, but we only select a few fields, then the length of fields.length will definitely be less than 10.
So the judgment condition here should be greater than.

@doris-robot

doris-robot commented Jun 6, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wuwenchi

wuwenchi commented Jun 6, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jun 6, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 40888 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0b2e5cec83025ce71a25f0cbf61c5ea9384cc03d, data reload: false
------ Round 1 ----------------------------------
q1	17618	4341	4226	4226
q2	2032	195	192	192
q3	10441	1209	1110	1110
q4	10196	834	828	828
q5	7499	2716	2735	2716
q6	238	136	136	136
q7	982	614	612	612
q8	9223	2122	2105	2105
q9	9136	6700	6694	6694
q10	9259	3875	3857	3857
q11	477	233	237	233
q12	459	235	233	233
q13	17460	3220	3205	3205
q14	264	200	219	200
q15	516	480	485	480
q16	515	404	384	384
q17	969	696	656	656
q18	8401	7850	7699	7699
q19	5710	1335	1452	1335
q20	665	326	325	325
q21	5117	3324	3362	3324
q22	400	348	338	338
Total cold run time: 117577 ms
Total hot run time: 40888 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4534	4504	4455	4455
q2	372	261	271	261
q3	3157	2933	3044	2933
q4	1976	1619	1623	1619
q5	5399	5513	5466	5466
q6	227	127	129	127
q7	2167	1867	1807	1807
q8	3232	3374	3397	3374
q9	8690	8578	8681	8578
q10	4104	3828	3808	3808
q11	569	503	493	493
q12	783	583	583	583
q13	17228	3099	3116	3099
q14	295	294	258	258
q15	514	490	490	490
q16	468	414	424	414
q17	1825	1491	1464	1464
q18	8002	7738	7260	7260
q19	1746	1502	1615	1502
q20	3011	1812	1793	1793
q21	4810	4750	4777	4750
q22	628	543	536	536
Total cold run time: 73737 ms
Total hot run time: 55070 ms

@doris-robot

doris-robot commented Jun 6, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 171076 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0b2e5cec83025ce71a25f0cbf61c5ea9384cc03d, data reload: false
query1	933	386	389	386
query2	7752	2273	2300	2273
query3	6645	211	210	210
query4	19423	17283	17145	17145
query5	4111	469	458	458
query6	246	159	159	159
query7	4587	297	290	290
query8	320	288	285	285
query9	8625	2400	2377	2377
query10	449	297	274	274
query11	10493	10101	10100	10100
query12	133	85	85	85
query13	1644	363	369	363
query14	10024	7500	6007	6007
query15	223	191	182	182
query16	7598	262	255	255
query17	1314	523	516	516
query18	1947	280	279	279
query19	213	144	151	144
query20	100	82	80	80
query21	200	142	125	125
query22	4343	4249	4036	4036
query23	33471	32958	32887	32887
query24	11269	2872	2758	2758
query25	608	369	361	361
query26	1205	154	153	153
query27	2431	319	315	315
query28	7039	2045	2043	2043
query29	918	611	600	600
query30	283	149	150	149
query31	925	749	747	747
query32	91	50	53	50
query33	762	303	280	280
query34	967	479	460	460
query35	726	613	617	613
query36	1067	887	913	887
query37	133	69	69	69
query38	2873	2743	2761	2743
query39	869	792	806	792
query40	211	124	122	122
query41	56	50	53	50
query42	119	97	98	97
query43	611	539	544	539
query44	1207	732	736	732
query45	189	154	168	154
query46	1080	767	719	719
query47	1877	1777	1804	1777
query48	366	297	293	293
query49	996	407	418	407
query50	793	374	389	374
query51	6831	6744	6700	6700
query52	99	95	86	86
query53	356	285	285	285
query54	891	455	440	440
query55	71	73	73	73
query56	269	253	262	253
query57	1128	1059	1053	1053
query58	248	238	249	238
query59	3545	3349	3044	3044
query60	297	268	280	268
query61	99	88	85	85
query62	646	442	439	439
query63	316	310	283	283
query64	8869	2237	1759	1759
query65	3163	3081	3159	3081
query66	813	332	328	328
query67	15439	15008	14841	14841
query68	4483	560	553	553
query69	488	359	332	332
query70	1194	1104	1089	1089
query71	375	276	273	273
query72	7181	5557	5649	5557
query73	751	326	324	324
query74	5906	5441	5551	5441
query75	3381	2684	2684	2684
query76	2276	921	873	873
query77	498	296	279	279
query78	10274	9820	9742	9742
query79	2457	509	502	502
query80	1180	466	459	459
query81	597	218	217	217
query82	746	100	103	100
query83	240	170	162	162
query84	253	84	83	83
query85	1873	292	263	263
query86	503	330	310	310
query87	3271	3102	3126	3102
query88	4141	2354	2398	2354
query89	471	385	370	370
query90	1809	184	183	183
query91	122	94	101	94
query92	63	48	46	46
query93	2257	520	504	504
query94	1210	196	182	182
query95	394	308	299	299
query96	584	264	267	264
query97	3162	2961	3001	2961
query98	214	202	192	192
query99	1341	851	826	826
Total cold run time: 271240 ms
Total hot run time: 171076 ms

@doris-robot

doris-robot commented Jun 6, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0b2e5cec83025ce71a25f0cbf61c5ea9384cc03d, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.06
query4	1.65	0.07	0.08
query5	0.51	0.48	0.49
query6	1.13	0.73	0.72
query7	0.02	0.02	0.01
query8	0.06	0.04	0.05
query9	0.55	0.50	0.49
query10	0.54	0.53	0.55
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.60	0.59
query14	0.78	0.79	0.77
query15	0.83	0.81	0.81
query16	0.37	0.36	0.37
query17	1.04	1.03	0.97
query18	0.22	0.25	0.27
query19	1.92	1.66	1.69
query20	0.02	0.01	0.01
query21	15.44	0.74	0.69
query22	5.05	6.14	1.86
query23	18.31	1.34	1.24
query24	2.08	0.22	0.22
query25	0.16	0.08	0.08
query26	0.26	0.18	0.18
query27	0.08	0.07	0.09
query28	13.26	1.01	0.99
query29	13.27	3.24	3.26
query30	0.24	0.06	0.05
query31	2.86	0.38	0.39
query32	3.27	0.46	0.46
query33	2.85	2.92	2.92
query34	17.11	4.49	4.45
query35	4.46	4.49	4.58
query36	0.66	0.48	0.49
query37	0.18	0.16	0.15
query38	0.15	0.14	0.15
query39	0.04	0.03	0.04
query40	0.17	0.14	0.13
query41	0.08	0.04	0.05
query42	0.06	0.04	0.04
query43	0.03	0.03	0.04
Total cold run time: 110.97 s
Total hot run time: 30.47 s

morningman
morningman approved these changes Jun 7, 2024
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added usercase Important user case type label dev/2.1.x labels Jun 7, 2024
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 7, 2024
@github-actions

github-actionsBot commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

zddr
zddr approved these changes Jun 7, 2024
View reviewed changes
@wuwenchiwuwenchi mentioned this pull request Jun 7, 2024
Merged
morningman pushed a commit that referenced this pull request Jun 7, 2024
@wuwenchi
[bugfix](paimon)paimon's field length judgment error for 2.1 (#36049)
bd6b913
bp #35981
@morningman
morningman merged commit ba4b325 into apache:masterJun 13, 2024
dataroaring pushed a commit that referenced this pull request Jun 17, 2024
@wuwenchi@dataroaring
[bugfix](paimon)paimon's field length judgment error (#35981)
b5dcfbd
## Proposed changes
Introduced from #35309
`fields.length` indicates the fields we want to read. If a table has 10
fields, but we only select a few fields, then the length of
`fields.length` will definitely be less than 10.
So the judgment condition here should be greater than.
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@wuwenchi@HappenLee
[bugfix](paimon)paimon's field length judgment error (apache#35981)
ad9d13c
## Proposed changes
Introduced from apache#35309
`fields.length` indicates the fields we want to read. If a table has 10
fields, but we only select a few fields, then the length of
`fields.length` will definitely be less than 10.
So the judgment condition here should be greater than.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@zddrzddrzddr approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.4-mergeddev/3.0.0-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wuwenchi@doris-robot@morningman@zddr@dataroaring