Uh oh!
There was an error while loading. Please reload this page.
Revert "[fix](auto-partition) fix auto partition load lost data in multi sender (#35287)" - #36098
Merged
Merged
Conversation
…lti send…" This reverts commit c2fc485.
doris-robot
commented
Jun 11, 2024
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zclllyybb
commented
Jun 11, 2024
ContributorAuthor
run buildall |
| LoadChannel::LoadChannel(const UniqueId& load_id, int64_t timeout_s, bool is_high_priority, | ||
| std::string sender_ip, int64_t backend_id, bool enable_profile) | ||
| const std::string& sender_ip, int64_t backend_id, bool enable_profile) |
Contributor
There was a problem hiding this comment.
warning: pass by value and use std::move [modernize-pass-by-value]
be/src/runtime/load_channel.cpp:21:
++ #include <utility>
Suggested change
| conststd::string& sender_ip, int64_t backend_id, bool enable_profile) | |
| std::string sender_ip, int64_t backend_id, bool enable_profile) |
be/src/runtime/load_channel.cpp:39:
- _sender_ip(sender_ip),+ _sender_ip(std::move(sender_ip)),be/src/runtime/load_channel.h:54:
- const std::string& sender_ip, int64_t backend_id, bool enable_profile);+ std::string sender_ip, int64_t backend_id, bool enable_profile);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #35630 because it brought some more damaging bugs. we will fix it and merge in next version