Skip to content

Fix snapshot's making header bug#362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Nov 28, 2018
Merged

Fix snapshot's making header bug #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions be/src/olap/olap_snapshot.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -377,15 +377,6 @@ OLAPStatus OLAPEngine::_create_snapshot_files(
header_locked = false;
_update_header_file_info(shortest_versions, new_olap_header);

// save new header
if ((res = OlapHeaderManager::save(store, ref_olap_table->tablet_id(),
ref_olap_table->schema_hash(), new_olap_header)) != OLAP_SUCCESS) {
LOG(WARNING) << "save header error. [table=" << ref_olap_table->full_name()
<< "tablet_id=" << ref_olap_table->full_name()
<< ", schema_hash=" << ref_olap_table->schema_hash();
break;
}

// save new header to snapshot header path
res = new_olap_header->save(header_path);
if (res != OLAP_SUCCESS) {
Expand DownExpand Up@@ -791,8 +782,6 @@ OLAPStatus OLAPEngine::_generate_new_header(
_update_header_file_info(version_entity_vec, new_olap_header);
new_olap_header->set_shard(new_shard);

_update_header_file_info(version_entity_vec, new_olap_header);

res = OlapHeaderManager::save(store, tablet->tablet_id(), tablet->schema_hash(), new_olap_header);
if (res != OLAP_SUCCESS) {
OLAP_LOG_WARNING("fail to save olap header to new db. [res=%d]", res);
Expand Down