Skip to content

[fix](auth)Auth support case insensitive - #36381

Merged
morningman merged 3 commits into
apache:masterfrom
zddr:auth_ignore_sensitive
Jun 19, 2024
Merged

[fix](auth)Auth support case insensitive#36381
morningman merged 3 commits into
apache:masterfrom
zddr:auth_ignore_sensitive

Conversation

@zddr

@zddrzddr commented Jun 17, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

when lower_case_table_names != 0,check table auth ignore case

if table name is "Table1",if grant xxx on table1 to user1;

user1 has priv select Table1

@doris-robot

doris-robot commented Jun 17, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zddr

zddr commented Jun 17, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@zddr
zddr marked this pull request as draft June 17, 2024 07:18
@doris-robot

doris-robot commented Jun 17, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 39578 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e982458fe614c643d654dbe55431a5d4edc10f3b, data reload: false
------ Round 1 ----------------------------------
q1	17625	4357	4289	4289
q2	2025	192	201	192
q3	10446	1086	1127	1086
q4	10182	801	889	801
q5	7465	2650	2618	2618
q6	219	135	137	135
q7	967	606	601	601
q8	9221	2066	2049	2049
q9	8697	6499	6490	6490
q10	8997	3682	3675	3675
q11	455	239	236	236
q12	437	244	227	227
q13	18729	2943	2989	2943
q14	263	241	223	223
q15	506	466	465	465
q16	532	377	380	377
q17	958	684	654	654
q18	7960	7514	7340	7340
q19	4844	1370	1437	1370
q20	655	324	324	324
q21	4913	3136	3860	3136
q22	400	347	350	347
Total cold run time: 116496 ms
Total hot run time: 39578 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4466	4222	4213	4213
q2	374	265	275	265
q3	3006	2819	2869	2819
q4	1970	1702	1668	1668
q5	5616	5523	5531	5523
q6	218	127	131	127
q7	2170	1841	1848	1841
q8	3304	3485	3414	3414
q9	8710	8595	8790	8595
q10	4068	3874	3714	3714
q11	626	499	508	499
q12	840	636	626	626
q13	17108	3175	3142	3142
q14	307	286	273	273
q15	526	497	488	488
q16	498	467	442	442
q17	1806	1499	1488	1488
q18	8122	7872	7706	7706
q19	1806	1467	1606	1467
q20	3301	1872	1850	1850
q21	5204	4955	4764	4764
q22	640	538	578	538
Total cold run time: 74686 ms
Total hot run time: 55462 ms

@doris-robot

doris-robot commented Jun 17, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 173828 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e982458fe614c643d654dbe55431a5d4edc10f3b, data reload: false
query1	925	381	374	374
query2	6560	2545	2256	2256
query3	6637	206	204	204
query4	21732	17225	17336	17225
query5	3607	490	481	481
query6	237	160	159	159
query7	4578	301	288	288
query8	326	280	280	280
query9	8647	2430	2342	2342
query10	575	294	271	271
query11	10512	10112	9993	9993
query12	117	89	82	82
query13	1638	369	372	369
query14	9840	7143	7741	7143
query15	231	193	188	188
query16	7726	265	267	265
query17	1674	536	516	516
query18	1946	292	269	269
query19	196	163	159	159
query20	93	81	81	81
query21	211	129	130	129
query22	4337	3984	3907	3907
query23	33769	33564	33820	33564
query24	11153	2893	2980	2893
query25	588	386	375	375
query26	719	161	161	161
query27	2355	333	326	326
query28	6219	2133	2103	2103
query29	912	632	645	632
query30	251	149	158	149
query31	947	757	775	757
query32	89	55	54	54
query33	764	295	284	284
query34	1021	498	498	498
query35	738	644	642	642
query36	1091	976	1001	976
query37	145	74	74	74
query38	2960	2888	2874	2874
query39	884	851	846	846
query40	216	139	130	130
query41	58	52	51	51
query42	137	98	100	98
query43	586	554	529	529
query44	1205	727	737	727
query45	196	161	169	161
query46	1080	715	739	715
query47	1882	1762	1771	1762
query48	368	295	298	295
query49	842	418	433	418
query50	757	400	399	399
query51	6787	6697	6692	6692
query52	109	93	94	93
query53	355	296	289	289
query54	901	448	458	448
query55	75	72	76	72
query56	293	281	281	281
query57	1136	1067	1065	1065
query58	264	245	249	245
query59	3426	3214	3138	3138
query60	306	296	300	296
query61	108	105	105	105
query62	618	441	438	438
query63	323	293	291	291
query64	8629	2320	1838	1838
query65	3318	3118	3097	3097
query66	764	324	327	324
query67	15430	14881	15189	14881
query68	4633	536	540	536
query69	699	461	399	399
query70	1178	1089	1068	1068
query71	457	284	277	277
query72	8400	5812	5413	5413
query73	759	329	327	327
query74	5811	5505	5494	5494
query75	4428	2675	2692	2675
query76	3089	1073	896	896
query77	747	300	297	297
query78	10513	9897	9768	9768
query79	2587	526	509	509
query80	2798	468	475	468
query81	629	212	228	212
query82	776	107	102	102
query83	323	170	167	167
query84	266	91	84	84
query85	1889	291	273	273
query86	477	321	318	318
query87	3232	3115	3067	3067
query88	4069	2355	2366	2355
query89	461	385	388	385
query90	1984	190	194	190
query91	131	102	100	100
query92	62	52	49	49
query93	2384	510	505	505
query94	1405	189	186	186
query95	410	313	307	307
query96	590	266	275	266
query97	3205	3072	3046	3046
query98	229	204	191	191
query99	1146	837	831	831
Total cold run time: 276886 ms
Total hot run time: 173828 ms

@doris-robot

doris-robot commented Jun 17, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e982458fe614c643d654dbe55431a5d4edc10f3b, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.08
query5	0.49	0.49	0.58
query6	1.13	0.72	0.71
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.54	0.49	0.49
query10	0.54	0.55	0.54
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.58	0.59	0.60
query14	0.76	0.79	0.77
query15	0.82	0.81	0.82
query16	0.37	0.37	0.37
query17	1.00	1.01	0.95
query18	0.22	0.25	0.25
query19	1.80	1.76	1.74
query20	0.01	0.01	0.01
query21	15.40	0.67	0.66
query22	4.59	6.85	1.75
query23	18.27	1.39	1.23
query24	2.16	0.21	0.23
query25	0.15	0.09	0.08
query26	0.26	0.17	0.18
query27	0.09	0.08	0.08
query28	13.21	1.01	0.99
query29	12.64	3.20	3.25
query30	0.26	0.07	0.05
query31	2.86	0.38	0.38
query32	3.31	0.47	0.46
query33	2.95	2.93	2.92
query34	17.19	4.44	4.43
query35	4.45	4.54	4.49
query36	0.64	0.46	0.48
query37	0.17	0.15	0.15
query38	0.15	0.14	0.14
query39	0.04	0.04	0.04
query40	0.17	0.14	0.15
query41	0.10	0.05	0.04
query42	0.05	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.81 s
Total hot run time: 30.34 s

@zddr
zddr marked this pull request as ready for review June 17, 2024 10:10
@zddr

zddr commented Jun 17, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Jun 17, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 39379 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c8fdd8d7514969d5cdad3595decf071ccb64a63e, data reload: false
------ Round 1 ----------------------------------
q1	17624	4294	4252	4252
q2	2017	186	191	186
q3	10456	1156	991	991
q4	10183	734	787	734
q5	7453	2670	2598	2598
q6	222	135	135	135
q7	973	604	597	597
q8	9213	2061	2030	2030
q9	8645	6501	6431	6431
q10	8976	3732	3707	3707
q11	471	227	232	227
q12	473	234	224	224
q13	17760	2986	2962	2962
q14	270	218	217	217
q15	529	476	483	476
q16	511	391	376	376
q17	954	627	735	627
q18	7924	7463	7371	7371
q19	2456	1511	1473	1473
q20	655	322	337	322
q21	4986	3216	3118	3118
q22	386	328	325	325
Total cold run time: 113137 ms
Total hot run time: 39379 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4354	4246	4229	4229
q2	364	267	252	252
q3	3012	2746	2724	2724
q4	1967	1695	1694	1694
q5	5567	5609	5550	5550
q6	220	128	129	128
q7	2258	1858	1806	1806
q8	3256	3406	3409	3406
q9	8747	8644	8738	8644
q10	4142	3909	3970	3909
q11	590	483	481	481
q12	770	583	596	583
q13	15771	3207	3208	3207
q14	307	272	275	272
q15	539	471	489	471
q16	495	464	460	460
q17	1802	1540	1499	1499
q18	8305	8003	7998	7998
q19	4279	1509	1642	1509
q20	2098	1871	1881	1871
q21	5052	5003	4873	4873
q22	624	550	571	550
Total cold run time: 74519 ms
Total hot run time: 56116 ms

@doris-robot

doris-robot commented Jun 17, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 174440 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c8fdd8d7514969d5cdad3595decf071ccb64a63e, data reload: false
query1	936	381	369	369
query2	6441	2422	2314	2314
query3	6636	200	207	200
query4	19884	17454	17330	17330
query5	3581	487	476	476
query6	242	158	160	158
query7	4578	306	289	289
query8	308	285	284	284
query9	8494	2414	2410	2410
query10	578	308	290	290
query11	10676	10043	10087	10043
query12	120	99	88	88
query13	1662	370	362	362
query14	10123	7201	7221	7201
query15	258	193	183	183
query16	7788	268	260	260
query17	1878	568	514	514
query18	1945	283	274	274
query19	205	156	156	156
query20	103	86	87	86
query21	212	127	124	124
query22	4376	4096	4034	4034
query23	33792	33633	33625	33625
query24	11147	2908	2912	2908
query25	615	373	380	373
query26	1207	162	167	162
query27	2488	340	334	334
query28	6971	2126	2127	2126
query29	949	684	666	666
query30	283	156	159	156
query31	987	802	776	776
query32	99	54	56	54
query33	750	290	308	290
query34	1016	483	485	483
query35	719	673	620	620
query36	1067	951	970	951
query37	176	76	82	76
query38	2935	2808	2857	2808
query39	913	824	859	824
query40	212	129	130	129
query41	56	51	56	51
query42	119	116	103	103
query43	582	562	543	543
query44	1209	719	736	719
query45	193	158	172	158
query46	1080	727	725	725
query47	1860	1791	1760	1760
query48	387	294	297	294
query49	847	411	409	409
query50	767	397	398	397
query51	6894	6640	6638	6638
query52	104	93	90	90
query53	365	296	284	284
query54	896	441	444	441
query55	75	74	73	73
query56	279	258	267	258
query57	1106	1039	1044	1039
query58	259	251	243	243
query59	3399	3232	3253	3232
query60	300	281	305	281
query61	129	110	118	110
query62	604	448	449	448
query63	319	295	303	295
query64	8910	2260	1737	1737
query65	3213	3163	3128	3128
query66	817	326	321	321
query67	15490	15229	15189	15189
query68	4488	527	532	527
query69	493	337	314	314
query70	1180	1068	1080	1068
query71	383	280	273	273
query72	7074	5222	5660	5222
query73	748	327	330	327
query74	5947	5514	5519	5514
query75	3329	2654	2712	2654
query76	2126	1000	881	881
query77	446	304	304	304
query78	10380	10001	9923	9923
query79	2258	528	513	513
query80	1317	486	469	469
query81	590	221	227	221
query82	950	107	103	103
query83	272	169	167	167
query84	246	86	85	85
query85	1351	278	266	266
query86	479	339	310	310
query87	3296	3073	3133	3073
query88	3983	2372	2362	2362
query89	478	390	381	381
query90	1739	198	188	188
query91	139	100	100	100
query92	61	48	49	48
query93	2354	499	497	497
query94	1097	192	191	191
query95	410	319	321	319
query96	591	267	270	267
query97	3201	3063	3060	3060
query98	227	197	274	197
query99	1248	844	859	844
Total cold run time: 270490 ms
Total hot run time: 174440 ms

@doris-robot

doris-robot commented Jun 17, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.79 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c8fdd8d7514969d5cdad3595decf071ccb64a63e, data reload: false
query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.23	0.07	0.05
query4	1.67	0.10	0.09
query5	0.50	0.49	0.49
query6	1.12	0.72	0.73
query7	0.02	0.02	0.02
query8	0.05	0.05	0.04
query9	0.54	0.49	0.50
query10	0.55	0.55	0.56
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.58
query14	0.80	0.78	0.78
query15	0.83	0.82	0.83
query16	0.37	0.37	0.37
query17	1.03	1.04	1.03
query18	0.21	0.21	0.26
query19	1.77	1.70	1.72
query20	0.01	0.00	0.00
query21	15.42	0.64	0.66
query22	4.18	7.05	2.01
query23	18.22	1.31	1.31
query24	2.14	0.24	0.22
query25	0.16	0.09	0.08
query26	0.26	0.17	0.18
query27	0.08	0.08	0.08
query28	13.30	1.02	1.00
query29	12.87	3.34	3.28
query30	0.25	0.07	0.06
query31	2.86	0.39	0.38
query32	3.31	0.47	0.48
query33	2.90	2.87	2.91
query34	17.07	4.53	4.44
query35	4.49	4.51	4.48
query36	0.66	0.46	0.51
query37	0.18	0.16	0.15
query38	0.15	0.14	0.15
query39	0.04	0.04	0.04
query40	0.17	0.14	0.15
query41	0.09	0.05	0.05
query42	0.05	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 109.63 s
Total hot run time: 30.79 s

@zddr

zddr commented Jun 17, 2024

Copy link
Copy Markdown
ContributorAuthor

run feut

morningman
morningman approved these changes Jun 19, 2024
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 19, 2024
@github-actions

github-actionsBot commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit 5b6d04a into apache:masterJun 19, 2024
zddr added a commit to zddr/incubator-doris that referenced this pull request Jun 19, 2024
@zddr
[fix](auth)Auth support case insensitive (apache#36381)
43bfbe0
when `lower_case_table_names ` != 0, check table auth ignore case
@zddrzddr mentioned this pull request Jun 19, 2024
Merged
zddr added a commit to zddr/incubator-doris that referenced this pull request Jun 19, 2024
@zddr
[fix](auth)Auth support case insensitive (apache#36381)
ffc2fc4
when `lower_case_table_names ` != 0, check table auth ignore case
@zddrzddr mentioned this pull request Jun 19, 2024
Merged
xiaokang pushed a commit that referenced this pull request Jun 20, 2024
@zddr
[fix](auth)Auth support case insensitive (#36381) (#36558)
5443cbf
morningman pushed a commit that referenced this pull request Jun 20, 2024
@zddr
[fix](auth)Auth support case insensitive (#36381) (#36557)
22d37ba
pick from: #36381
dataroaring pushed a commit that referenced this pull request Jun 21, 2024
@zddr@dataroaring
[fix](auth)Auth support case insensitive (#36381)
5a6ad1f
when `lower_case_table_names ` != 0, check table auth ignore case
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zddrcaiconghui1
[fix](auth)Auth support case insensitive (apache#36381) (apache#36558)
4bbfa71
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zddr@HappenLee
[fix](auth)Auth support case insensitive (apache#36381)
32a2cb7
when `lower_case_table_names ` != 0, check table auth ignore case
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@wuwenchiwuwenchiwuwenchi approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.12-mergeddev/2.1.4-mergeddev/3.0.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zddr@doris-robot@morningman@wuwenchi@xiaokang@dataroaring