Skip to content

[bug] init be log file length when restart be - #3649

Merged
morningman merged 1 commit into
apache:masterfrom
songenjie:glog-fdopen-to-fopen
May 26, 2020
Merged

[bug] init be log file length when restart be#3649
morningman merged 1 commit into
apache:masterfrom
songenjie:glog-fdopen-to-fopen

Conversation

@songenjie

@songenjiesongenjie commented May 21, 2020

Copy link
Copy Markdown
Contributor

issue

int fd = open(filename, O_WRONLY | O_CREAT /* | O_EXCL */ | O_APPEND, 0664); fdopen(fd, "ra") 

view

*** Aborted at 1590044592 (unix time) try "date -d @1590044592" if you are using GNU date ***
PC: @ 0x7f0fa14679ec __GI_fseek
*** SIGSEGV (@0x0) received by PID 79596 (TID 0x7f0fa22ed580) from PID 0; stack trace: ***
@ 0x7f0fa1429670 (unknown)
@ 0x7f0fa14679ec __GI_fseek
@ 0x23775e1 google::(anonymous namespace)::LogFileObject::Write()
@ 0x23730a4 google::LogMessage::SendToLog()
@ 0x23706d4 google::LogMessage::Flush()
@ 0x2370931 google::LogMessage::~LogMessage()
@ 0xdc3eb4 doris::init_daemon()
@ 0xc4eec7 main
@ 0x7f0fa1415b15 __libc_start_main
@ 0xda72d3 (unknown)

fix

use fopen

@chaoyli
chaoyli self-requested a review May 21, 2020 11:12
@chaoylichaoyli self-assigned this May 21, 2020
@chaoylichaoyli added the kind/fix Categorizes issue or PR as related to a bug. label May 21, 2020
@chaoyli

chaoyli commented May 21, 2020

Copy link
Copy Markdown
Contributor

It's better to create a issue to describe the bug which cause it.

@songenjie

Copy link
Copy Markdown
ContributorAuthor

#3593

@chaoylichaoyli changed the title [incubator-doris][be][log][glog][bug] convert init be log file length…[bug] init be log file length when restart beMay 25, 2020
@chaoyli

Copy link
Copy Markdown
Contributor

You can add another better case to test it.

@chaoyli

Copy link
Copy Markdown
Contributor

LGTM

@imayimay added the approved Indicates a PR has been approved by one committer. label May 25, 2020
@morningmanmorningman added the area/dependency Issues or PRs related to Doris dependencies label May 26, 2020
@morningman
morningman merged commit 12c59ba into apache:masterMay 26, 2020
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
…h wrongly when has filter (apache#3649)
pr: apache#43531
commitId: b2e42f2
pr: apache#43539 commitId: eb6c00cb0cecf4
---------
Co-authored-by: seawinde <wusi@selectdb.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/dependencyIssues or PRs related to Doris dependencieskind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@songenjie@chaoyli@imay@morningman